]> git.proxmox.com Git - mirror_edk2.git/commitdiff
BaseTools: Optimizing DscDefaultValue process in BuildReport
authorFrom: Yunhua Feng <yunhuax.feng@intel.com>
Sat, 20 Jan 2018 06:22:43 +0000 (14:22 +0800)
committerYonghong Zhu <yonghong.zhu@intel.com>
Sun, 21 Jan 2018 08:28:45 +0000 (16:28 +0800)
DscDefaultValue from Dsc file has been parsed by ValueExpressionEx
when Dsc file parse, so only DscDefaultValue from FDF file need
ValueExpressionEx parse

Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yunhua Feng <yunhuax.feng@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com>
BaseTools/Source/Python/build/BuildReport.py

index d6e943d2f1d48e9d5b66f48ae60e2b8122cc6806..f2a6e6d87eced2e072fe931cd8479ecd9180de37 100644 (file)
@@ -952,9 +952,9 @@ class PcdReport(object):
                     #\r
                     DecDefaultValue = self.DecPcdDefault.get((Pcd.TokenCName, Pcd.TokenSpaceGuidCName, DecType))\r
                     DscDefaultValue = self.DscPcdDefault.get((Pcd.TokenCName, Pcd.TokenSpaceGuidCName))\r
-                    DscDefaultValBak= DscDefaultValue\r
+                    DscDefaultValBak = DscDefaultValue\r
                     DscDefaultValue = self.FdfPcdSet.get((Pcd.TokenCName, Key), DscDefaultValue)\r
-                    if DscDefaultValue:\r
+                    if DscDefaultValue != DscDefaultValBak:\r
                         DscDefaultValue = ValueExpressionEx(DscDefaultValue, Pcd.DatumType, self._GuidDict)(True)\r
                     InfDefaultValue = None\r
                     \r