]> git.proxmox.com Git - mirror_edk2.git/commitdiff
OvmfPkg/AcpiTimerLib: don't use possibly unset PMBA register (PEI phase)
authorLaszlo Ersek <lersek@redhat.com>
Tue, 17 May 2016 14:08:23 +0000 (16:08 +0200)
committerLaszlo Ersek <lersek@redhat.com>
Tue, 17 May 2016 18:46:59 +0000 (20:46 +0200)
We should store the right value to the PMBA (if the PMBA needs
initialization) before setting mAcpiTimerIoAddr from the PMBA.

Cc: Gabriel Somlo <somlo@cmu.edu>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Fixes: f122712b42af3d63902c2c141e90d2c200df6790
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
Tested-by: Gabriel Somlo <somlo@cmu.edu>
OvmfPkg/Library/AcpiTimerLib/BaseAcpiTimerLib.c

index c3c50c05d31ed9d87b8f33de57ab05ab774fb43c..7144d75c732558bbd6d565f72d6ff9704b3dbd69 100644 (file)
@@ -63,8 +63,6 @@ AcpiTimerLibConstructor (
       return RETURN_UNSUPPORTED;\r
   }\r
 \r
-  mAcpiTimerIoAddr = (PciRead32 (Pmba) & ~PMBA_RTE) + ACPI_TIMER_OFFSET;\r
-\r
   //\r
   // Check to see if the Power Management Base Address is already enabled\r
   //\r
@@ -81,6 +79,7 @@ AcpiTimerLibConstructor (
     PciOr8 (AcpiCtlReg, AcpiEnBit);\r
   }\r
 \r
+  mAcpiTimerIoAddr = (PciRead32 (Pmba) & ~PMBA_RTE) + ACPI_TIMER_OFFSET;\r
   return RETURN_SUCCESS;\r
 }\r
 \r