]> git.proxmox.com Git - mirror_edk2.git/commitdiff
NetworkPkg: Fix Assert issue in iSCSI driver.
authorZhang, Lubo <lubo.zhang@intel.com>
Fri, 8 Jul 2016 07:50:46 +0000 (15:50 +0800)
committerJiaxin Wu <jiaxin.wu@intel.com>
Mon, 11 Jul 2016 02:46:49 +0000 (10:46 +0800)
The bug existed in replacing AsciiStrToUnicodeStr with AsciiStrToUnicodeStrS,
since MacString now is a pointer, the value sizeof(MacString)/sizeof (MacString[0])
is not correct here as the third parameter.

Cc: Fu Siyuan <siyuan.fu@intel.com>
Cc: Ye Ting <ting.ye@intel.com>
Cc: Wu Jiaxin <jiaxin.wu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo <lubo.zhang@intel.com>
Reviewed-By: Wu Jiaxin <jiaxin.wu@intel.com>
Reviewed-by: Ye Ting <ting.ye@intel.com>
Reviewed-by: Fu Siyuan <siyuan.fu@intel.com>
Reviewed-by: Star Zeng <star.zeng@intel.com>
NetworkPkg/IScsiDxe/IScsiConfig.c

index 8015e3de53ed7882934a4b5096a4f2182f33e3a9..3631e72e3455de488c47156b146a61eddf3bb0ae 100644 (file)
@@ -687,7 +687,7 @@ IScsiConvertIfrNvDataToAttemptConfigData (
     return EFI_OUT_OF_RESOURCES;\r
   }\r
 \r
-  AsciiStrToUnicodeStrS (Attempt->MacString, MacString, sizeof (MacString) / sizeof (MacString[0]));\r
+  AsciiStrToUnicodeStrS (Attempt->MacString, MacString, ISCSI_MAX_MAC_STRING_LEN);\r
 \r
   UnicodeSPrint (\r
     mPrivate->PortString,\r