]> git.proxmox.com Git - mirror_edk2.git/commitdiff
MdeModulePkg/HiiDatabaseDxe:remove dead code block
authorWenyi Xie <xiewenyi2@huawei.com>
Thu, 26 Aug 2021 01:16:03 +0000 (09:16 +0800)
committermergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Thu, 2 Sep 2021 10:42:59 +0000 (10:42 +0000)
As the if statement outside has confirmed that
BlockData->Name == NULL, so the if statement inside
is always false.

Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Dandan Bi <dandan.bi@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Signed-off-by: Wenyi Xie <xiewenyi2@huawei.com>
Reviewed-by: Dandan Bi <dandan.bi@intel.com>
MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c

index d492b769d51c775df870f16eceeb0a9e6024a30d..17a914208c6d68db8b5debe6af1ae0d2017ec372 100644 (file)
@@ -2871,9 +2871,6 @@ ParseIfrData (
         //\r
         if ((BlockData->Name == NULL) && ((BlockData->Offset + BlockData->Width) > VarStorageData->Size)) {\r
           Status = EFI_INVALID_PARAMETER;\r
-          if (BlockData->Name != NULL) {\r
-            FreePool (BlockData->Name);\r
-          }\r
           FreePool (BlockData);\r
           goto Done;\r
         }\r