]> git.proxmox.com Git - mirror_edk2.git/commitdiff
MdeModulePkg/BootMaintManagerUiLib: Declare EFIAPI for ChooseFile handler
authorDandan Bi <dandan.bi@intel.com>
Tue, 22 Mar 2016 02:38:01 +0000 (10:38 +0800)
committerFeng Tian <feng.tian@intel.com>
Wed, 23 Mar 2016 08:03:52 +0000 (16:03 +0800)
The BootMaintenanceManagerUiLib use ChooseFile() from FileExplorerLib
to select files. And the third parameter in ChooseFile() is CHOOSE_HANDLER,
per the definition of CHOOSE_HANDLER, it must use EFIAPI as the calling
convention. But the calling convention was not specified for following
handlers: CreateBootOptionFromFile, CreateDriverOptionFromFile,
BootFromFile. Now specifies the calling convention for those functions.

Cc: Liming Gao <liming.gao@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
Reviewed-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Gary Lin <glin@suse.com>
MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceManager.h
MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootOption.c

index 2c93446a0533455de6698f6be72fd5933754764d..d60731431e2323dcacc071b915f87986c3f5aed3 100644 (file)
@@ -1305,6 +1305,7 @@ BootMaintCallback (
 \r
 **/\r
 BOOLEAN \r
+EFIAPI\r
 CreateBootOptionFromFile (\r
   IN EFI_DEVICE_PATH_PROTOCOL    *FilePath\r
   );\r
@@ -1318,6 +1319,7 @@ CreateBootOptionFromFile (
   @retval FALSE  Not exit caller function.\r
 **/\r
 BOOLEAN \r
+EFIAPI\r
 CreateDriverOptionFromFile (\r
   IN EFI_DEVICE_PATH_PROTOCOL    *FilePath\r
   );\r
@@ -1332,6 +1334,7 @@ CreateDriverOptionFromFile (
   \r
 **/\r
 BOOLEAN \r
+EFIAPI\r
 BootFromFile (\r
   IN EFI_DEVICE_PATH_PROTOCOL    *FilePath\r
   );\r
index 0bd3170872c799c84da9342410cf97fedd6af3f2..7a014c911bbce9c32de5b9047c329ec1b1c0d9c6 100644 (file)
@@ -857,6 +857,7 @@ GetDriverOrder (
   @retval FALSE  Not exit caller function.\r
 **/\r
 BOOLEAN \r
+EFIAPI\r
 BootFromFile (\r
   IN EFI_DEVICE_PATH_PROTOCOL    *FilePath\r
   )\r
@@ -929,6 +930,7 @@ ReSendForm(
   @retval FALSE  Not exit caller function.\r
 **/\r
 BOOLEAN \r
+EFIAPI\r
 CreateBootOptionFromFile (\r
   IN EFI_DEVICE_PATH_PROTOCOL    *FilePath\r
   )\r
@@ -946,6 +948,7 @@ CreateBootOptionFromFile (
 \r
 **/\r
 BOOLEAN \r
+EFIAPI\r
 CreateDriverOptionFromFile (\r
   IN EFI_DEVICE_PATH_PROTOCOL    *FilePath\r
   )\r