BaseTools: AutoGen - refactor dictionary access

dont use dict.get() inside loops of dictionary contents. its not needed.

Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com>

diff --git a/BaseTools/Source/Python/AutoGen/GenVar.py b/BaseTools/Source/Python/AutoGen/GenVar.py
index b8f40da9a39c87d6f5a458be26aed0e232463739..b9517d84c69026513fac8b5687fb38fc87038e09 100644 (file)
--- a/BaseTools/Source/Python/AutoGen/GenVar.py
+++ b/BaseTools/Source/Python/AutoGen/GenVar.py
@@ -144,7 +144,7 @@ class VariableMgr(object):
             default_data_buffer = ""\r
             others_data_buffer = ""\r
             tail = None\r
-            default_sku_default = indexedvarinfo.get(index).get((DataType.TAB_DEFAULT,DataType.TAB_DEFAULT_STORES_DEFAULT))\r
+            default_sku_default = indexedvarinfo[index].get((DataType.TAB_DEFAULT,DataType.TAB_DEFAULT_STORES_DEFAULT))\r
 \r
             if default_sku_default.data_type not in DataType.TAB_PCD_NUMERIC_TYPES:\r
                 var_max_len = max([len(var_item.default_value.split(",")) for var_item in sku_var_info.values()])\r
@@ -159,11 +159,11 @@ class VariableMgr(object):
 \r
             var_data[(DataType.TAB_DEFAULT,DataType.TAB_DEFAULT_STORES_DEFAULT)][index] = (default_data_buffer,sku_var_info[(DataType.TAB_DEFAULT,DataType.TAB_DEFAULT_STORES_DEFAULT)])\r
 \r
-            for (skuid,defaultstoragename) in indexedvarinfo.get(index):\r
+            for (skuid,defaultstoragename) in indexedvarinfo[index]:\r
                 tail = None\r
                 if (skuid,defaultstoragename) == (DataType.TAB_DEFAULT,DataType.TAB_DEFAULT_STORES_DEFAULT):\r
                     continue\r
-                other_sku_other = indexedvarinfo.get(index).get((skuid,defaultstoragename))\r
+                other_sku_other = indexedvarinfo[index][(skuid,defaultstoragename)]\r
 \r
                 if default_sku_default.data_type not in DataType.TAB_PCD_NUMERIC_TYPES:\r
                     if len(other_sku_other.default_value.split(",")) < var_max_len:\r
@@ -220,7 +220,7 @@ class VariableMgr(object):
         for skuname,defaultstore in var_data:\r
             if (skuname,defaultstore) == (DataType.TAB_DEFAULT,DataType.TAB_DEFAULT_STORES_DEFAULT):\r
                 continue\r
-            pcds_sku_data = var_data.get((skuname,defaultstore))\r
+            pcds_sku_data = var_data[(skuname,defaultstore)]\r
             delta_data_set = []\r
             for pcdindex in pcds_sku_data:\r
                 offset = var_data_offset[pcdindex]\r