MdeModulePkg: Fix coding style issues

1. Make function comments align with the function.
2. Change the FILE_GUID value in SmmSmiHandlerProfileLib.inf
   since it is duplicated with the FILE_GUID value in
   SmiHandlerProfileLibNull.inf
3. Add missing PCD PROMPT&HELP string to uni file.

Cc: Jiewen Yao <jiewen.yao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>

diff --git a/MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfileInfo.c b/MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfileInfo.c
index 00cab0cd8e02de262085c9ec7aed6a1f22f09530..84a1c8ee53b680c1ddc7b05ac6f75fb2feb6e102 100644 (file)
--- a/MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfileInfo.c
+++ b/MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfileInfo.c
@@ -245,7 +245,7 @@ GetShortPdbFileName (
     2. FFS UI section\r
     3. Image GUID\r
 \r
-  @param[in] DriverInfo Pointer to memory profile driver info.\r
+  @param[in] ImageStruct  Point to the image structure.\r
 \r
   @return The resulting Ascii name string is stored in the mNameString global array.\r
 \r

diff --git a/MdeModulePkg/Library/SmmSmiHandlerProfileLib/SmmSmiHandlerProfileLib.inf b/MdeModulePkg/Library/SmmSmiHandlerProfileLib/SmmSmiHandlerProfileLib.inf
index 0c1ad7eb06965a65ea2689ae300616ca355b8d10..ba0d65ec08fe842fd9175588ab8a25d63c21a770 100644 (file)
--- a/MdeModulePkg/Library/SmmSmiHandlerProfileLib/SmmSmiHandlerProfileLib.inf
+++ b/MdeModulePkg/Library/SmmSmiHandlerProfileLib/SmmSmiHandlerProfileLib.inf
@@ -19,7 +19,7 @@
   INF_VERSION                    = 0x00010005\r
   BASE_NAME                      = SmmSmiHandlerProfileLib\r
   MODULE_UNI_FILE                = SmmSmiHandlerProfileLib.uni\r
-  FILE_GUID                      = B43D1B52-6251-4E6F-82EC-A599A5EE94C1\r
+  FILE_GUID                      = FC38CEAE-FB74-4049-A51C-68F0BA69DA7D\r
   MODULE_TYPE                    = DXE_SMM_DRIVER\r
   VERSION_STRING                 = 1.0\r
   LIBRARY_CLASS                  = SmiHandlerProfileLib|DXE_SMM_DRIVER\r

diff --git a/MdeModulePkg/MdeModulePkg.uni b/MdeModulePkg/MdeModulePkg.uni
index 5436b60d6b6538c1ee26ad0a4c7ae71ef913389f..ff0d6970784c60d7fcff7e5c9bed151938f3e4db 100644 (file)
--- a/MdeModulePkg/MdeModulePkg.uni
+++ b/MdeModulePkg/MdeModulePkg.uni
@@ -1075,3 +1075,17 @@
 \r
 #string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdTestKeyUsed_HELP  #language en-US "This dynamic PCD holds the information if there is any test key used by the platform."\r
 \r
+#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdSmiHandlerProfilePropertyMask_PROMPT  #language en-US "SmiHandlerProfile Property."\r
+\r
+#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdSmiHandlerProfilePropertyMask_HELP  #language en-US "The mask is used to control SmiHandlerProfile behavior.<BR><BR>\n"\r
+                                                                                                  "BIT0 - Enable SmiHandlerProfile.<BR>"\r
+\r
+#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdImageProtectionPolicy_PROMPT  #language en-US "Set image protection policy."\r
+\r
+#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdImageProtectionPolicy_HELP  #language en-US "Set image protection policy. The policy is bitwise.\n"\r
+                                                                                          "If a bit is set, the image will be protected by DxeCore if it is aligned.\n"\r
+                                                                                          "The code section becomes read-only, and the data section becomes non-executable.\n"\r
+                                                                                          "If a bit is clear, the image will not be protected.<BR><BR>\n"\r
+                                                                                          "BIT0       - Image from unknown device. <BR>\n"\r
+                                                                                          "BIT1       - Image from firmware volume.<BR>"\r
+\r