MdeModulePkg/SdMmcPciHcDxe: Add retries for sync commands

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1140

To increase the resiliency driver will now attempt to
retry the commands that failed due to the CRC error up
to 5 times. This should address the problems with the commands
that fail due to random condition on links. This should also
help the boards on which CMD13 is particularly unstable after
switching the link frequency.

Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Marcin Wojtas <mw@semihalf.com>
Cc: Zhichao Gao <zhichao.gao@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Mateusz Albecki <mateusz.albecki@intel.com>
Reviewed-by: Hao A Wu <hao.a.wu@intel.com>

diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c
index 373f1bed45a11cf29f45a99e6812350731d6b5be..193b0f24e229df207d2da7a410608bcb862ee81d 100644 (file)
--- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c
+++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c
@@ -7,7 +7,7 @@
   It would expose EFI_SD_MMC_PASS_THRU_PROTOCOL for upper layer use.\r
 \r
   Copyright (c) 2018-2019, NVIDIA CORPORATION. All rights reserved.\r
-  Copyright (c) 2015 - 2019, Intel Corporation. All rights reserved.<BR>\r
+  Copyright (c) 2015 - 2020, Intel Corporation. All rights reserved.<BR>\r
   SPDX-License-Identifier: BSD-2-Clause-Patent\r
 \r
 **/\r
@@ -974,6 +974,58 @@ SdMmcPciHcDriverBindingStop (
   return Status;\r
 }\r
 \r
+/**\r
+  Execute TRB synchronously.\r
+\r
+  @param[in] Private  Pointer to driver private data.\r
+  @param[in] Trb      Pointer to TRB to execute.\r
+\r
+  @retval EFI_SUCCESS  TRB executed successfully.\r
+  @retval Other        TRB failed.\r
+**/\r
+EFI_STATUS\r
+SdMmcPassThruExecSyncTrb (\r
+  IN SD_MMC_HC_PRIVATE_DATA  *Private,\r
+  IN SD_MMC_HC_TRB           *Trb\r
+  )\r
+{\r
+  EFI_STATUS  Status;\r
+  EFI_TPL     OldTpl;\r
+\r
+  //\r
+  // Wait async I/O list is empty before execute sync I/O operation.\r
+  //\r
+  while (TRUE) {\r
+    OldTpl = gBS->RaiseTPL (TPL_NOTIFY);\r
+    if (IsListEmpty (&Private->Queue)) {\r
+      gBS->RestoreTPL (OldTpl);\r
+      break;\r
+    }\r
+    gBS->RestoreTPL (OldTpl);\r
+  }\r
+\r
+  while (Trb->Retries) {\r
+    Status = SdMmcWaitTrbEnv (Private, Trb);\r
+    if (EFI_ERROR (Status)) {\r
+      return Status;\r
+    }\r
+\r
+    Status = SdMmcExecTrb (Private, Trb);\r
+    if (EFI_ERROR (Status)) {\r
+      return Status;\r
+    }\r
+\r
+    Status = SdMmcWaitTrbResult (Private, Trb);\r
+    if (Status == EFI_CRC_ERROR) {\r
+      Trb->Retries--;\r
+    } else {\r
+      return Status;\r
+    }\r
+  }\r
+\r
+  return Status;\r
+}\r
+\r
 /**\r
   Sends SD command to an SD card that is attached to the SD controller.\r
 \r
@@ -1023,7 +1075,6 @@ SdMmcPassThruPassThru (
   EFI_STATUS                      Status;\r
   SD_MMC_HC_PRIVATE_DATA          *Private;\r
   SD_MMC_HC_TRB                   *Trb;\r
-  EFI_TPL                         OldTpl;\r
 \r
   if ((This == NULL) || (Packet == NULL)) {\r
     return EFI_INVALID_PARAMETER;\r
@@ -1066,34 +1117,8 @@ SdMmcPassThruPassThru (
     return EFI_SUCCESS;\r
   }\r
 \r
-  //\r
-  // Wait async I/O list is empty before execute sync I/O operation.\r
-  //\r
-  while (TRUE) {\r
-    OldTpl = gBS->RaiseTPL (TPL_NOTIFY);\r
-    if (IsListEmpty (&Private->Queue)) {\r
-      gBS->RestoreTPL (OldTpl);\r
-      break;\r
-    }\r
-    gBS->RestoreTPL (OldTpl);\r
-  }\r
-\r
-  Status = SdMmcWaitTrbEnv (Private, Trb);\r
-  if (EFI_ERROR (Status)) {\r
-    goto Done;\r
-  }\r
-\r
-  Status = SdMmcExecTrb (Private, Trb);\r
-  if (EFI_ERROR (Status)) {\r
-    goto Done;\r
-  }\r
+  Status = SdMmcPassThruExecSyncTrb (Private, Trb);\r
 \r
-  Status = SdMmcWaitTrbResult (Private, Trb);\r
-  if (EFI_ERROR (Status)) {\r
-    goto Done;\r
-  }\r
-\r
-Done:\r
   SdMmcFreeTrb (Trb);\r
 \r
   return Status;\r

diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h
index 0304960132415b53137f8c862e31a4085850c8a3..5bc3577ba289ac836063566af5ea183e6cf4eca2 100644 (file)
--- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h
+++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h
@@ -3,7 +3,7 @@
   Provides some data structure definitions used by the SD/MMC host controller driver.\r
 \r
 Copyright (c) 2018-2019, NVIDIA CORPORATION. All rights reserved.\r
-Copyright (c) 2015, Intel Corporation. All rights reserved.<BR>\r
+Copyright (c) 2015 - 2020, Intel Corporation. All rights reserved.<BR>\r
 SPDX-License-Identifier: BSD-2-Clause-Patent\r
 \r
 **/\r
@@ -130,6 +130,8 @@ typedef struct {
 \r
 #define SD_MMC_HC_TRB_SIG             SIGNATURE_32 ('T', 'R', 'B', 'T')\r
 \r
+#define SD_MMC_TRB_RETRIES            5\r
+\r
 //\r
 // TRB (Transfer Request Block) contains information for the cmd request.\r
 //\r
@@ -152,6 +154,7 @@ typedef struct {
   EFI_EVENT                           Event;\r
   BOOLEAN                             Started;\r
   UINT64                              Timeout;\r
+  UINT32                              Retries;\r
 \r
   SD_MMC_HC_ADMA_32_DESC_LINE         *Adma32Desc;\r
   SD_MMC_HC_ADMA_64_V3_DESC_LINE      *Adma64V3Desc;\r

diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
index 85c97c1f273d00b33ae4547ac51b5d68be350077..b05c81846268a8559e8c7b59b37f1a84e41f2fda 100644 (file)
--- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
+++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
@@ -1683,6 +1683,7 @@ SdMmcCreateTrb (
   Trb->Event     = Event;\r
   Trb->Started   = FALSE;\r
   Trb->Timeout   = Packet->Timeout;\r
+  Trb->Retries   = SD_MMC_TRB_RETRIES;\r
   Trb->Private   = Private;\r
 \r
   if ((Packet->InTransferLength != 0) && (Packet->InDataBuffer != NULL)) {\r