SignedCapsulePkg IniParsingLib: ASSERT to ensure 'Value' is not NULL

Function GetStringFromDataFile() ensures its fourth (output) parameter
will not be NULL when the return status is EFI_SUCCESS.

This commit adds ASSERT as warnings for the case that will not happen.

Cc: Jiewen Yao <jiewen.yao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hao Wu <hao.a.wu@intel.com>
Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>

diff --git a/SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.c b/SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.c
index a8773c1a80e337f5d1fc656a9f6a6b1d100f8423..5c975f7ca4a1a3ec17c13fe9bba1a97b89fbb851 100644 (file)
--- a/SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.c
+++ b/SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.c
@@ -1257,6 +1257,7 @@ GetGuidFromDataFile (
   if (EFI_ERROR(Status)) {\r
     return EFI_NOT_FOUND;\r
   }\r
   if (EFI_ERROR(Status)) {\r
     return EFI_NOT_FOUND;\r
   }\r

+  ASSERT (Value != NULL);\r

   if (!IsValidGuid(Value, AsciiStrLen(Value))) {\r
     return EFI_NOT_FOUND;\r
   }\r
   if (!IsValidGuid(Value, AsciiStrLen(Value))) {\r
     return EFI_NOT_FOUND;\r
   }\r


@@ -1303,6 +1304,7 @@ GetDecimalUintnFromDataFile (
   if (EFI_ERROR(Status)) {\r
     return EFI_NOT_FOUND;\r
   }\r
   if (EFI_ERROR(Status)) {\r
     return EFI_NOT_FOUND;\r
   }\r

+  ASSERT (Value != NULL);\r

   if (!IsValidDecimalString(Value, AsciiStrLen(Value))) {\r
     return EFI_NOT_FOUND;\r
   }\r
   if (!IsValidDecimalString(Value, AsciiStrLen(Value))) {\r
     return EFI_NOT_FOUND;\r
   }\r


@@ -1346,6 +1348,7 @@ GetHexUintnFromDataFile (
   if (EFI_ERROR(Status)) {\r
     return EFI_NOT_FOUND;\r
   }\r
   if (EFI_ERROR(Status)) {\r
     return EFI_NOT_FOUND;\r
   }\r

+  ASSERT (Value != NULL);\r

   if (!IsValidHexString(Value, AsciiStrLen(Value))) {\r
     return EFI_NOT_FOUND;\r
   }\r
   if (!IsValidHexString(Value, AsciiStrLen(Value))) {\r
     return EFI_NOT_FOUND;\r
   }\r


@@ -1389,6 +1392,7 @@ GetHexUint64FromDataFile (
   if (EFI_ERROR(Status)) {\r
     return EFI_NOT_FOUND;\r
   }\r
   if (EFI_ERROR(Status)) {\r
     return EFI_NOT_FOUND;\r
   }\r

+  ASSERT (Value != NULL);\r

   if (!IsValidHexString(Value, AsciiStrLen(Value))) {\r
     return EFI_NOT_FOUND;\r
   }\r
   if (!IsValidHexString(Value, AsciiStrLen(Value))) {\r
     return EFI_NOT_FOUND;\r
   }\r