MdeModulePkg/SmiHandlerProfileInfo: Overflowed Array Index

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2272
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2287
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2288
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2289
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2290

Index should be off-by one than size of array, so when check
array, the max index should less than size of array.

Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Signed-off-by: Guomin Jiang <guomin.jiang@intel.com>
Reviewed-by: Jian J Wang <jian.j.wang@intel.com>

diff --git a/MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfileInfo.c b/MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfileInfo.c
index 0f7163160b4e9076d7fd0a64fb11a6c22d5ac2fe..4153074b7a80201397a36119e362305097edc859 100644 (file)
--- a/MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfileInfo.c
+++ b/MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfileInfo.c
@@ -382,7 +382,7 @@ SxTypeToString (
   IN EFI_SLEEP_TYPE  Type\r
   )\r
 {\r
-  if (Type >= 0 && Type <= ARRAY_SIZE(mSxTypeString)) {\r
+  if (Type >= 0 && Type < ARRAY_SIZE(mSxTypeString)) {\r
     return mSxTypeString[Type];\r
   } else {\r
     AsciiSPrint (mNameString, sizeof(mNameString), "0x%x", Type);\r
@@ -407,7 +407,7 @@ SxPhaseToString (
   IN EFI_SLEEP_PHASE Phase\r
   )\r
 {\r
-  if (Phase >= 0 && Phase <= ARRAY_SIZE(mSxPhaseString)) {\r
+  if (Phase >= 0 && Phase < ARRAY_SIZE(mSxPhaseString)) {\r
     return mSxPhaseString[Phase];\r
   } else {\r
     AsciiSPrint (mNameString, sizeof(mNameString), "0x%x", Phase);\r
@@ -432,7 +432,7 @@ PowerButtonPhaseToString (
   IN EFI_POWER_BUTTON_PHASE  Phase\r
   )\r
 {\r
-  if (Phase >= 0 && Phase <= ARRAY_SIZE(mPowerButtonPhaseString)) {\r
+  if (Phase >= 0 && Phase < ARRAY_SIZE(mPowerButtonPhaseString)) {\r
     return mPowerButtonPhaseString[Phase];\r
   } else {\r
     AsciiSPrint (mNameString, sizeof(mNameString), "0x%x", Phase);\r
@@ -457,7 +457,7 @@ StandbyButtonPhaseToString (
   IN EFI_STANDBY_BUTTON_PHASE  Phase\r
   )\r
 {\r
-  if (Phase >= 0 && Phase <= ARRAY_SIZE(mStandbyButtonPhaseString)) {\r
+  if (Phase >= 0 && Phase < ARRAY_SIZE(mStandbyButtonPhaseString)) {\r
     return mStandbyButtonPhaseString[Phase];\r
   } else {\r
     AsciiSPrint (mNameString, sizeof(mNameString), "0x%x", Phase);\r
@@ -483,7 +483,7 @@ IoTrapTypeToString (
   IN EFI_SMM_IO_TRAP_DISPATCH_TYPE  Type\r
   )\r
 {\r
-  if (Type >= 0 && Type <= ARRAY_SIZE(mIoTrapTypeString)) {\r
+  if (Type >= 0 && Type < ARRAY_SIZE(mIoTrapTypeString)) {\r
     return mIoTrapTypeString[Type];\r
   } else {\r
     AsciiSPrint (mNameString, sizeof(mNameString), "0x%x", Type);\r
@@ -508,7 +508,7 @@ UsbTypeToString (
   IN EFI_USB_SMI_TYPE          Type\r
   )\r
 {\r
-  if (Type >= 0 && Type <= ARRAY_SIZE(mUsbTypeString)) {\r
+  if (Type >= 0 && Type < ARRAY_SIZE(mUsbTypeString)) {\r
     return mUsbTypeString[Type];\r
   } else {\r
     AsciiSPrint (mNameString, sizeof(mNameString), "0x%x", Type);\r