FspInitPei function calling parameters not matching with the function definition.

IntelFspWrapperPkg, In the file FspInitPeiV1.c and FspInitPeiV2.c, there are function calling:
GetStackInfo (BootMode, FALSE, &StackBase, &StackSize);

But the function GetStackInfo() defined as EFI_STATUS EFIAPI GetStackInfo (
  IN  UINT32               BootMode,
  IN  BOOLEAN              FspInitDone,
  OUT UINT64               *StackSize,
  OUT EFI_PHYSICAL_ADDRESS *StackBase
  )

It should be GetStackInfo (BootMode, FALSE, &StackSize, &StackBase);

Contributed-under: TianoCore Contribution Agreement 1.0

Signed-off-by: "Yao, Jiewen" <Jiewen.yao@intel.com>
Reviewed-by: "Ma, Maurice" <maurice.ma@intel.com>
Reviewed-by: "Rangarajan, Ravi P" <ravi.p.rangarajan@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@17850 6f19259b-4bc3-4df7-8a09-765794883524

diff --git a/IntelFspWrapperPkg/FspInitPei/FspInitPeiV1.c b/IntelFspWrapperPkg/FspInitPei/FspInitPeiV1.c
index da7f8238d7590daa41e651745fdad45eb9d7efc7..b145b50c096a3d0661fbe91e9c5a3f8899ca26ef 100644 (file)
--- a/IntelFspWrapperPkg/FspInitPei/FspInitPeiV1.c
+++ b/IntelFspWrapperPkg/FspInitPei/FspInitPeiV1.c
@@ -47,7 +47,7 @@ ContinuationFunc (
   //\r
   BootMode = GetBootMode ();\r
 \r
-  GetStackInfo (BootMode, TRUE, &StackBase, &StackSize);\r
+  GetStackInfo (BootMode, TRUE, &StackSize, &StackBase);\r
   DEBUG ((DEBUG_INFO, "StackBase - 0x%x\n", StackBase));\r
   DEBUG ((DEBUG_INFO, "StackSize - 0x%x\n", StackSize));\r
   CallPeiCoreEntryPoint (\r
@@ -81,7 +81,7 @@ PeiFspInit (
   PeiServicesGetBootMode (&BootMode);\r
   DEBUG ((DEBUG_INFO, "BootMode - 0x%x\n", BootMode));\r
 \r
-  GetStackInfo (BootMode, FALSE, &StackBase, &StackSize);\r
+  GetStackInfo (BootMode, FALSE, &StackSize, &StackBase);\r
   DEBUG ((DEBUG_INFO, "StackBase - 0x%x\n", StackBase));\r
   DEBUG ((DEBUG_INFO, "StackSize - 0x%x\n", StackSize));\r
 \r

diff --git a/IntelFspWrapperPkg/FspInitPei/FspInitPeiV2.c b/IntelFspWrapperPkg/FspInitPei/FspInitPeiV2.c
index 35a994e9608cc1b52cae9a03103f997405b2821b..50b150aedd8808d4b23ee33ef8fb8aeb1685bfe6 100644 (file)
--- a/IntelFspWrapperPkg/FspInitPei/FspInitPeiV2.c
+++ b/IntelFspWrapperPkg/FspInitPei/FspInitPeiV2.c
@@ -148,7 +148,7 @@ PeiFspMemoryInit (
   PeiServicesGetBootMode (&BootMode);\r
   DEBUG ((DEBUG_INFO, "BootMode - 0x%x\n", BootMode));\r
 \r
-  GetStackInfo (BootMode, FALSE, &StackBase, &StackSize);\r
+  GetStackInfo (BootMode, FALSE, &StackSize, &StackBase);\r
   DEBUG ((DEBUG_INFO, "StackBase - 0x%x\n", StackBase));\r
   DEBUG ((DEBUG_INFO, "StackSize - 0x%x\n", StackSize));\r
 \r