]> git.proxmox.com Git - mirror_edk2.git/commitdiff
EmulatorPkg/EmuSimpleFileSystemDxe: Fix incorrect return values upon allocation failure
authorPaulo Alcantara <pcacjr@zytor.com>
Thu, 3 Jul 2014 20:05:22 +0000 (20:05 +0000)
committerjljusten <jljusten@6f19259b-4bc3-4df7-8a09-765794883524>
Thu, 3 Jul 2014 20:05:22 +0000 (20:05 +0000)
In EmuSimpleFileSystemOpenVolume() function - in case an allocation failed
with AllocatePool() - EFI_UNSUPPORTED was being returned instead of
EFI_OUT_OF_RESOURCES, which is incorrect.

Even worse, in EmuSimpleFileSystemDriverBindingStart(), an unitiliasied
variable (Status) will be returned in case of an allocation failure with
AllocateZeroPool().

This patch fixes both issues by correctly returning EFI_OUT_OF_RESOURCES.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Paulo Alcantara <pcacjr@zytor.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15615 6f19259b-4bc3-4df7-8a09-765794883524

EmulatorPkg/EmuSimpleFileSystemDxe/EmuSimpleFileSystem.c

index 543ea772bf21c46a93de99fc542b54e29340090a..4709f7a46f15a572cafb77eee865c1ba87ecdcf4 100644 (file)
@@ -501,6 +501,7 @@ EmuSimpleFileSystemOpenVolume (
 \r
   PrivateFile = AllocatePool (sizeof (EMU_EFI_FILE_PRIVATE));\r
   if (PrivateFile == NULL) {\r
+    Status = EFI_OUT_OF_RESOURCES;\r
     goto Done;\r
   }\r
 \r
@@ -722,6 +723,7 @@ EmuSimpleFileSystemDriverBindingStart (
 \r
   Private = AllocateZeroPool (sizeof (EMU_SIMPLE_FILE_SYSTEM_PRIVATE));\r
   if (Private == NULL) {\r
+    Status = EFI_OUT_OF_RESOURCES;\r
     goto Done;\r
   }\r
 \r