AppPkg/Applications/Python: Explicitly initialize variables before use to keep newer...

Explicitly initialize variables before any potential use.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Daryl McDaniel <daryl.mcdaniel@intel.com>
Reviewed-by: Jaben Carsey <Jaben.carsey@intel.com>
Reviewed-by: Erik Bjorge <erik.c.bjorge@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15819 6f19259b-4bc3-4df7-8a09-765794883524

diff --git a/AppPkg/Applications/Python/Python-2.7.2/Modules/socketmodule.c b/AppPkg/Applications/Python/Python-2.7.2/Modules/socketmodule.c
index 36682beb1c94a7d6590d5167c2f2c1d3a5e6a6fc..652f45f5b89db76412082cfcc84e8a9bdc88be58 100644 (file)
--- a/AppPkg/Applications/Python/Python-2.7.2/Modules/socketmodule.c
+++ b/AppPkg/Applications/Python/Python-2.7.2/Modules/socketmodule.c
@@ -1369,9 +1369,9 @@ getsockaddrarg(PySocketSockObject *s, PyObject *args,
         {\r
             struct sockaddr_hci *addr = (struct sockaddr_hci *)addr_ret;\r
 #if defined(__NetBSD__) || defined(__DragonFly__)\r
-                       char *straddr = PyBytes_AS_STRING(args);\r
+      char *straddr = PyBytes_AS_STRING(args);\r
 \r
-                       _BT_HCI_MEMB(addr, family) = AF_BLUETOOTH;\r
+      _BT_HCI_MEMB(addr, family) = AF_BLUETOOTH;\r
             if (straddr == NULL) {\r
                 PyErr_SetString(socket_error, "getsockaddrarg: "\r
                     "wrong format");\r
@@ -2824,7 +2824,7 @@ static PyObject *
 sock_sendto(PySocketSockObject *s, PyObject *args)\r
 {\r
     Py_buffer pbuf;\r
-    PyObject *addro;\r
+    PyObject *addro = NULL;\r
     char *buf;\r
     Py_ssize_t len;\r
     sock_addr_t addrbuf;\r

diff --git a/AppPkg/Applications/Python/Python-2.7.2/Objects/object.c b/AppPkg/Applications/Python/Python-2.7.2/Objects/object.c
index 2fd38437c6b0d7ef44cf95389d1128aa6b072ea1..2cdc043c77ada2da1efe028913db4d5475287099 100644 (file)
--- a/AppPkg/Applications/Python/Python-2.7.2/Objects/object.c
+++ b/AppPkg/Applications/Python/Python-2.7.2/Objects/object.c
@@ -470,11 +470,11 @@ PyObject_Str(PyObject *v)
 PyObject *\r
 PyObject_Unicode(PyObject *v)\r
 {\r
-    PyObject *res;\r
-    PyObject *func;\r
-    PyObject *str;\r
+    PyObject *res       = NULL;\r
+    PyObject *func      = NULL;\r
+    PyObject *str       = NULL;\r
     int unicode_method_found = 0;\r
-    static PyObject *unicodestr;\r
+    static PyObject *unicodestr   = NULL;\r
 \r
     if (v == NULL) {\r
         res = PyString_FromString("<NULL>");\r

diff --git a/AppPkg/Applications/Python/Python-2.7.2/Objects/stringobject.c b/AppPkg/Applications/Python/Python-2.7.2/Objects/stringobject.c
index 5abc9957e242c97fb055006bd8f020ab97babdda..3d3c6413df0afc4d92d50027048eb68525584341 100644 (file)
--- a/AppPkg/Applications/Python/Python-2.7.2/Objects/stringobject.c
+++ b/AppPkg/Applications/Python/Python-2.7.2/Objects/stringobject.c
@@ -4263,9 +4263,9 @@ PyString_Format(PyObject *format, PyObject *args)
             int c = '\0';\r
             int fill;\r
             int isnumok;\r
-            PyObject *v = NULL;\r
-            PyObject *temp = NULL;\r
-            char *pbuf;\r
+            PyObject *v     = NULL;\r
+            PyObject *temp  = NULL;\r
+            char *pbuf      = NULL;\r
             int sign;\r
             Py_ssize_t len;\r
             char formatbuf[FORMATBUFLEN];\r

diff --git a/AppPkg/Applications/Python/Python-2.7.2/Objects/unicodeobject.c b/AppPkg/Applications/Python/Python-2.7.2/Objects/unicodeobject.c
index 34b6a4fdaac0fc34be2f23595a59b83656f8ce9d..67abada2b29f505ea85ceec79075f1a0736361c4 100644 (file)
--- a/AppPkg/Applications/Python/Python-2.7.2/Objects/unicodeobject.c
+++ b/AppPkg/Applications/Python/Python-2.7.2/Objects/unicodeobject.c
@@ -1865,7 +1865,7 @@ char utf8_code_length[256] = {
        illegal prefix.  See RFC 3629 for details */\r
     1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, /* 00-0F */\r
     1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\r
-    1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, \r
+    1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\r
     1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\r
     1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\r
     1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\r
@@ -2221,7 +2221,7 @@ PyUnicode_DecodeUTF32Stateful(const char *s,
 #endif\r
     PyObject *errorHandler = NULL;\r
     PyObject *exc = NULL;\r
-    \r
+\r
     q = (unsigned char *)s;\r
     e = q + size;\r
 \r
@@ -8295,9 +8295,9 @@ PyObject *PyUnicode_Format(PyObject *format,
             Py_UNICODE c = '\0';\r
             Py_UNICODE fill;\r
             int isnumok;\r
-            PyObject *v = NULL;\r
-            PyObject *temp = NULL;\r
-            Py_UNICODE *pbuf;\r
+            PyObject *v       = NULL;\r
+            PyObject *temp    = NULL;\r
+            Py_UNICODE *pbuf  = NULL;\r
             Py_UNICODE sign;\r
             Py_ssize_t len;\r
             Py_UNICODE formatbuf[FORMATBUFLEN]; /* For format{int,char}() */\r

diff --git a/AppPkg/Applications/Python/Python-2.7.2/Objects/weakrefobject.c b/AppPkg/Applications/Python/Python-2.7.2/Objects/weakrefobject.c
index ed16b254ca191b2931ab6ea5618e240bd4ddcd6e..f852aea349dd6affda11b62257c8508574acd827 100644 (file)
--- a/AppPkg/Applications/Python/Python-2.7.2/Objects/weakrefobject.c
+++ b/AppPkg/Applications/Python/Python-2.7.2/Objects/weakrefobject.c
@@ -914,7 +914,9 @@ PyObject_ClearWeakRefs(PyObject *object)
         PyWeakReference *current = *list;\r
         Py_ssize_t count = _PyWeakref_GetWeakrefCount(current);\r
         int restore_error = PyErr_Occurred() ? 1 : 0;\r
-        PyObject *err_type, *err_value, *err_tb;\r
+        PyObject *err_type    = NULL,\r
+                 *err_value   = NULL,\r
+                 *err_tb      = NULL;\r
 \r
         if (restore_error)\r
             PyErr_Fetch(&err_type, &err_value, &err_tb);\r