BaseTools: AutoGen - refactor assemble_variable

make this function @staticmethod since self parameter is not used.
change valuelist to valuedict since it is a dictionary.

Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com>

diff --git a/BaseTools/Source/Python/AutoGen/GenVar.py b/BaseTools/Source/Python/AutoGen/GenVar.py
index 13bcf99b2627b410fa7274ad824a63b4cdee4baa..b8f40da9a39c87d6f5a458be26aed0e232463739 100644 (file)
--- a/BaseTools/Source/Python/AutoGen/GenVar.py
+++ b/BaseTools/Source/Python/AutoGen/GenVar.py
@@ -113,9 +113,10 @@ class VariableMgr(object):
             indexedvarinfo[key] =  [var_info(n.pcdindex,n.pcdname,n.defaultstoragename,n.skuname,n.var_name, n.var_guid, "0x00",n.var_attribute,newvaluestr  , newvaluestr , DataType.TAB_VOID)]\r
         self.VarInfo = [item[0] for item in indexedvarinfo.values()]\r
 \r
-    def assemble_variable(self, valuelist):\r
-        ordered_offset = sorted(valuelist.keys())\r
-        ordered_value = [valuelist[k] for k in ordered_offset]\r
+    @staticmethod\r
+    def assemble_variable(valuedict):\r
+        ordered_offset = sorted(valuedict.keys())\r
+        ordered_value = [valuedict[k] for k in ordered_offset]\r
         var_value = []\r
         num = 0\r
         for offset in ordered_offset:\r
@@ -126,6 +127,7 @@ class VariableMgr(object):
             var_value += ordered_value[num]\r
             num +=1\r
         return var_value\r
+\r
     def process_variable_data(self):\r
 \r
         var_data = collections.defaultdict(collections.OrderedDict)\r