]> git.proxmox.com Git - mirror_edk2.git/commitdiff
Vlv2TbltDevicePkg/PlatformInitPei: Remove the unused variables
authorGary Lin <glin@suse.com>
Fri, 29 Jul 2016 03:25:25 +0000 (11:25 +0800)
committerdavid wei <david.wei@intel.com>
Wed, 3 Aug 2016 03:02:15 +0000 (11:02 +0800)
Fix the following errors from gcc:

Vlv2TbltDevicePkg/PlatformInitPei/PchInitPeim.c: In function 'IchRcrbInit':
Vlv2TbltDevicePkg/PlatformInitPei/PchInitPeim.c:513:36: error: variable 'PlatformCpuInfo' set but not used [-Werror=unused-but-set-variable]
Vlv2TbltDevicePkg/PlatformInitPei/PchInitPeim.c:512:35: error: variable 'LpcRevisionID' set but not used [-Werror=unused-but-set-variable]

Vlv2TbltDevicePkg/PlatformInitPei/MemoryCallback.c: In function 'EndOfPeiPpiNotifyCallback':
Vlv2TbltDevicePkg/PlatformInitPei/MemoryCallback.c:64:31: error: variable 'MemoryTop' set but not used [-Werror=unused-but-set-variable]

v2:
  Also remove the variable, Hob, in PchInitPeim.c:IchRcrbInit() since
  no one really uses it.

Cc: David Wei <david.wei@intel.com>
Cc: "Lu, ShifeiX A" <shifeix.a.lu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Gary Lin <glin@suse.com>
Vlv2TbltDevicePkg/PlatformInitPei/MemoryCallback.c
Vlv2TbltDevicePkg/PlatformInitPei/PchInitPeim.c

index 31cc88a57606a9c676330255daa0babc0730de21..9d9c0e53b69fc89189608e4f68f67fed39344a12 100644 (file)
@@ -52,7 +52,6 @@ EndOfPeiPpiNotifyCallback (
   )\r
 {\r
   EFI_STATUS                  Status;\r
-  UINT64                      MemoryTop;\r
   UINT64                      LowUncableBase;\r
   EFI_PLATFORM_INFO_HOB       *PlatformInfo;\r
   UINT32                      HecBaseHigh;\r
@@ -100,7 +99,6 @@ EndOfPeiPpiNotifyCallback (
 \r
   LowUncableBase = PlatformInfo->MemData.MemMaxTolm;\r
   LowUncableBase &= (0x0FFF00000);\r
-  MemoryTop = (0x100000000);\r
 \r
   if (BootMode != BOOT_ON_S3_RESUME) {\r
     //\r
index 30f87c19067c3416424f1f497ba9f5351310d7e9..18ecda4a134c05b302ffb3a5e9b32c413d1238e6 100644 (file)
@@ -500,18 +500,8 @@ IchRcrbInit (
   IN SYSTEM_CONFIGURATION        *SystemConfiguration\r
   )\r
 {\r
-  UINT8                           LpcRevisionID;\r
-  EFI_PLATFORM_CPU_INFO           *PlatformCpuInfo;\r
-  EFI_PEI_HOB_POINTERS            Hob;\r
   EFI_BOOT_MODE                   BootMode;\r
 \r
-  //\r
-  // Get Platform Info HOB\r
-  //\r
-  Hob.Raw = GetFirstGuidHob (&gEfiPlatformCpuInfoGuid);\r
-  ASSERT (Hob.Raw != NULL);\r
-  PlatformCpuInfo = GET_GUID_HOB_DATA(Hob.Raw);\r
-\r
   (*PeiServices)->GetBootMode(PeiServices, &BootMode);\r
 \r
   //\r
@@ -530,8 +520,6 @@ IchRcrbInit (
   //\r
   // Initial RCBA according to the PeiRCBA table\r
   //\r
-  LpcRevisionID = PchLpcPciCfg8 (R_PCH_LPC_RID_CC);\r
-\r
   if ((BootMode == BOOT_ON_S3_RESUME)) {\r
     //\r
     // We are resuming from S3\r