SourceLevelDebugPkg DebugCommUsb3: Refine some formats/comments

Refine some formats/comments and remove some unused prototypes.

Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Hao Wu <hao.a.wu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
Reviewed-by: Hao Wu <hao.a.wu@intel.com>

diff --git a/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunicationLibUsb3Common.c b/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunicationLibUsb3Common.c
index 3b0f81cf88fdd1578b8b16bd9c47a6f5ff0969ae..37f49ad822f56fb6668bb17d4794db0481e9568d 100644 (file)
--- a/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunicationLibUsb3Common.c
+++ b/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunicationLibUsb3Common.c
@@ -85,15 +85,15 @@ XhcClearR32Bit(
   Write the data to the XHCI debug register.\r
 \r
   @param  Handle       Debug port handle.\r
-  @param  Offset       The offset of the runtime register.\r
+  @param  Offset       The offset of the debug register.\r
   @param  Data         The data to write.\r
 \r
 **/\r
 VOID\r
 XhcWriteDebugReg (\r
   IN USB3_DEBUG_PORT_HANDLE  *Handle,\r
-  IN UINT32                   Offset,\r
-  IN UINT32                   Data\r
+  IN UINT32                  Offset,\r
+  IN UINT32                  Data\r
   )\r
 {\r
   EFI_PHYSICAL_ADDRESS  DebugCapabilityBase;\r
@@ -116,7 +116,7 @@ XhcWriteDebugReg (
 UINT32\r
 XhcReadDebugReg (\r
   IN  USB3_DEBUG_PORT_HANDLE *Handle,\r
-  IN  UINT32                   Offset\r
+  IN  UINT32                 Offset\r
   )\r
 {\r
   UINT32                  Data;\r
@@ -129,16 +129,16 @@ XhcReadDebugReg (
 }\r
 \r
 /**\r
-  Set one bit of the runtime register while keeping other bits.\r
+  Set one bit of the debug register while keeping other bits.\r
 \r
   @param  Handle       Debug port handle.\r
-  @param  Offset       The offset of the runtime register.\r
+  @param  Offset       The offset of the debug register.\r
   @param  Bit          The bit mask of the register to set.\r
 \r
 **/\r
 VOID\r
 XhcSetDebugRegBit (\r
-  IN USB3_DEBUG_PORT_HANDLE *Handle,\r
+  IN USB3_DEBUG_PORT_HANDLE   *Handle,\r
   IN UINT32                   Offset,\r
   IN UINT32                   Bit\r
   )\r
@@ -216,7 +216,7 @@ UpdateXhcResource (
 \r
   @param  Handle             Debug port handle.\r
 \r
-  @retval RETURN_UNSUPPORTED The usb host controller does not supported usb debug port capability.\r
+  @retval RETURN_UNSUPPORTED The usb host controller does not support usb debug port capability.\r
   @retval RETURN_SUCCESS     Get bar and offset successfully.\r
 \r
 **/\r

diff --git a/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunicationLibUsb3Internal.h b/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunicationLibUsb3Internal.h
index 356485c5f6973fa0150406a7b56115d9ab8a19ab..9da49f96440133224ecf53c77a04e1d39d03b11c 100644 (file)
--- a/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunicationLibUsb3Internal.h
+++ b/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunicationLibUsb3Internal.h
@@ -1,7 +1,7 @@
 /** @file\r
   Debug Port Library implementation based on usb3 debug port.\r
 \r
-  Copyright (c) 2014 - 2015, Intel Corporation. All rights reserved.<BR>\r
+  Copyright (c) 2014 - 2018, Intel Corporation. All rights reserved.<BR>\r
   This program and the accompanying materials\r
   are licensed and made available under the terms and conditions of the BSD License\r
   which accompanies this distribution.  The full text of the license may be found at\r
@@ -540,7 +540,7 @@ typedef struct _USB3_DEBUG_PORT_INSTANCE {
 UINT32\r
 XhcReadDebugReg (\r
   IN  USB3_DEBUG_PORT_HANDLE    *Handle,\r
-  IN  UINT32                      Offset\r
+  IN  UINT32                    Offset\r
   );\r
 \r
 /**\r
@@ -554,8 +554,8 @@ XhcReadDebugReg (
 VOID\r
 XhcSetDebugRegBit (\r
   IN USB3_DEBUG_PORT_HANDLE  *Handle,\r
-  IN UINT32                   Offset,\r
-  IN UINT32                   Bit\r
+  IN UINT32                  Offset,\r
+  IN UINT32                  Bit\r
   );\r
   \r
 /**\r
@@ -573,43 +573,6 @@ XhcWriteDebugReg (
   IN UINT32                     Data\r
   );\r
 \r
-/**\r
-  Discover the USB3 debug device.\r
-  \r
-  @param  Handle                Debug port handle.\r
-  \r
-  @retval RETURN_SUCCESS        The serial device was initialized.\r
-  @retval RETURN_DEVICE_ERROR   The serial device could not be initialized.\r
-\r
-**/\r
-RETURN_STATUS\r
-DiscoverUsb3DebugPort(\r
-  USB3_DEBUG_PORT_HANDLE  *Handle\r
-  );\r
-  \r
-/**\r
-  Initialize the Serial Device hardware.\r
-  \r
-  @param  Handle            Debug port handle.\r
-\r
-  @retval RETURN_SUCCESS    The serial device was initialized successfully.\r
-  @retval !RETURN_SUCCESS   Error.\r
-\r
-**/\r
-RETURN_STATUS\r
-InitializeUsb3DebugPort (\r
-  USB3_DEBUG_PORT_HANDLE  *Handle\r
-  );\r
-\r
-/**\r
-  Return XHCI MMIO base address.\r
-\r
-**/\r
-EFI_PHYSICAL_ADDRESS\r
-GetXhciBaseAddress (\r
-  VOID\r
-  );\r
-\r
 /**\r
   Verifies if the bit positions specified by a mask are set in a register.\r
 \r
@@ -728,4 +691,4 @@ XhcDataTransfer (
   IN     UINTN                               Timeout\r
   );\r
 \r
-#endif //__SERIAL_PORT_LIB_USB__\r
+#endif //__USB3_DEBUG_PORT_LIB_INTERNAL__\r