follow up code review

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5894 6f19259b-4bc3-4df7-8a09-765794883524

diff --git a/MdePkg/Include/Library/PeiPiLib.h b/MdePkg/Include/Library/PeiPiLib.h
index c0c2eba873bece627057ee2cf6d74bdf6db5deff..c0e0a2a2047f30ebd59a67535bf2aeae3ad5fe2b 100644 (file)
--- a/MdePkg/Include/Library/PeiPiLib.h
+++ b/MdePkg/Include/Library/PeiPiLib.h
@@ -15,27 +15,27 @@
 #ifndef __PEI_PI_LIB_H__\r
 #define __PEI_PI_LIB_H__\r
 \r
-#include <Pi/PiFirmwareFile.h>\r
-\r
 /**\r
-    Install a EFI_PEI_FIRMWARE_VOLUME_INFO PPI to inform PEI core about the existence of a new Firmware Volume.\r
+  Install a EFI_PEI_FIRMWARE_VOLUME_INFO PPI to inform PEI core about the existence of a new Firmware Volume.\r
   \r
-    The function allocate the EFI_PEI_PPI_DESCRIPTOR structure and update the fields accordingly to parameter passed\r
-    in and install the PPI.\r
-    \r
-    @param  FvFormat             Unique identifier of the format of the memory-mapped firmware volume. If NULL is specified,\r
-                                         EFI_FIRMWARE_FILE_SYSTEM2_GUID is used as the Format GUID.\r
-    @param  FvInfo               Points to a buffer which allows the EFI_PEI_FIRMWARE_VOLUME_PPI to\r
-                                         process the volume. The format of this buffer is specific to the FvFormat. For\r
-                                         memory-mapped firmware volumes, this typically points to the first byte of the\r
-                                         firmware volume.\r
-    @param  FvInfoSize          Size of the data provided by FvInfo. For memory-mapped firmware volumes, this is\r
-                                         typically the size of the firmware volume.\r
-    @param  ParentFvName, ParentFileName      If the firmware volume originally came from a firmware file, then these point to the\r
-                                          parent firmware volume name and firmware volume file. If it did not originally come\r
-                                          from a firmware file, these should be NULL\r
+  The function allocate the EFI_PEI_PPI_DESCRIPTOR structure and update the fields accordingly to parameter passed\r
+  in and install the PPI.\r
   \r
- \r
+  @param  FvFormat             Unique identifier of the format of the memory-mapped firmware volume. \r
+                               If NULL is specified, EFI_FIRMWARE_FILE_SYSTEM2_GUID is used as the Format GUID.\r
+  @param  FvInfo               Points to a buffer which allows the EFI_PEI_FIRMWARE_VOLUME_PPI to\r
+                               process the volume. The format of this buffer is specific to the FvFormat. For\r
+                               memory-mapped firmware volumes, this typically points to the first byte of the\r
+                               firmware volume.\r
+  @param  FvInfoSize           Size of the data provided by FvInfo. For memory-mapped firmware volumes, this is\r
+                               typically the size of the firmware volume.\r
+  @param  ParentFvName         If the firmware volume originally came from a firmware file, then these point to the\r
+                               parent firmware volume name. If it did not originally come from a firmware file, \r
+                               these should be NULL.\r
+  @param  ParentFileName       If the firmware volume originally came from a firmware file, then these point to the\r
+                               firmware volume file. If it did not originally come from a firmware file, \r
+                               these should be NULL.\r
+   \r
 **/\r
 VOID\r
 EFIAPI\r

diff --git a/MdePkg/Include/Library/PeiServicesTablePointerLib.h b/MdePkg/Include/Library/PeiServicesTablePointerLib.h
index 973598870e91a7623c2199810c8540b6e30dad40..015d9723bee7653e14fb1e3f58b1dec6ff29c8ed 100644 (file)
--- a/MdePkg/Include/Library/PeiServicesTablePointerLib.h
+++ b/MdePkg/Include/Library/PeiServicesTablePointerLib.h
@@ -39,7 +39,7 @@ GetPeiServicesTablePointer (
 VOID\r
 EFIAPI\r
 SetPeiServicesTablePointer (\r
-  EFI_PEI_SERVICES ** PeiServicesTablePointer\r
+  IN EFI_PEI_SERVICES ** PeiServicesTablePointer\r
   );\r
 \r
 #endif\r

diff --git a/MdePkg/Library/PeiPiLib/PeiPiLib.c b/MdePkg/Library/PeiPiLib/PeiPiLib.c
index 4c9cea865cb60b2b38d7f927ab103c8ff145d1e8..876f5cab392f99c00e1512f313a54adb18fd6fcb 100644 (file)
--- a/MdePkg/Library/PeiPiLib/PeiPiLib.c
+++ b/MdePkg/Library/PeiPiLib/PeiPiLib.c
@@ -32,26 +32,26 @@ CONST EFI_PEI_PPI_DESCRIPTOR     mPpiListTemplate [] = {
 };\r
 \r
 /**\r
-    Install a EFI_PEI_FIRMWARE_VOLUME_INFO PPI to inform PEI core about the existence of a new Firmware Volume.\r
+  Install a EFI_PEI_FIRMWARE_VOLUME_INFO PPI to inform PEI core about the existence of a new Firmware Volume.\r
   \r
-    The function allocate the EFI_PEI_PPI_DESCRIPTOR structure and update the fields accordingly to parameter passed\r
-    in and install the PPI.\r
-    \r
-    @param  FvFormat             Unique identifier of the format of the memory-mapped firmware volume. If NULL is specified,\r
-                                         EFI_FIRMWARE_FILE_SYSTEM2_GUID is used as the Format GUID.\r
-    @param  FvInfo               Points to a buffer which allows the EFI_PEI_FIRMWARE_VOLUME_PPI to\r
-                                         process the volume. The format of this buffer is specific to the FvFormat. For\r
-                                         memory-mapped firmware volumes, this typically points to the first byte of the\r
-                                         firmware volume.\r
-    @param  FvInfoSize          Size of the data provided by FvInfo. For memory-mapped firmware volumes, this is\r
-                                         typically the size of the firmware volume.\r
-    @param  ParentFvName        If the firmware volume originally came from a firmware file, then these point to the\r
-                                          parent firmware volume name. If it did not originally come\r
-                                          from a firmware file, these should be NULL.\r
-    @param  ParentFileName      If the firmware volume originally came from a firmware file, then these point to the\r
-                                          firmware volume file. If it did not originally come\r
-                                          from a firmware file, these should be NULL.\r
+  The function allocate the EFI_PEI_PPI_DESCRIPTOR structure and update the fields accordingly to parameter passed\r
+  in and install the PPI.\r
   \r
+  @param  FvFormat             Unique identifier of the format of the memory-mapped firmware volume. \r
+                               If NULL is specified, EFI_FIRMWARE_FILE_SYSTEM2_GUID is used as the Format GUID.\r
+  @param  FvInfo               Points to a buffer which allows the EFI_PEI_FIRMWARE_VOLUME_PPI to\r
+                               process the volume. The format of this buffer is specific to the FvFormat. For\r
+                               memory-mapped firmware volumes, this typically points to the first byte of the\r
+                               firmware volume.\r
+  @param  FvInfoSize           Size of the data provided by FvInfo. For memory-mapped firmware volumes, this is\r
+                               typically the size of the firmware volume.\r
+  @param  ParentFvName         If the firmware volume originally came from a firmware file, then these point to the\r
+                               parent firmware volume name. If it did not originally come from a firmware file, \r
+                               these should be NULL.\r
+  @param  ParentFileName       If the firmware volume originally came from a firmware file, then these point to the\r
+                               firmware volume file. If it did not originally come from a firmware file, \r
+                               these should be NULL.\r
+   \r
 **/\r
 VOID\r
 EFIAPI\r

diff --git a/MdePkg/Library/PeiServicesTablePointerLib/PeiServicesTablePointer.c b/MdePkg/Library/PeiServicesTablePointerLib/PeiServicesTablePointer.c
index 38051a9173eb9b07094621cd5ae35bacc44a88ff..b601545b8caa7c2f65e88f87f801925954359926 100644 (file)
--- a/MdePkg/Library/PeiServicesTablePointerLib/PeiServicesTablePointer.c
+++ b/MdePkg/Library/PeiServicesTablePointerLib/PeiServicesTablePointer.c
@@ -29,7 +29,7 @@ STATIC EFI_PEI_SERVICES  **gPeiServices;
 VOID\r
 EFIAPI\r
 SetPeiServicesTablePointer (\r
-  EFI_PEI_SERVICES  **PeiServices\r
+  IN EFI_PEI_SERVICES  **PeiServices\r
   )\r
 {\r
   gPeiServices = PeiServices;\r

diff --git a/MdePkg/Library/PeiServicesTablePointerLibIdt/PeiServicesTablePointer.c b/MdePkg/Library/PeiServicesTablePointerLibIdt/PeiServicesTablePointer.c
index e38db636e89d139e699afea79b8494a46d9ecbac..ba2f9d6cad6aa9af7bb8f19e89f2e79909e6e305 100644 (file)
--- a/MdePkg/Library/PeiServicesTablePointerLibIdt/PeiServicesTablePointer.c
+++ b/MdePkg/Library/PeiServicesTablePointerLibIdt/PeiServicesTablePointer.c
@@ -65,7 +65,7 @@ GetPeiServicesTablePointer (
 VOID\r
 EFIAPI\r
 SetPeiServicesTablePointer (\r
-  EFI_PEI_SERVICES ** PeiServicesTablePointer\r
+  IN EFI_PEI_SERVICES ** PeiServicesTablePointer\r
   )\r
 {\r
   IA32_DESCRIPTOR   Idtr;\r

diff --git a/MdePkg/Library/PeiServicesTablePointerLibKr7/PeiServicesTablePointer.c b/MdePkg/Library/PeiServicesTablePointerLibKr7/PeiServicesTablePointer.c
index db858330378b1a1da4e77d063ce2921bbe136f8c..598a9c340d171851a73b38f7f7190244a7d97a04 100644 (file)
--- a/MdePkg/Library/PeiServicesTablePointerLibKr7/PeiServicesTablePointer.c
+++ b/MdePkg/Library/PeiServicesTablePointerLibKr7/PeiServicesTablePointer.c
@@ -71,7 +71,7 @@ PeiServicesTablePointerLibConstructor (
 VOID\r
 EFIAPI\r
 SetPeiServicesTablePointer (\r
-  EFI_PEI_SERVICES ** PeiServicesTablePointer\r
+  IN EFI_PEI_SERVICES ** PeiServicesTablePointer\r
   )\r
 {\r
   AsmWriteKr7 ((UINT64)(UINTN)PeiServicesTablePointer);\r