UefiCpuPkg PiSmmCpuDxeSmm: Remove redundant code to set IDT range to RO

AllocateCodePages() is used to allocate buffer for IDT range,
the code pages will be set to RO in SetMemMapAttributes(),
then the code to set IDT range to RO in PatchGdtIdtMap() is
redundant and could be removed.

Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>

diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c b/UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c
index 16664f304cde4b8fd88f3df3303bf3bdd6971b93..2a4a29899862a2d85a48e14576f99db396d8cfee 100644 (file)
--- a/UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c
+++ b/UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c
@@ -803,11 +803,10 @@ PatchGdtIdtMap (
 \r
   BaseAddress = gcSmiIdtr.Base;\r
   Size = ALIGN_VALUE(gcSmiIdtr.Limit + 1, SIZE_4KB);\r
 \r
   BaseAddress = gcSmiIdtr.Base;\r
   Size = ALIGN_VALUE(gcSmiIdtr.Limit + 1, SIZE_4KB);\r

-  SmmSetMemoryAttributes (\r
-    BaseAddress,\r
-    Size,\r
-    EFI_MEMORY_RO\r
-    );\r
+  //\r
+  // The range should have been set to RO\r
+  // if it is allocated with EfiRuntimeServicesCode.\r
+  //\r

   SmmSetMemoryAttributes (\r
     BaseAddress,\r
     Size,\r
   SmmSetMemoryAttributes (\r
     BaseAddress,\r
     Size,\r