]> git.proxmox.com Git - mirror_edk2.git/commitdiff
MdePkg: Fix OUT parameters marked as IN OUT
authorOleksiy Yakovlev <oleksiyy@ami.com>
Thu, 14 May 2020 20:51:41 +0000 (04:51 +0800)
committermergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Wed, 20 May 2020 14:49:13 +0000 (14:49 +0000)
Some OUT parameters in the specification were mistakenly marked as IN OUT.
"IN OUT" replaced with "OUT" in the following interfaces

EFI_BOOT_SERVICES.GetMemoryMap():MemoryMap
EFI_BOOT_SERVICES.LocateHandleBuffer():NoHandles
EFI_SIMPLE_POINTER_PROTOCOL.GetState():State
EFI_ABSOLUTE_POINTER_PROTOCOL.GetState():State
EFI_EDID_OVERRIDE_PROTOCOL.GetEdid():EdidSize and Edid
EFI_ATA_PASS_THRU_PROTOCOL.BuildDevicePath():DevicePath
EFI_NVM_EXPRESS_PASS_THRU_PROTOCOL.BuildDevicePath():DevicePath
EFI_SD_MMC_PASS_THRU_PROTOCOL.BuildDevicePath():DevicePath
EFI_EXT_SCSI_PASS_THRU_PROTOCOL.BuildDevicePath():DevicePath
EFI_FIRMWARE_MANAGEMENT_PROTOCOL.GetImage():Image
(UEFI 2.8 errata a, mantis 2035)

Signed-off-by: Oleksiy Yakovlev <oleksiyy@ami.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
MdePkg/Include/Protocol/AbsolutePointer.h
MdePkg/Include/Protocol/AtaPassThru.h
MdePkg/Include/Protocol/EdidOverride.h
MdePkg/Include/Protocol/FirmwareManagement.h
MdePkg/Include/Protocol/NvmExpressPassthru.h
MdePkg/Include/Protocol/ScsiPassThruExt.h
MdePkg/Include/Protocol/SdMmcPassThru.h
MdePkg/Include/Protocol/SimplePointer.h
MdePkg/Include/Uefi/UefiSpec.h

index 77d34ae5bd14a42962aec47e4ebe02d199582e1a..d59ac975dad7f7bc426bd94387933a89fa891fed 100644 (file)
@@ -169,7 +169,7 @@ typedef
 EFI_STATUS\r
 (EFIAPI *EFI_ABSOLUTE_POINTER_GET_STATE)(\r
   IN      EFI_ABSOLUTE_POINTER_PROTOCOL  *This,\r
-  IN OUT  EFI_ABSOLUTE_POINTER_STATE     *State\r
+  OUT  EFI_ABSOLUTE_POINTER_STATE        *State\r
 );\r
 \r
 \r
index ce6f57fd9a3539d15dac3f66478372786d95e06d..888dff2d73f099664504909c2533897b60eb1096 100644 (file)
@@ -315,7 +315,7 @@ EFI_STATUS
   @param[in]     PortMultiplierPort  The port multiplier port number of the ATA device for which a\r
                                      device path node is to be allocated and built. If there is no\r
                                      port multiplier, then specify 0xFFFF.\r
-  @param[in,out] DevicePath          A pointer to a single device path node that describes the ATA\r
+  @param[out]    DevicePath          A pointer to a single device path node that describes the ATA\r
                                      device specified by Port and PortMultiplierPort. This function\r
                                      is responsible for allocating the buffer DevicePath with the\r
                                      boot service AllocatePool(). It is the caller's responsibility\r
@@ -334,7 +334,7 @@ EFI_STATUS
   IN     EFI_ATA_PASS_THRU_PROTOCOL *This,\r
   IN     UINT16                     Port,\r
   IN     UINT16                     PortMultiplierPort,\r
-  IN OUT EFI_DEVICE_PATH_PROTOCOL   **DevicePath\r
+  OUT    EFI_DEVICE_PATH_PROTOCOL   **DevicePath\r
   );\r
 \r
 /**\r
index 9036f8bc8e9b67f9d56ad0c63b6d7c2cdca50570..709ee48c8493c1cf678a86cf7c12e75daeb0fc7b 100644 (file)
@@ -44,8 +44,8 @@ EFI_STATUS
   IN  EFI_EDID_OVERRIDE_PROTOCOL          *This,\r
   IN  EFI_HANDLE                          *ChildHandle,\r
   OUT UINT32                              *Attributes,\r
-  IN OUT UINTN                            *EdidSize,\r
-  IN OUT UINT8                            **Edid\r
+  OUT UINTN                               *EdidSize,\r
+  OUT UINT8                               **Edid\r
   );\r
 \r
 ///\r
index 297bb5ff0397c859eedbfca173dffc0ee4090df9..b50126164d0a22626fc8baf7a4f28e123f662a11 100644 (file)
@@ -345,7 +345,7 @@ EFI_STATUS
   @param[in]      This           A pointer to the EFI_FIRMWARE_MANAGEMENT_PROTOCOL instance.\r
   @param[in]      ImageIndex     A unique number identifying the firmware image(s) within the device.\r
                                  The number is between 1 and DescriptorCount.\r
-  @param[in, out] Image          Points to the buffer where the current image is copied to.\r
+  @param[out]     Image          Points to the buffer where the current image is copied to.\r
   @param[in, out] ImageSize      On entry, points to the size of the buffer pointed to by Image, in bytes.\r
                                  On return, points to the length of the image, in bytes.\r
 \r
@@ -364,7 +364,7 @@ EFI_STATUS
 (EFIAPI *EFI_FIRMWARE_MANAGEMENT_PROTOCOL_GET_IMAGE)(\r
   IN  EFI_FIRMWARE_MANAGEMENT_PROTOCOL  *This,\r
   IN  UINT8                             ImageIndex,\r
-  IN  OUT  VOID                         *Image,\r
+  OUT  VOID                             *Image,\r
   IN  OUT  UINTN                        *ImageSize\r
   );\r
 \r
index 7420924171efbe4a37cbe9fb7ecb474e84e99f11..870b9b5d37f498e66c07fa83643cd22cbf0614a5 100644 (file)
@@ -214,7 +214,7 @@ EFI_STATUS
   @param[in]     NamespaceId         The NVM Express namespace ID  for which a device path node is to be\r
                                      allocated and built. Caller must set the NamespaceId to zero if the\r
                                      device path node will contain a valid UUID.\r
-  @param[in,out] DevicePath          A pointer to a single device path node that describes the NVM Express\r
+  @param[out]    DevicePath          A pointer to a single device path node that describes the NVM Express\r
                                      namespace specified by NamespaceId. This function is responsible for\r
                                      allocating the buffer DevicePath with the boot service AllocatePool().\r
                                      It is the caller's responsibility to free DevicePath when the caller\r
@@ -231,7 +231,7 @@ EFI_STATUS
 (EFIAPI *EFI_NVM_EXPRESS_PASS_THRU_BUILD_DEVICE_PATH)(\r
   IN     EFI_NVM_EXPRESS_PASS_THRU_PROTOCOL          *This,\r
   IN     UINT32                                      NamespaceId,\r
-  IN OUT EFI_DEVICE_PATH_PROTOCOL                    **DevicePath\r
+  OUT    EFI_DEVICE_PATH_PROTOCOL                    **DevicePath\r
   );\r
 \r
 /**\r
index c83da267b4cbdc07953a30966a225c1fc7db9145..994fbba93d3a7f5691d028a36061ca11c8914d59 100644 (file)
@@ -259,7 +259,7 @@ EFI_STATUS
   IN EFI_EXT_SCSI_PASS_THRU_PROTOCOL               *This,\r
   IN UINT8                                         *Target,\r
   IN UINT64                                        Lun,\r
-  IN OUT EFI_DEVICE_PATH_PROTOCOL                  **DevicePath\r
+  OUT EFI_DEVICE_PATH_PROTOCOL                     **DevicePath\r
   );\r
 \r
 /**\r
index 3db6a3effd12aedc3b5bc864d1133519e371ca20..ac5470b1ac34a05b1a10a1a9f8de1d236aafdfcd 100644 (file)
@@ -164,7 +164,7 @@ EFI_STATUS
   @param[in]     This           A pointer to the EFI_SD_MMMC_PASS_THRU_PROTOCOL instance.\r
   @param[in]     Slot           Specifies the slot number of the SD card for which a device\r
                                 path node is to be allocated and built.\r
-  @param[in,out] DevicePath     A pointer to a single device path node that describes the SD\r
+  @param[out]    DevicePath     A pointer to a single device path node that describes the SD\r
                                 card specified by Slot. This function is responsible for\r
                                 allocating the buffer DevicePath with the boot service\r
                                 AllocatePool(). It is the caller's responsibility to free\r
@@ -182,7 +182,7 @@ EFI_STATUS
 (EFIAPI *EFI_SD_MMC_PASS_THRU_BUILD_DEVICE_PATH) (\r
   IN     EFI_SD_MMC_PASS_THRU_PROTOCOL       *This,\r
   IN     UINT8                               Slot,\r
-  IN OUT EFI_DEVICE_PATH_PROTOCOL            **DevicePath\r
+  OUT    EFI_DEVICE_PATH_PROTOCOL            **DevicePath\r
 );\r
 \r
 /**\r
index 2f5a940ff91c5c85e8802074f832414be7728e26..c6314145fb9eca5e6eb3a0c10b93ee20b8adcc17 100644 (file)
@@ -109,7 +109,7 @@ typedef
 EFI_STATUS\r
 (EFIAPI *EFI_SIMPLE_POINTER_GET_STATE)(\r
   IN EFI_SIMPLE_POINTER_PROTOCOL          *This,\r
-  IN OUT EFI_SIMPLE_POINTER_STATE         *State\r
+  OUT EFI_SIMPLE_POINTER_STATE            *State\r
   );\r
 \r
 ///\r
index 3547345bd6242f33afead8bae9159bd3a6ed0367..558e1bce2e41fa2f59b6dd45c4563958faf5f406 100644 (file)
@@ -211,7 +211,7 @@ EFI_STATUS
                                          On output, it is the size of the buffer returned by the firmware if\r
                                          the buffer was large enough, or the size of the buffer needed to contain\r
                                          the map if the buffer was too small.\r
-  @param[in, out]  MemoryMap             A pointer to the buffer in which firmware places the current memory\r
+  @param[out]      MemoryMap             A pointer to the buffer in which firmware places the current memory\r
                                          map.\r
   @param[out]      MapKey                A pointer to the location in which firmware returns the key for the\r
                                          current memory map.\r
@@ -232,7 +232,7 @@ typedef
 EFI_STATUS\r
 (EFIAPI *EFI_GET_MEMORY_MAP)(\r
   IN OUT UINTN                       *MemoryMapSize,\r
-  IN OUT EFI_MEMORY_DESCRIPTOR       *MemoryMap,\r
+  OUT    EFI_MEMORY_DESCRIPTOR       *MemoryMap,\r
   OUT    UINTN                       *MapKey,\r
   OUT    UINTN                       *DescriptorSize,\r
   OUT    UINT32                      *DescriptorVersion\r
@@ -1556,7 +1556,7 @@ EFI_STATUS
   @param[in]       Protocol     Provides the protocol to search by.\r
                                 This parameter is only valid for a SearchType of ByProtocol.\r
   @param[in]       SearchKey    Supplies the search key depending on the SearchType.\r
-  @param[in, out]  NoHandles    The number of handles returned in Buffer.\r
+  @param[out]      NoHandles    The number of handles returned in Buffer.\r
   @param[out]      Buffer       A pointer to the buffer to return the requested array of handles that\r
                                 support Protocol.\r
 \r
@@ -1574,7 +1574,7 @@ EFI_STATUS
   IN     EFI_LOCATE_SEARCH_TYPE       SearchType,\r
   IN     EFI_GUID                     *Protocol,      OPTIONAL\r
   IN     VOID                         *SearchKey,     OPTIONAL\r
-  IN OUT UINTN                        *NoHandles,\r
+  OUT    UINTN                        *NoHandles,\r
   OUT    EFI_HANDLE                   **Buffer\r
   );\r
 \r