From: Star Zeng <star.zeng@intel.com>
Date: Wed, 1 Aug 2018 08:24:53 +0000 (+0800)
Subject: FmpDevicePkg FmpDxe: Fix XCODE build failure
X-Git-Tag: edk2-stable201903~1272
X-Git-Url: https://git.proxmox.com/?p=mirror_edk2.git;a=commitdiff_plain;h=0334068343d51ddefccb75a62de21d98d65d69e2;ds=sidebyside

FmpDevicePkg FmpDxe: Fix XCODE build failure

FmpDxe.c:517:18: error: equality comparison with extraneous
parentheses [-Werror,-Wparentheses-equality]

NOTE: This patch is based on thread
https://lists.01.org/pipermail/edk2-devel/2018-July/027810.html.

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
---

diff --git a/FmpDevicePkg/FmpDxe/FmpDxe.c b/FmpDevicePkg/FmpDxe/FmpDxe.c
index 0f3396c2ef..eb3a9b0e32 100644
--- a/FmpDevicePkg/FmpDxe/FmpDxe.c
+++ b/FmpDevicePkg/FmpDxe/FmpDxe.c
@@ -514,7 +514,7 @@ GetTheImage (
     goto cleanup;
   }
 
-  if ((ImageSize == NULL)) {
+  if (ImageSize == NULL) {
     DEBUG ((DEBUG_ERROR, "FmpDxe: GetImage() - ImageSize Pointer Parameter is NULL.\n"));
     Status = EFI_INVALID_PARAMETER;
     goto cleanup;