From: Star Zeng Date: Fri, 7 Aug 2015 23:53:53 +0000 (+0000) Subject: MdeModulePkg DxeIpl: Fix IA32 build failure with GCC 5.1.1 X-Git-Tag: edk2-stable201903~9095 X-Git-Url: https://git.proxmox.com/?p=mirror_edk2.git;a=commitdiff_plain;h=09e4a8fd95de49929b726d0b4966c9ead3491789 MdeModulePkg DxeIpl: Fix IA32 build failure with GCC 5.1.1 Got the build failure feedback below, this patch is to fix that. This broke the IA32 Ovmf build for me, with GCC 5.1.1 (Fedora 22): /home/dwmw2/git/edk2/MdeModulePkg/Core/DxeIplPeim/Ia32/DxeLoadFunc.c:377:7: error: ‘PageTables’ may be used uninitialized in this function [-Werror=maybe-uninitialized] AsmWriteCr3 (PageTables); ^ /home/dwmw2/git/edk2/MdeModulePkg/Core/DxeIplPeim/Ia32/DxeLoadFunc.c:224:9: note: ‘PageTables’ was declared here UINTN PageTables; ^ cc1: all warnings being treated as errors Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng Reviewed-by: Qiu Shumin git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18190 6f19259b-4bc3-4df7-8a09-765794883524 --- diff --git a/MdeModulePkg/Core/DxeIplPeim/Ia32/DxeLoadFunc.c b/MdeModulePkg/Core/DxeIplPeim/Ia32/DxeLoadFunc.c index c1ff4b7e64..8ce72cb316 100644 --- a/MdeModulePkg/Core/DxeIplPeim/Ia32/DxeLoadFunc.c +++ b/MdeModulePkg/Core/DxeIplPeim/Ia32/DxeLoadFunc.c @@ -361,6 +361,7 @@ HandOffToDxeCore ( TopOfStack = BaseOfStack + EFI_SIZE_TO_PAGES (STACK_SIZE) * EFI_PAGE_SIZE - CPU_STACK_ALIGNMENT; TopOfStack = (EFI_PHYSICAL_ADDRESS) (UINTN) ALIGN_POINTER (TopOfStack, CPU_STACK_ALIGNMENT); + PageTables = 0; BuildPageTablesIa32Pae = (BOOLEAN) (PcdGetBool (PcdSetNxForStack) && IsIa32PaeSupport () && IsExecuteDisableBitAvailable ()); if (BuildPageTablesIa32Pae) { PageTables = Create4GPageTablesIa32Pae (BaseOfStack, STACK_SIZE);