From: Fu Siyuan <siyuan.fu@intel.com>
Date: Wed, 15 Nov 2017 03:11:20 +0000 (+0800)
Subject: MdeModulePkg/SNP: remove redundant DEBUG print in SNP Transmit.c
X-Git-Tag: edk2-stable201903~3092
X-Git-Url: https://git.proxmox.com/?p=mirror_edk2.git;a=commitdiff_plain;h=0d07a8addb78076a1417149786cb430396a59add

MdeModulePkg/SNP: remove redundant DEBUG print in SNP Transmit.c

This patch is to remove some redundant DEBUG output in SNP transmit function.
In case of return EFI_NOT_READY in PxeTransmit, the SNP driver is indicate
the caller that the transmit queue is full, it's a very common situation druing
transmit, not a critical error. So the patch move the DEBUG lever to EFI_D_NET.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Fu Siyuan <siyuan.fu@intel.com>
Reviewed-by: Wu Jiaxin <jiaxin.wu@intel.com>
Reviewed-by: Ye Ting <ting.ye@intel.com>
---

diff --git a/MdeModulePkg/Universal/Network/SnpDxe/Transmit.c b/MdeModulePkg/Universal/Network/SnpDxe/Transmit.c
index 73461bce42..2c7083eb1b 100644
--- a/MdeModulePkg/Universal/Network/SnpDxe/Transmit.c
+++ b/MdeModulePkg/Universal/Network/SnpDxe/Transmit.c
@@ -1,7 +1,7 @@
 /** @file
     Implementation of transmitting a packet.
  
-Copyright (c) 2004 - 2016, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 2004 - 2017, Intel Corporation. All rights reserved.<BR>
 This program and the accompanying materials are licensed 
 and made available under the terms and conditions of the BSD License which 
 accompanies this distribution. The full text of the license may be found at 
@@ -186,7 +186,6 @@ PxeTransmit (
   (*Snp->IssueUndi32Command) ((UINT64) (UINTN) &Snp->Cdb);
 
   DEBUG ((EFI_D_NET, "\nexit Snp->undi.transmit()  "));
-  DEBUG ((EFI_D_NET, "\nSnp->Cdb.StatCode == %r", Snp->Cdb.StatCode));
 
   //
   // we will unmap the buffers in get_status call, not here
@@ -199,19 +198,24 @@ PxeTransmit (
   case PXE_STATCODE_QUEUE_FULL:
   case PXE_STATCODE_BUSY:
     Status = EFI_NOT_READY;
+    DEBUG (
+      (EFI_D_NET,
+      "\nSnp->undi.transmit()  %xh:%xh\n",
+      Snp->Cdb.StatFlags,
+      Snp->Cdb.StatCode)
+      );
     break;
 
   default:
+    DEBUG (
+      (EFI_D_ERROR,
+      "\nSnp->undi.transmit()  %xh:%xh\n",
+      Snp->Cdb.StatFlags,
+      Snp->Cdb.StatCode)
+      );
     Status = EFI_DEVICE_ERROR;
   }
 
-  DEBUG (
-    (EFI_D_ERROR,
-    "\nSnp->undi.transmit()  %xh:%xh\n",
-    Snp->Cdb.StatFlags,
-    Snp->Cdb.StatCode)
-    );
-
   return Status;
 }