From: Laszlo Ersek Date: Wed, 18 Jul 2018 18:25:25 +0000 (+0200) Subject: ShellPkg/UefiShellLib: drop DeviceHandle param of ShellOpenFileByDevicePath() X-Git-Tag: edk2-stable201903~1205 X-Git-Url: https://git.proxmox.com/?p=mirror_edk2.git;a=commitdiff_plain;h=15d8fe1fee188cd7a9ce1b0e32cbe34cc93f1097;hp=15d8fe1fee188cd7a9ce1b0e32cbe34cc93f1097 ShellPkg/UefiShellLib: drop DeviceHandle param of ShellOpenFileByDevicePath() The ShellOpenFileByDevicePath() API promises to set the DeviceHandle output parameter to the handle of the filesystem identified by the FilePath input parameter. However, this doesn't actually happen when the UEFI Shell 2.0 method is used (which is basically "always" nowadays). Accordingly, the only caller of ShellOpenFileByDevicePath(), namely ShellOpenFileByName(), defines a (dummy) local DeviceHandle variable just so it can call ShellOpenFileByDevicePath(). Remove the useless output parameter. Cc: Jaben Carsey Cc: Ruiyu Ni Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1008 Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Laszlo Ersek Reviewed-by: Jaben Carsey Reviewed-by: Ruiyu Ni ---