From: jcarsey <jcarsey@6f19259b-4bc3-4df7-8a09-765794883524>
Date: Thu, 17 Nov 2011 21:38:20 +0000 (+0000)
Subject: ShellPkg: Update the ‘for’ command to check number length correctly with trailing... 
X-Git-Tag: edk2-stable201903~13880
X-Git-Url: https://git.proxmox.com/?p=mirror_edk2.git;a=commitdiff_plain;h=2d3759d8b5f48c487a9ea749ae2e453a58c36f47;ds=sidebyside

ShellPkg: Update the ‘for’ command to check number length correctly with trailing spaces.

This fix corrects the logic that checks number length such that is functions correctly without a trailing space.

Signed-off-by: jcarsey
Reviewed-by: geekboy15a



git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12736 6f19259b-4bc3-4df7-8a09-765794883524
---

diff --git a/ShellPkg/Library/UefiShellLevel1CommandsLib/For.c b/ShellPkg/Library/UefiShellLevel1CommandsLib/For.c
index 121ac50918..7d91d2348f 100644
--- a/ShellPkg/Library/UefiShellLevel1CommandsLib/For.c
+++ b/ShellPkg/Library/UefiShellLevel1CommandsLib/For.c
@@ -42,7 +42,7 @@ ShellIsValidForNumber (
   }
 
   if (StrLen(Number) >= 7) {
-    if (StrStr(Number, L" ") != NULL && (StrStr(Number, L" ") - Number) >= 7) {
+    if ((StrStr(Number, L" ") == NULL) || (((StrStr(Number, L" ") != NULL) && (StrStr(Number, L" ") - Number) >= 7))) {
       return (FALSE);
     }
   }