From: mdkinney Date: Fri, 22 May 2009 23:31:56 +0000 (+0000) Subject: Fix linked list loops X-Git-Tag: edk2-stable201903~17895 X-Git-Url: https://git.proxmox.com/?p=mirror_edk2.git;a=commitdiff_plain;h=323f53ff7b98f23e91b6ebb97c82b7e9ff4fa819 Fix linked list loops git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8377 6f19259b-4bc3-4df7-8a09-765794883524 --- diff --git a/ShellPkg/Library/BaseShellLib/BaseShellLib.c b/ShellPkg/Library/BaseShellLib/BaseShellLib.c index a43966083f..acc6dffb82 100644 --- a/ShellPkg/Library/BaseShellLib/BaseShellLib.c +++ b/ShellPkg/Library/BaseShellLib/BaseShellLib.c @@ -1839,7 +1839,7 @@ ShellCommandLineGetFlag ( // // enumerate through the list of parametrs // - for (Node = GetFirstNode(CheckPackage) ; Node != CheckPackage ; Node = GetNextNode(CheckPackage, Node) ) { + for (Node = GetFirstNode(CheckPackage) ; !IsNull (CheckPackage, Node) ; Node = GetNextNode(CheckPackage, Node) ) { // // If the Name matches, return TRUE (and there may be NULL name) // @@ -1883,7 +1883,7 @@ ShellCommandLineGetValue ( // // enumerate through the list of parametrs // - for (Node = GetFirstNode(CheckPackage) ; Node != NULL ; Node = GetNextNode(CheckPackage, Node) ) { + for (Node = GetFirstNode(CheckPackage) ; !IsNull (CheckPackage, Node) ; Node = GetNextNode(CheckPackage, Node) ) { // // If the Name matches, return the value (name can be NULL) // @@ -1927,7 +1927,7 @@ ShellCommandLineGetRawValue ( // // enumerate through the list of parametrs // - for (Node = GetFirstNode(CheckPackage) ; Node != NULL ; Node = GetNextNode(CheckPackage, Node) ) { + for (Node = GetFirstNode(CheckPackage) ; !IsNull (CheckPackage, Node) ; Node = GetNextNode(CheckPackage, Node) ) { // // If the position matches, return the value //