From: Hao Wu Date: Fri, 4 Jan 2019 02:35:04 +0000 (+0800) Subject: MdeModulePkg/SdMmcPciHcDxe: Fix VS2015 IA32 NOOPT build failure X-Git-Tag: edk2-stable201903~414 X-Git-Url: https://git.proxmox.com/?p=mirror_edk2.git;a=commitdiff_plain;h=46f4c9677c615d862649459392f8f55b3e6567c2 MdeModulePkg/SdMmcPciHcDxe: Fix VS2015 IA32 NOOPT build failure REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1425 This commit will resolve the VS2015 IA32 NOOPT build failure within SdMmcPciHcDxe. More specifically, this commit will use BaseLib API RShiftU64() to perform right-shift operations for UINT64 type operators. Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Hao Wu Reviewed-by: Bi Dandan Reviewed-by: Jian J Wang --- diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c index 6086720fa1..5aec8c6992 100644 --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c @@ -1505,7 +1505,7 @@ BuildAdmaDescTable ( Trb->Adma32Desc[Index].Valid = 1; Trb->Adma32Desc[Index].Act = 2; if (DataLength26) { - Trb->Adma32Desc[Index].UpperLength = (UINT16)(Remaining >> 16); + Trb->Adma32Desc[Index].UpperLength = (UINT16)RShiftU64 (Remaining, 16); } Trb->Adma32Desc[Index].LowerLength = (UINT16)(Remaining & MAX_UINT16); Trb->Adma32Desc[Index].Address = (UINT32)Address; @@ -1524,11 +1524,11 @@ BuildAdmaDescTable ( Trb->Adma64Desc[Index].Valid = 1; Trb->Adma64Desc[Index].Act = 2; if (DataLength26) { - Trb->Adma64Desc[Index].UpperLength = (UINT16)(Remaining >> 16); + Trb->Adma64Desc[Index].UpperLength = (UINT16)RShiftU64 (Remaining, 16); } Trb->Adma64Desc[Index].LowerLength = (UINT16)(Remaining & MAX_UINT16); Trb->Adma64Desc[Index].LowerAddress = (UINT32)Address; - Trb->Adma64Desc[Index].UpperAddress = (UINT32)(Address >> 32); + Trb->Adma64Desc[Index].UpperAddress = (UINT32)RShiftU64 (Address, 32); break; } else { Trb->Adma64Desc[Index].Valid = 1; @@ -1538,7 +1538,7 @@ BuildAdmaDescTable ( } Trb->Adma64Desc[Index].LowerLength = 0; Trb->Adma64Desc[Index].LowerAddress = (UINT32)Address; - Trb->Adma64Desc[Index].UpperAddress = (UINT32)(Address >> 32); + Trb->Adma64Desc[Index].UpperAddress = (UINT32)RShiftU64 (Address, 32); } }