From: li-elvin Date: Wed, 26 Jan 2011 09:08:45 +0000 (+0000) Subject: Updated IntelFrameworkPkg\Include\Guid\DataHubRecords.h same with ECP definition X-Git-Tag: edk2-stable201903~15200 X-Git-Url: https://git.proxmox.com/?p=mirror_edk2.git;a=commitdiff_plain;h=4eb56285257b1a8609cef89c4f8f4887b7d9bef2 Updated IntelFrameworkPkg\Include\Guid\DataHubRecords.h same with ECP definition git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11275 6f19259b-4bc3-4df7-8a09-765794883524 --- diff --git a/IntelFrameworkPkg/FrameworkSpecConformance.txt b/IntelFrameworkPkg/FrameworkSpecConformance.txt index ae4e38b2c6..5a52bf5190 100644 --- a/IntelFrameworkPkg/FrameworkSpecConformance.txt +++ b/IntelFrameworkPkg/FrameworkSpecConformance.txt @@ -864,6 +864,19 @@ code logic. Therefore developer doesn't need to allocate memory dynamically to construct variable length data record. Keeping this inconsistency for backward compatibility. + 21. Guid/DataHubRecords.h + typedef struct { + EFI_MISC_COOLING_DEVICE_TYPE CoolingDeviceType; + EFI_INTER_LINK_DATA CoolingDeviceTemperatureLink; + UINT8 CoolingDeviceUnitGroup; + UINT16 CoolingDeviceNominalSpeed; + UINT32 CoolingDeviceOemDefined; + } EFI_MISC_COOLING_DEVICE_TEMP_LINK_DATA; + + The "CoolingDeviceUnitGroup" field and "CoolingDeviceNominalSpeed" field are *NOT* consistent with + MiscSubclass specification 0.9. These fields are aligned with SMBIOS 2.6 specification. And user can easily + assign any value to CoolingDeviceNominalSpeed. + ## # Mismatch with Intel Platform Innovation Framework for Status Codes Specification (Version 0.92) ## diff --git a/IntelFrameworkPkg/Include/Guid/DataHubRecords.h b/IntelFrameworkPkg/Include/Guid/DataHubRecords.h index eda88b50e3..9e3aa720f7 100644 --- a/IntelFrameworkPkg/Include/Guid/DataHubRecords.h +++ b/IntelFrameworkPkg/Include/Guid/DataHubRecords.h @@ -5,7 +5,7 @@ Cache subclass specification 0.9, DataHub SubClass specification 0.9, Memory SubClass Spec 0.9, Processor Subclass specification 0.9, and Misc SubClass specification 0.9. -Copyright (c) 2007 - 2010, Intel Corporation. All rights reserved.
+Copyright (c) 2007 - 2011, Intel Corporation. All rights reserved.
This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License that accompanies this distribution. The full text of the license may be found at @@ -2458,8 +2458,8 @@ typedef struct { typedef struct { EFI_MISC_COOLING_DEVICE_TYPE CoolingDeviceType; EFI_INTER_LINK_DATA CoolingDeviceTemperatureLink; - UINT16 CoolingDeviceUnitGroup; - EFI_EXP_BASE10_DATA CoolingDeviceNominalSpeed; + UINT8 CoolingDeviceUnitGroup; + UINT16 CoolingDeviceNominalSpeed; UINT32 CoolingDeviceOemDefined; } EFI_MISC_COOLING_DEVICE_TEMP_LINK_DATA;