From: Jiaxin Wu <jiaxin.wu@intel.com>
Date: Fri, 25 Dec 2015 08:10:37 +0000 (+0000)
Subject: NetworkPkg: Fix suspicious dereference of pointer before NULL check
X-Git-Tag: edk2-stable201903~8124
X-Git-Url: https://git.proxmox.com/?p=mirror_edk2.git;a=commitdiff_plain;h=5346adbb18004b27a1ca428f40efa815c31f617e

NetworkPkg: Fix suspicious dereference of pointer before NULL check

This patch is used to fix suspicious dereference of pointer before
NULL check in IScsiDxe driver.

Cc: Ye Ting <ting.ye@intel.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jiaxin Wu <jiaxin.wu@intel.com>
Reviewed-by: Ye Ting <ting.ye@intel.com>

git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@19552 6f19259b-4bc3-4df7-8a09-765794883524
---

diff --git a/NetworkPkg/IScsiDxe/IScsiDriver.c b/NetworkPkg/IScsiDxe/IScsiDriver.c
index a7031dfc4e..51ce16911b 100644
--- a/NetworkPkg/IScsiDxe/IScsiDriver.c
+++ b/NetworkPkg/IScsiDxe/IScsiDriver.c
@@ -105,7 +105,8 @@ IScsiCheckAip (
   //
   // Check any AIP instances exist in system.
   //
-  AipHandleCount = 0;
+  AipHandleCount  = 0;
+  AipHandleBuffer = NULL;
   Status = gBS->LocateHandleBuffer (
                   ByProtocol,
                   &gEfiAdapterInformationProtocolGuid,
@@ -117,6 +118,8 @@ IScsiCheckAip (
     return EFI_NOT_FOUND;
   }
 
+  ASSERT (AipHandleBuffer != NULL);
+
   InfoBlock = NULL;
 
   for (AipIndex = 0; AipIndex < AipHandleCount; AipIndex++) {