From: Laszlo Ersek <lersek@redhat.com>
Date: Fri, 18 Mar 2016 18:21:02 +0000 (+0100)
Subject: EdkCompatibilityPkg: UefiEfiIfrSupportLib: remove set but not used variables
X-Git-Tag: edk2-stable201903~7530
X-Git-Url: https://git.proxmox.com/?p=mirror_edk2.git;a=commitdiff_plain;h=5ccd43c817af5e77ce5b287d84959a033fdef533

EdkCompatibilityPkg: UefiEfiIfrSupportLib: remove set but not used variables

Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
Reviewed-by: Jeff Fan <jeff.fan@intel.com>
---

diff --git a/EdkCompatibilityPkg/Foundation/Library/Dxe/UefiEfiIfrSupportLib/UefiIfrCommon.c b/EdkCompatibilityPkg/Foundation/Library/Dxe/UefiEfiIfrSupportLib/UefiIfrCommon.c
index 3f5243387d..341930ae9a 100644
--- a/EdkCompatibilityPkg/Foundation/Library/Dxe/UefiEfiIfrSupportLib/UefiIfrCommon.c
+++ b/EdkCompatibilityPkg/Foundation/Library/Dxe/UefiEfiIfrSupportLib/UefiIfrCommon.c
@@ -522,7 +522,6 @@ Returns:
   EFI_HII_DATABASE_PROTOCOL    *HiiDatabase;
   EFI_HII_PACKAGE_LIST_HEADER  *HiiPackageList;
   UINT8                        *Package;
-  UINT8                        *FormSet;
   UINT8                        *OpCodeData;
   UINT32                       Offset;
   UINT32                       Offset2;
@@ -572,7 +571,6 @@ Returns:
   //
   Offset = sizeof (EFI_HII_PACKAGE_LIST_HEADER);
   Offset2 = 0;
-  FormSet = NULL;
   EfiCopyMem (&PackageListLength, &HiiPackageList->PackageLength, sizeof (UINT32));
 
   while (Offset < PackageListLength) {
@@ -660,7 +658,6 @@ Returns:
   EFI_HII_DATABASE_PROTOCOL    *HiiDatabase;
   EFI_HII_PACKAGE_LIST_HEADER  *HiiPackageList;
   UINT8                        *Package;
-  UINT8                        *FormSet;
   UINT8                        *OpCodeData;
   UINT32                       Offset;
   UINT32                       Offset2;
@@ -709,7 +706,6 @@ Returns:
   //
   Offset = sizeof (EFI_HII_PACKAGE_LIST_HEADER);
   Offset2 = 0;
-  FormSet = NULL;
   EfiCopyMem (&PackageListLength, &HiiPackageList->PackageLength, sizeof (UINT32));
 
   while (Offset < PackageListLength) {
diff --git a/EdkCompatibilityPkg/Foundation/Library/Dxe/UefiEfiIfrSupportLib/UefiIfrForm.c b/EdkCompatibilityPkg/Foundation/Library/Dxe/UefiEfiIfrSupportLib/UefiIfrForm.c
index 1452ef0035..864a850d4a 100644
--- a/EdkCompatibilityPkg/Foundation/Library/Dxe/UefiEfiIfrSupportLib/UefiIfrForm.c
+++ b/EdkCompatibilityPkg/Foundation/Library/Dxe/UefiEfiIfrSupportLib/UefiIfrForm.c
@@ -452,9 +452,7 @@ Returns:
   UINTN                         Index;
   UINTN                         Count;
   UINTN                         Start;
-  UINTN                         End;
   UINTN                         Top;
-  UINTN                         Bottom;
   CHAR16                        *StringPtr;
   UINTN                         LeftColumn;
   UINTN                         RightColumn;
@@ -529,10 +527,8 @@ Returns:
   // each end plus a border.
   //
   Start     = (DimensionsWidth - LargestString - 2) / 2 + LeftColumn + 1;
-  End       = Start + LargestString + 1;
 
   Top       = ((DimensionsHeight - NumberOfLines - 2) / 2) + TopRow - 1;
-  Bottom    = Top + NumberOfLines + 2;
 
   //
   // Disable cursor
diff --git a/EdkCompatibilityPkg/Foundation/Library/Dxe/UefiEfiIfrSupportLib/UefiIfrOpCodeCreation.c b/EdkCompatibilityPkg/Foundation/Library/Dxe/UefiEfiIfrSupportLib/UefiIfrOpCodeCreation.c
index 2c454de951..f96f3a2ea2 100644
--- a/EdkCompatibilityPkg/Foundation/Library/Dxe/UefiEfiIfrSupportLib/UefiIfrOpCodeCreation.c
+++ b/EdkCompatibilityPkg/Foundation/Library/Dxe/UefiEfiIfrSupportLib/UefiIfrOpCodeCreation.c
@@ -485,7 +485,6 @@ CreateNumericOpCode (
   IN OUT EFI_HII_UPDATE_DATA *Data
   )
 {
-  UINTN                       Length;
   EFI_STATUS                  Status;
   EFI_IFR_NUMERIC             Numeric;
   MINMAXSTEP_DATA             MinMaxStep;
@@ -498,7 +497,6 @@ CreateNumericOpCode (
     return EFI_INVALID_PARAMETER;
   }
 
-  Length = sizeof (EFI_IFR_NUMERIC) + sizeof (EFI_IFR_DEFAULT) + sizeof (EFI_IFR_END);
   if (Data->Offset + sizeof (EFI_IFR_CHECKBOX) > Data->BufferSize) {
     return EFI_BUFFER_TOO_SMALL;
   }