From: shenglei Date: Wed, 31 Jul 2019 03:38:12 +0000 (+0800) Subject: UefiCpuPkg/PiSmmCpuDxeSmm: Make code consistent with comments X-Git-Tag: edk2-stable201908~159 X-Git-Url: https://git.proxmox.com/?p=mirror_edk2.git;a=commitdiff_plain;h=5ed4c46f1160b112948ce490a72a95d8eb1242ee UefiCpuPkg/PiSmmCpuDxeSmm: Make code consistent with comments 1.Remove "out" attribute for " Buffer" parameter in function header. 2.Add "out" attribute for " Token" parameter in function header. 3.Update ProcedureArgument to ProcedureArguments. Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Signed-off-by: Shenglei Zhang Reviewed-by: Eric Dong --- diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c index ef16997547..328d7ae53a 100644 --- a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c @@ -1404,7 +1404,7 @@ InternalSmmStartupAllAPs ( EFI_STATUS EFIAPI ProcedureWrapper ( - IN OUT VOID *Buffer + IN VOID *Buffer ) { PROCEDURE_WRAPPER *Wrapper; diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h index 186809f431..a0e59f2088 100644 --- a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h @@ -1329,7 +1329,7 @@ InternalSmmStartupThisAp ( IN EFI_AP_PROCEDURE2 Procedure, IN UINTN CpuIndex, IN OUT VOID *ProcArguments OPTIONAL, - IN MM_COMPLETION *Token, + IN OUT MM_COMPLETION *Token, IN UINTN TimeoutInMicroseconds, IN OUT EFI_STATUS *CpuStatus ); @@ -1387,7 +1387,7 @@ IsPresentAp ( @param[in] TimeoutInMicroseconds Indicates the time limit in microseconds for APs to return from Procedure, either for blocking or non-blocking mode. - @param[in,out] ProcedureArgument The parameter passed into Procedure for + @param[in,out] ProcedureArguments The parameter passed into Procedure for all APs. @param[in,out] Token This is an optional parameter that allows the caller to execute the procedure in a blocking or non-blocking fashion. If it is NULL the