From: Leahy, Leroy P Date: Mon, 23 May 2016 15:45:07 +0000 (-0700) Subject: CorebootModulePkg/CbSupportDxe: Text only support X-Git-Tag: edk2-stable201903~6972 X-Git-Url: https://git.proxmox.com/?p=mirror_edk2.git;a=commitdiff_plain;h=60c809f3621039bb1ac6b4c1947baf5a848814b0 CorebootModulePkg/CbSupportDxe: Text only support Not all platforms have or support graphics. The ASSERT that the frame buffer HOB is not NULL is fatal for these platforms. Convert this into an if statement and make the related PcdSet* calls c onditional on locating the frame buffer HOB. Change-Id: Ibdc4bf5359571f3ce1555efcaf4657b8e363b2cd Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Lee Leahy Reviewed-by: Maurice Ma --- diff --git a/CorebootModulePkg/CbSupportDxe/CbSupportDxe.c b/CorebootModulePkg/CbSupportDxe/CbSupportDxe.c index 7671304753..24bacf815c 100755 --- a/CorebootModulePkg/CbSupportDxe/CbSupportDxe.c +++ b/CorebootModulePkg/CbSupportDxe/CbSupportDxe.c @@ -188,16 +188,17 @@ CbDxeEntryPoint ( // Find the frame buffer information and update PCDs // GuidHob = GetFirstGuidHob (&gUefiFrameBufferInfoGuid); - ASSERT (GuidHob != NULL); - FbInfo = (FRAME_BUFFER_INFO *)GET_GUID_HOB_DATA (GuidHob); - Status = PcdSet32S (PcdVideoHorizontalResolution, FbInfo->HorizontalResolution); - ASSERT_EFI_ERROR (Status); - Status = PcdSet32S (PcdVideoVerticalResolution, FbInfo->VerticalResolution); - ASSERT_EFI_ERROR (Status); - Status = PcdSet32S (PcdSetupVideoHorizontalResolution, FbInfo->HorizontalResolution); - ASSERT_EFI_ERROR (Status); - Status = PcdSet32S (PcdSetupVideoVerticalResolution, FbInfo->VerticalResolution); - ASSERT_EFI_ERROR (Status); + if (GuidHob != NULL) { + FbInfo = (FRAME_BUFFER_INFO *)GET_GUID_HOB_DATA (GuidHob); + Status = PcdSet32S (PcdVideoHorizontalResolution, FbInfo->HorizontalResolution); + ASSERT_EFI_ERROR (Status); + Status = PcdSet32S (PcdVideoVerticalResolution, FbInfo->VerticalResolution); + ASSERT_EFI_ERROR (Status); + Status = PcdSet32S (PcdSetupVideoHorizontalResolution, FbInfo->HorizontalResolution); + ASSERT_EFI_ERROR (Status); + Status = PcdSet32S (PcdSetupVideoVerticalResolution, FbInfo->VerticalResolution); + ASSERT_EFI_ERROR (Status); + } // // Register callback on the ready to boot event