From: James Bottomley Date: Wed, 16 Dec 2020 01:41:46 +0000 (-0800) Subject: OvmfPkg/AmdSev/SecretDxe: make secret location naming generic X-Git-Tag: edk2-stable202102~333 X-Git-Url: https://git.proxmox.com/?p=mirror_edk2.git;a=commitdiff_plain;h=96201ae7bf97c3a2c0ef386110bb93d25e9af1ba OvmfPkg/AmdSev/SecretDxe: make secret location naming generic It is anticipated that this part of the code will work for both Intel TDX and AMD SEV, so remove the SEV specific naming and change to ConfidentialComputing as a more architecture neutral prefix. Apart from the symbol rename, there are no code changes. Signed-off-by: James Bottomley Message-Id: <20201216014146.2229-3-jejb@linux.ibm.com> Reviewed-by: Jiewen Yao Reviewed-by: Laszlo Ersek --- diff --git a/OvmfPkg/AmdSev/SecretDxe/SecretDxe.c b/OvmfPkg/AmdSev/SecretDxe/SecretDxe.c index 5385a6aea2..308022b5b2 100644 --- a/OvmfPkg/AmdSev/SecretDxe/SecretDxe.c +++ b/OvmfPkg/AmdSev/SecretDxe/SecretDxe.c @@ -6,9 +6,9 @@ **/ #include #include -#include +#include -STATIC SEV_LAUNCH_SECRET_LOCATION mSecretDxeTable = { +STATIC CONFIDENTIAL_COMPUTING_SECRET_LOCATION mSecretDxeTable = { FixedPcdGet32 (PcdSevLaunchSecretBase), FixedPcdGet32 (PcdSevLaunchSecretSize), }; @@ -21,7 +21,7 @@ InitializeSecretDxe( ) { return gBS->InstallConfigurationTable ( - &gSevLaunchSecretGuid, + &gConfidentialComputingSecretGuid, &mSecretDxeTable ); } diff --git a/OvmfPkg/AmdSev/SecretDxe/SecretDxe.inf b/OvmfPkg/AmdSev/SecretDxe/SecretDxe.inf index 62ab00a3d3..40bda7ff84 100644 --- a/OvmfPkg/AmdSev/SecretDxe/SecretDxe.inf +++ b/OvmfPkg/AmdSev/SecretDxe/SecretDxe.inf @@ -27,7 +27,7 @@ UefiDriverEntryPoint [Guids] - gSevLaunchSecretGuid + gConfidentialComputingSecretGuid [FixedPcd] gUefiOvmfPkgTokenSpaceGuid.PcdSevLaunchSecretBase diff --git a/OvmfPkg/Include/Guid/ConfidentialComputingSecret.h b/OvmfPkg/Include/Guid/ConfidentialComputingSecret.h new file mode 100644 index 0000000000..7026fc5b08 --- /dev/null +++ b/OvmfPkg/Include/Guid/ConfidentialComputingSecret.h @@ -0,0 +1,28 @@ + /** @file + UEFI Configuration Table for exposing the SEV Launch Secret location to UEFI + applications (boot loaders). + + Copyright (C) 2020 James Bottomley, IBM Corporation. + SPDX-License-Identifier: BSD-2-Clause-Patent + **/ + +#ifndef CONFIDENTIAL_COMPUTING_SECRET_H_ +#define CONFIDENTIAL_COMPUTING_SECRET_H_ + +#include + +#define CONFIDENTIAL_COMPUTING_SECRET_GUID \ + { 0xadf956ad, \ + 0xe98c, \ + 0x484c, \ + { 0xae, 0x11, 0xb5, 0x1c, 0x7d, 0x33, 0x64, 0x47 }, \ + } + +typedef struct { + UINT64 Base; + UINT64 Size; +} CONFIDENTIAL_COMPUTING_SECRET_LOCATION; + +extern EFI_GUID gConfidentialComputingSecretGuid; + +#endif // SEV_LAUNCH_SECRET_H_ diff --git a/OvmfPkg/Include/Guid/SevLaunchSecret.h b/OvmfPkg/Include/Guid/SevLaunchSecret.h deleted file mode 100644 index dfd8964665..0000000000 --- a/OvmfPkg/Include/Guid/SevLaunchSecret.h +++ /dev/null @@ -1,28 +0,0 @@ - /** @file - UEFI Configuration Table for exposing the SEV Launch Secret location to UEFI - applications (boot loaders). - - Copyright (C) 2020 James Bottomley, IBM Corporation. - SPDX-License-Identifier: BSD-2-Clause-Patent - **/ - -#ifndef SEV_LAUNCH_SECRET_H_ -#define SEV_LAUNCH_SECRET_H_ - -#include - -#define SEV_LAUNCH_SECRET_GUID \ - { 0xadf956ad, \ - 0xe98c, \ - 0x484c, \ - { 0xae, 0x11, 0xb5, 0x1c, 0x7d, 0x33, 0x64, 0x47 }, \ - } - -typedef struct { - UINT64 Base; - UINT64 Size; -} SEV_LAUNCH_SECRET_LOCATION; - -extern EFI_GUID gSevLaunchSecretGuid; - -#endif // SEV_LAUNCH_SECRET_H_ diff --git a/OvmfPkg/OvmfPkg.dec b/OvmfPkg/OvmfPkg.dec index 8a294116ef..50d7b27d94 100644 --- a/OvmfPkg/OvmfPkg.dec +++ b/OvmfPkg/OvmfPkg.dec @@ -117,7 +117,7 @@ gLinuxEfiInitrdMediaGuid = {0x5568e427, 0x68fc, 0x4f3d, {0xac, 0x74, 0xca, 0x55, 0x52, 0x31, 0xcc, 0x68}} gQemuKernelLoaderFsMediaGuid = {0x1428f772, 0xb64a, 0x441e, {0xb8, 0xc3, 0x9e, 0xbd, 0xd7, 0xf8, 0x93, 0xc7}} gGrubFileGuid = {0xb5ae312c, 0xbc8a, 0x43b1, {0x9c, 0x62, 0xeb, 0xb8, 0x26, 0xdd, 0x5d, 0x07}} - gSevLaunchSecretGuid = {0xadf956ad, 0xe98c, 0x484c, {0xae, 0x11, 0xb5, 0x1c, 0x7d, 0x33, 0x64, 0x47}} + gConfidentialComputingSecretGuid = {0xadf956ad, 0xe98c, 0x484c, {0xae, 0x11, 0xb5, 0x1c, 0x7d, 0x33, 0x64, 0x47}} [Ppis] # PPI whose presence in the PPI database signals that the TPM base address