From: mdkinney Date: Wed, 16 Mar 2011 02:58:51 +0000 (+0000) Subject: Add description for 64-byte FIFO enable bit for PcdSerialFifoControl. X-Git-Tag: edk2-stable201903~15073 X-Git-Url: https://git.proxmox.com/?p=mirror_edk2.git;a=commitdiff_plain;h=acaa2726fbaa32a1adfa57caf8679eae316a8750 Add description for 64-byte FIFO enable bit for PcdSerialFifoControl. Update SerialPortInitializer() to properly preserve BIT5 in FCR instead of BIT4. git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11404 6f19259b-4bc3-4df7-8a09-765794883524 --- diff --git a/MdeModulePkg/Library/BaseSerialPortLib16550/BaseSerialPortLib16550.c b/MdeModulePkg/Library/BaseSerialPortLib16550/BaseSerialPortLib16550.c index a6c990dee6..2238749215 100644 --- a/MdeModulePkg/Library/BaseSerialPortLib16550/BaseSerialPortLib16550.c +++ b/MdeModulePkg/Library/BaseSerialPortLib16550/BaseSerialPortLib16550.c @@ -158,7 +158,7 @@ SerialPortInitialize ( // Enable and reset FIFOs // Strip reserved bits from PcdSerialFifoControl // - SerialPortWriteRegister (R_UART_FCR, (UINT8)(PcdGet8 (PcdSerialFifoControl) & 0x17)); + SerialPortWriteRegister (R_UART_FCR, (UINT8)(PcdGet8 (PcdSerialFifoControl) & 0x27)); // // Put Modem Control Register(MCR) into its reset state of 0x00. diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec index 11e9ffab25..4ab6358d49 100644 --- a/MdeModulePkg/MdeModulePkg.dec +++ b/MdeModulePkg/MdeModulePkg.dec @@ -444,7 +444,9 @@ # BIT0 - FIFO Enable. 0 = Disable FIFOs. 1 = Enable FIFOs. # BIT1 - Clear receive FIFO. 1 = Clear FIFO. # BIT2 - Clear transmit FIFO. 1 = Clear FIFO. - # BIT7..BIT3 - Reserved. Must be 0. + # BIT4..BIT3 - Reserved. Must be 0. + # BIT5 - Enable 64-byte FIFO. 0 = Disable 64-byte FIFO. 1 = Enable 64-byte FIFO + # BIT7..BIT6 - Reserved. Must be 0. # # Default is to enable and clear all FIFOs. #