From: Dandan Bi Date: Tue, 28 Feb 2017 08:04:13 +0000 (+0800) Subject: MdeModulePkg: Fix coding style issues X-Git-Tag: edk2-stable201903~4529 X-Git-Url: https://git.proxmox.com/?p=mirror_edk2.git;a=commitdiff_plain;h=c325e41585e374d40fb36b434e61a1ab0fca5b1c MdeModulePkg: Fix coding style issues 1. Make function comments align with the function. 2. Change the FILE_GUID value in SmmSmiHandlerProfileLib.inf since it is duplicated with the FILE_GUID value in SmiHandlerProfileLibNull.inf 3. Add missing PCD PROMPT&HELP string to uni file. Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi Reviewed-by: Jiewen Yao --- diff --git a/MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfileInfo.c b/MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfileInfo.c index 00cab0cd8e..84a1c8ee53 100644 --- a/MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfileInfo.c +++ b/MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfileInfo.c @@ -245,7 +245,7 @@ GetShortPdbFileName ( 2. FFS UI section 3. Image GUID - @param[in] DriverInfo Pointer to memory profile driver info. + @param[in] ImageStruct Point to the image structure. @return The resulting Ascii name string is stored in the mNameString global array. diff --git a/MdeModulePkg/Library/SmmSmiHandlerProfileLib/SmmSmiHandlerProfileLib.inf b/MdeModulePkg/Library/SmmSmiHandlerProfileLib/SmmSmiHandlerProfileLib.inf index 0c1ad7eb06..ba0d65ec08 100644 --- a/MdeModulePkg/Library/SmmSmiHandlerProfileLib/SmmSmiHandlerProfileLib.inf +++ b/MdeModulePkg/Library/SmmSmiHandlerProfileLib/SmmSmiHandlerProfileLib.inf @@ -19,7 +19,7 @@ INF_VERSION = 0x00010005 BASE_NAME = SmmSmiHandlerProfileLib MODULE_UNI_FILE = SmmSmiHandlerProfileLib.uni - FILE_GUID = B43D1B52-6251-4E6F-82EC-A599A5EE94C1 + FILE_GUID = FC38CEAE-FB74-4049-A51C-68F0BA69DA7D MODULE_TYPE = DXE_SMM_DRIVER VERSION_STRING = 1.0 LIBRARY_CLASS = SmiHandlerProfileLib|DXE_SMM_DRIVER diff --git a/MdeModulePkg/MdeModulePkg.uni b/MdeModulePkg/MdeModulePkg.uni index 5436b60d6b..ff0d697078 100644 --- a/MdeModulePkg/MdeModulePkg.uni +++ b/MdeModulePkg/MdeModulePkg.uni @@ -1075,3 +1075,17 @@ #string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdTestKeyUsed_HELP #language en-US "This dynamic PCD holds the information if there is any test key used by the platform." +#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdSmiHandlerProfilePropertyMask_PROMPT #language en-US "SmiHandlerProfile Property." + +#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdSmiHandlerProfilePropertyMask_HELP #language en-US "The mask is used to control SmiHandlerProfile behavior.

\n" + "BIT0 - Enable SmiHandlerProfile.
" + +#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdImageProtectionPolicy_PROMPT #language en-US "Set image protection policy." + +#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdImageProtectionPolicy_HELP #language en-US "Set image protection policy. The policy is bitwise.\n" + "If a bit is set, the image will be protected by DxeCore if it is aligned.\n" + "The code section becomes read-only, and the data section becomes non-executable.\n" + "If a bit is clear, the image will not be protected.

\n" + "BIT0 - Image from unknown device.
\n" + "BIT1 - Image from firmware volume.
" +