From: Star Zeng Date: Fri, 13 Jul 2018 07:04:16 +0000 (+0800) Subject: MdeModulePkg CapsuleApp: Fix memory leak in DumpFmpImage() X-Git-Tag: edk2-stable201903~1370 X-Git-Url: https://git.proxmox.com/?p=mirror_edk2.git;a=commitdiff_plain;h=d4d9116775763a7ce4bff894ea06ecef4b17e441 MdeModulePkg CapsuleApp: Fix memory leak in DumpFmpImage() Image buffer should be freed after using. Cc: Michael D Kinney Cc: Jiewen Yao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng Reviewed-by: Jiewen Yao --- diff --git a/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c b/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c index 6c1320942b..c0197dd640 100644 --- a/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c +++ b/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c @@ -953,5 +953,7 @@ DumpFmpImage ( Status = WriteFileFromBuffer(ImageName, ImageSize, Image); Print(L"CapsuleApp: Dump %g ImageIndex (0x%x) to %s %r\n", ImageTypeId, ImageIndex, ImageName, Status); + FreePool (Image); + return ; }