From: Eric Dong <eric.dong@intel.com>
Date: Thu, 7 Apr 2016 05:56:44 +0000 (+0800)
Subject: SecurityPkg OpalPasswordDxe: Suppress option for special device.
X-Git-Tag: edk2-stable201903~7380
X-Git-Url: https://git.proxmox.com/?p=mirror_edk2.git;a=commitdiff_plain;h=ea2a6eb786c3fa881fdd5146de00c6a48273b4c1

SecurityPkg OpalPasswordDxe: Suppress option for special device.

According to current Pyrite SSC Spec 1.00, there is no parameter
for RevertSP method. So suppress KeepUserData option for the
Pyrite Ssc type device.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Feng Tian <feng.tian@intel.com>
---

diff --git a/SecurityPkg/Tcg/Opal/OpalPasswordDxe/OpalHii.c b/SecurityPkg/Tcg/Opal/OpalPasswordDxe/OpalHii.c
index eb7d59b52c..94dce6c505 100644
--- a/SecurityPkg/Tcg/Opal/OpalPasswordDxe/OpalHii.c
+++ b/SecurityPkg/Tcg/Opal/OpalPasswordDxe/OpalHii.c
@@ -374,7 +374,13 @@ HiiSelectDiskAction (
 
     case HII_KEY_ID_GOTO_REVERT:
       gHiiConfiguration.AvailableFields |= HII_FIELD_PASSWORD;
-      gHiiConfiguration.AvailableFields |= HII_FIELD_KEEP_USER_DATA;
+      if (OpalDisk->SupportedAttributes.PyriteSsc != 1) {
+        //
+        // According to current Pyrite SSC Spec 1.00, there is no parameter for RevertSP method.
+        // So issue RevertSP method without any parameter by suppress KeepUserData option.
+        //
+        gHiiConfiguration.AvailableFields |= HII_FIELD_KEEP_USER_DATA;
+      }
       if (AvailActions.RevertKeepDataForced) {
         gHiiConfiguration.AvailableFields |= HII_FIELD_KEEP_USER_DATA_FORCED;
       }
@@ -611,6 +617,14 @@ HiiPopulateDiskInfoForm(
         // Default initialize keep user Data to be true
         //
         gHiiConfiguration.KeepUserData = 1;
+        if (OpalDisk->SupportedAttributes.PyriteSsc == 1) {
+          //
+          // According to current Pyrite SSC Spec 1.00, there is no parameter for RevertSP method.
+          // So issue RevertSP method without any parameter by set default value to FALSE.
+          //
+          gHiiConfiguration.KeepUserData = 0;
+        }
+
       }
     }
   }