From: Gao, Liming <liming.gao@intel.com>
Date: Mon, 17 Mar 2014 07:22:50 +0000 (+0000)
Subject: Remove ASSERT check for SetVariable in FirmwarePerformanceDataTableDxe
X-Git-Tag: edk2-stable201903~11635
X-Git-Url: https://git.proxmox.com/?p=mirror_edk2.git;a=commitdiff_plain;h=fd704cbd17f6388520bcb57e6c9fec2a32362ca4;hp=8a8c6c962a4abc75224799bfd03f2f68bb2a89e3

Remove ASSERT check for SetVariable in FirmwarePerformanceDataTableDxe

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Gao, Liming <liming.gao@intel.com>
Reviewed-by: Yao, Jiewen <jiewen.yao@intel.com>



git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15330 6f19259b-4bc3-4df7-8a09-765794883524
---

diff --git a/MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableDxe/FirmwarePerformanceDxe.c b/MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableDxe/FirmwarePerformanceDxe.c
index 9ea8f5c6b0..caf924ccf8 100644
--- a/MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableDxe/FirmwarePerformanceDxe.c
+++ b/MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableDxe/FirmwarePerformanceDxe.c
@@ -5,7 +5,7 @@
   for Firmware Basic Boot Performance Record and other boot performance records, 
   and install FPDT to ACPI table.
 
-  Copyright (c) 2011 - 2013, Intel Corporation. All rights reserved.<BR>
+  Copyright (c) 2011 - 2014, Intel Corporation. All rights reserved.<BR>
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD License
   which accompanies this distribution.  The full text of the license may be found at
@@ -488,15 +488,15 @@ InstallFirmwarePerformanceDataTable (
   mFirmwarePerformanceTableTemplate.S3PointerRecord.S3PerformanceTablePointer = (UINT64) (UINTN) mAcpiS3PerformanceTable;
   //
   // Save Runtime Performance Table pointers to Variable.
-  //
-  Status = gRT->SetVariable (
-                  EFI_FIRMWARE_PERFORMANCE_VARIABLE_NAME,
-                  &gEfiFirmwarePerformanceGuid,
-                  EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS,
-                  sizeof (PerformanceVariable),
-                  &PerformanceVariable
-                  );
-  ASSERT_EFI_ERROR (Status);
+  // Don't check SetVariable return status. It doesn't impact FPDT table generation. 
+  //
+  gRT->SetVariable (
+        EFI_FIRMWARE_PERFORMANCE_VARIABLE_NAME,
+        &gEfiFirmwarePerformanceGuid,
+        EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS,
+        sizeof (PerformanceVariable),
+        &PerformanceVariable
+        );
 
   //
   // Publish Firmware Performance Data Table.