]>
git.proxmox.com Git - mirror_edk2.git/log
Olivier Martin [Tue, 15 Jul 2014 09:18:44 +0000 (09:18 +0000)]
ArmPlatformPkg/ArmPlatformLib.h: Added documentation for ArmPlatformPeiBootAction()
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Olivier Martin <olivier.martin@arm.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15657
6f19259b -4bc3-4df7-8a09-
765794883524
Ronald Cron [Tue, 15 Jul 2014 09:17:36 +0000 (09:17 +0000)]
ArmPlatformPkg/Bds: Added update of Pxe boot option
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
Reviewed-By: Olivier Martin <olivier.martin@arm.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15656
6f19259b -4bc3-4df7-8a09-
765794883524
Eric Dong [Mon, 14 Jul 2014 11:01:17 +0000 (11:01 +0000)]
Add check to make code more safely.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eric Dong <eric.dong@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15655
6f19259b -4bc3-4df7-8a09-
765794883524
Eric Dong [Mon, 14 Jul 2014 06:14:20 +0000 (06:14 +0000)]
Check the validation when return from callback function to avoid use the invalid form set.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15654
6f19259b -4bc3-4df7-8a09-
765794883524
Star Zeng [Mon, 14 Jul 2014 01:38:19 +0000 (01:38 +0000)]
MdePkg PeiHobLib: Initialize Owner field of Resource HOB to 0 rather than random value.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15653
6f19259b -4bc3-4df7-8a09-
765794883524
Jeff Fan [Fri, 11 Jul 2014 02:36:56 +0000 (02:36 +0000)]
1. Save/restore ICR high 32bit value and check Delivery Status before sending IPI. It could be fix the interrupted issue between ICR high/low writes by SMI handler.
2. Save/restore CPU Interrupt state around sending IPI. It could avoid sending IPI be interrupted by CPU interrupt handler.
3. Add note for SetApicMode() API that must not be called from an interrupt handler or SMI handler.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jeff Fan <jeff.fan@intel.com>
Reviewed-by: Kinney, Michael <michael.d.kinney@intel.com>
Reviewed-by: Mudusuru, Giri <giri.p.mudusuru@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15652
6f19259b -4bc3-4df7-8a09-
765794883524
Fu, Siyuan [Thu, 10 Jul 2014 07:46:34 +0000 (07:46 +0000)]
Fix a memory use after free bug in DHCP6 driver.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Fu, Siyuan <siyuan.fu@intel.com>
Reviewed-By: Ye, Ting <ting.ye@intel.com>
Reviewed-by: Wu, Jiaxin <jiaxin.wu@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15651
6f19259b -4bc3-4df7-8a09-
765794883524
Jeff Fan [Thu, 10 Jul 2014 02:12:27 +0000 (02:12 +0000)]
Introduce one PCD PcdCpuInitIpiDelayInMicroSeconds to specify the delay value after sending out INIT IPI instead of hard code 10 MicroSeconds.
Its default value is 10 millisecond per IA32 manual.
Platform could customize this PCD value for performance requirement.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jeff Fan <jeff.fan@intel.com>
Reviewed-by: Kinney, Michael <michael.d.kinney@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15650
6f19259b -4bc3-4df7-8a09-
765794883524
Eric Dong [Thu, 10 Jul 2014 01:52:28 +0000 (01:52 +0000)]
Fix build fail for VS2005 tool chain.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eric Dong <eric.dong@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15649
6f19259b -4bc3-4df7-8a09-
765794883524
Eric Dong [Thu, 10 Jul 2014 01:25:41 +0000 (01:25 +0000)]
Fixed one code error, should use & instead of |.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15648
6f19259b -4bc3-4df7-8a09-
765794883524
Eugene Cohen [Wed, 9 Jul 2014 11:14:36 +0000 (11:14 +0000)]
ArmPkg/ArmLib: Improved ArmConfigureMmu Performance
Data & Instruction Caches can be kept enabled while the new
translation table is filled.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eugene Cohen <eugene@hp.com>
Reviewed-By: Olivier Martin <olivier.martin@arm.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15647
6f19259b -4bc3-4df7-8a09-
765794883524
Harry Liebel [Wed, 9 Jul 2014 09:10:44 +0000 (09:10 +0000)]
MdePkg/BasePrintLib: Do not do operations with NULL
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Harry Liebel <Harry.Liebel@arm.com>
Reviewed-By: Olivier Martin <olivier.martin@arm.com>
Reviewed-by: Gao, Liming <liming.gao@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15646
6f19259b -4bc3-4df7-8a09-
765794883524
Eric Dong [Wed, 9 Jul 2014 08:30:07 +0000 (08:30 +0000)]
Refine the readme.txt for Duet platform, update the GCC tool chain to GCC44.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15645
6f19259b -4bc3-4df7-8a09-
765794883524
Eric Dong [Wed, 9 Jul 2014 08:28:05 +0000 (08:28 +0000)]
Update the bat file, avoid change the original binary file in SVN, copy a temp file to use.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15644
6f19259b -4bc3-4df7-8a09-
765794883524
Olivier Martin [Wed, 9 Jul 2014 05:19:24 +0000 (05:19 +0000)]
The UEFI specification does not say anything when the pointers passed to
WaitForEvent() are NULL.
Passing NULL pointer would cause a segmentation fault in the current code.
This change prevents to get segmentation faults in this case.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Olivier Martin <olivier.martin@arm.com>
Signed-off-by: Feng Tian <feng.tian@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15643
6f19259b -4bc3-4df7-8a09-
765794883524
Chen Fan [Wed, 9 Jul 2014 03:51:56 +0000 (03:51 +0000)]
Fixed typos: hanlder should be handler.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chen Fan <chen.fan.fnst@cn.fujitsu.com>
Reviewed-by: Jeff Fan <jeff.fan@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15642
6f19259b -4bc3-4df7-8a09-
765794883524
Eric Dong [Wed, 9 Jul 2014 02:49:24 +0000 (02:49 +0000)]
Refine the sample for action, should not use text two part.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15641
6f19259b -4bc3-4df7-8a09-
765794883524
Eric Dong [Wed, 9 Jul 2014 01:50:55 +0000 (01:50 +0000)]
Fix build fail for VS2005 tool chain.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eric Dong <eric.dong@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15640
6f19259b -4bc3-4df7-8a09-
765794883524
Eric Dong [Tue, 8 Jul 2014 06:04:53 +0000 (06:04 +0000)]
Refine the save action for the browser.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15639
6f19259b -4bc3-4df7-8a09-
765794883524
Long, Qin [Tue, 8 Jul 2014 03:03:24 +0000 (03:03 +0000)]
Update OpenSSL from 0.9.8w to the latest 0.9.8za.
Main changes include:
1. Update the patch file for 0.9.8za;
2. Update the install scripts to align the path for 0.9.8za;
3. OpensslLib.inf : Update the OPENSSL_PATH for 0.9.8za; enable more OPENSLL FLAGS to disable those un-used algorithms for better build performance and size;
4. Update the HOWTO file to align new OpenSSL version.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Long, Qin <qin.long@intel.com>
Reviewed-by: Ye, Ting <ting.ye@intel.com>
Reviewed-by: Fu, Siyuan <siyuan.fu@intel.com>
Reviewed-by: Dong, Guo <guo.dong@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15638
6f19259b -4bc3-4df7-8a09-
765794883524
Star Zeng [Tue, 8 Jul 2014 01:42:46 +0000 (01:42 +0000)]
MdeModulePkg XhciPei: Fix build failure "conversion from 'UINT32' to 'UINT8', possible loss of data".
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15637
6f19259b -4bc3-4df7-8a09-
765794883524
Eric Dong [Mon, 7 Jul 2014 06:30:33 +0000 (06:30 +0000)]
Refine code to follow good coding style.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eric Dong <eric.dong@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15636
6f19259b -4bc3-4df7-8a09-
765794883524
Star Zeng [Mon, 7 Jul 2014 05:59:53 +0000 (05:59 +0000)]
MdeModulePkg XhciPei: Initialize ScratchPhy and ScratchEntryPhy in XhcPeiInitSched().
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: Feng Tian <feng.tian@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15635
6f19259b -4bc3-4df7-8a09-
765794883524
Star Zeng [Mon, 7 Jul 2014 05:58:25 +0000 (05:58 +0000)]
MdeModulePkg XhciDxe: Initialize ScratchPhy and ScratchEntryPhy in XhcInitSched().
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: Feng Tian <feng.tian@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15634
6f19259b -4bc3-4df7-8a09-
765794883524
Eric Dong [Mon, 7 Jul 2014 05:56:26 +0000 (05:56 +0000)]
Restore the question value before call the CHANGED callback type.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Liming, Gao <liming.gao@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15633
6f19259b -4bc3-4df7-8a09-
765794883524
Jordan Justen [Fri, 4 Jul 2014 20:50:41 +0000 (20:50 +0000)]
EmulatorPkg: Add structure braces { } to fix build warning
The GCC parameter -Wno-missing-braces was recently removed. This
caused build warnings where structures were instantiated without
proper brace usage.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15632
6f19259b -4bc3-4df7-8a09-
765794883524
Jordan Justen [Fri, 4 Jul 2014 20:50:24 +0000 (20:50 +0000)]
EmulatorPkg/PlatformSmbiosDxe/SmbiosTable.c: Convert to CRLF (dos text)
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15631
6f19259b -4bc3-4df7-8a09-
765794883524
Olivier Martin [Fri, 4 Jul 2014 14:47:11 +0000 (14:47 +0000)]
EmbeddedPkg/Lan9118Dxe: Handle EFI_STATUS from PhySoftReset() & SoftReset()
- Make the function PhySoftReset() return EFI_STATUS
- EFI_STATUS was treated as a signed integer by the caller which is not correct.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Olivier Martin <olivier.martin@arm.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15630
6f19259b -4bc3-4df7-8a09-
765794883524
Ronald Cron [Fri, 4 Jul 2014 14:46:21 +0000 (14:46 +0000)]
ArmPlatformPkg/Bds: Added boot timeout setting
Added boot timeout setting in UEFI boot manager menu
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
Reviewed-By: Olivier Martin <olivier.martin@arm.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15629
6f19259b -4bc3-4df7-8a09-
765794883524
Olivier Martin [Fri, 4 Jul 2014 14:41:30 +0000 (14:41 +0000)]
ArmPkg/ArmGic: Returned the InterruptId in ArmGicAcknowledgeInterrupt()
The InterruptId has a different width for GicV2 and GicV3 (respectively
10bit and 24bit).
The function prototype has been changed to return this value to make the
caller GIC architecture version independent. Otherwise, we would have need
to expose a different mask to allow the caller to retrieve this value from
the read register.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Olivier Martin <olivier.martin@arm.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15628
6f19259b -4bc3-4df7-8a09-
765794883524
Olivier Martin [Fri, 4 Jul 2014 14:38:14 +0000 (14:38 +0000)]
ArmPkg/ArmGic: Introduced support for GicV2 to ArmGicDxe
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Olivier Martin <olivier.martin@arm.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15627
6f19259b -4bc3-4df7-8a09-
765794883524
Olivier Martin [Fri, 4 Jul 2014 14:36:42 +0000 (14:36 +0000)]
ArmPkg/ArmGic: Introduced support for GicV2 to ArmGicLib
The support for GIcV2 was already existing. This change separate the GicV2
specific functions from the common Gic code (in preparation for GicV3 support).
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Olivier Martin <olivier.martin@arm.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15626
6f19259b -4bc3-4df7-8a09-
765794883524
Olivier Martin [Fri, 4 Jul 2014 11:27:28 +0000 (11:27 +0000)]
ArmPkg/ArmGic: Moved ArmGicDisableDistributor() to ArmGicLib.c
The implementation is the same when we run in Secure or Non-Secure world.
This change makes this function available for ArmGicSec.inf and ArmGicNonSec.inf.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Olivier Martin <olivier.martin@arm.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15625
6f19259b -4bc3-4df7-8a09-
765794883524
Olivier Martin [Fri, 4 Jul 2014 11:26:33 +0000 (11:26 +0000)]
ArmPkg/ArmGic: Move RegisterInterruptSource() to the common GicDxe file
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Olivier Martin <olivier.martin@arm.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15624
6f19259b -4bc3-4df7-8a09-
765794883524
Olivier Martin [Fri, 4 Jul 2014 11:25:29 +0000 (11:25 +0000)]
ArmPkg/ArmGic: Move the installation and the registration to InstallAndRegisterInterruptService()
It will allow reusing the same code for GICv2 and GICv3 only drivers.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Olivier Martin <olivier.martin@arm.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15623
6f19259b -4bc3-4df7-8a09-
765794883524
Olivier Martin [Fri, 4 Jul 2014 11:20:45 +0000 (11:20 +0000)]
ArmPkg/ArmGic: Make the GicDxe driver depends on ArmGicLib (cont)
... and also rename the ArmGicLib sources to use an explicit 'Lib' suffix.
The renaming did not work well with SVN. Files were missing from the initial commit.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Olivier Martin <olivier.martin@arm.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15622
6f19259b -4bc3-4df7-8a09-
765794883524
Olivier Martin [Fri, 4 Jul 2014 11:16:48 +0000 (11:16 +0000)]
ArmPkg/ArmGic: Introduced helper functions to access the GIC controller
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Olivier Martin <olivier.martin@arm.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15621
6f19259b -4bc3-4df7-8a09-
765794883524
Olivier Martin [Fri, 4 Jul 2014 11:14:20 +0000 (11:14 +0000)]
ArmPkg/ArmGic: Make the GicDxe driver depends on ArmGicLib
... and also rename the ArmGicLib sources to use an explicit 'Lib' suffix.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Olivier Martin <olivier.martin@arm.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15620
6f19259b -4bc3-4df7-8a09-
765794883524
Olivier Martin [Fri, 4 Jul 2014 11:13:27 +0000 (11:13 +0000)]
ArmPkg/ArmGic: Move out the EndOfInterrupt from the interrupt acknowledgement
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Olivier Martin <olivier.martin@arm.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15619
6f19259b -4bc3-4df7-8a09-
765794883524
Olivier Martin [Fri, 4 Jul 2014 11:11:53 +0000 (11:11 +0000)]
ArmPkg/Drivers/ArmGic: Introduced ArmGicEndOfInterrupt()
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Olivier Martin <olivier.martin@arm.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15618
6f19259b -4bc3-4df7-8a09-
765794883524
Star Zeng [Fri, 4 Jul 2014 03:30:46 +0000 (03:30 +0000)]
MdeModulePkg XhciDxe: XHCI multiple interface alternate setting support.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: Feng Tian <feng.tian@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15617
6f19259b -4bc3-4df7-8a09-
765794883524
Eric Dong [Fri, 4 Jul 2014 01:58:48 +0000 (01:58 +0000)]
Refine the save action for the BdsDxe.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15616
6f19259b -4bc3-4df7-8a09-
765794883524
Paulo Alcantara [Thu, 3 Jul 2014 20:05:22 +0000 (20:05 +0000)]
EmulatorPkg/EmuSimpleFileSystemDxe: Fix incorrect return values upon allocation failure
In EmuSimpleFileSystemOpenVolume() function - in case an allocation failed
with AllocatePool() - EFI_UNSUPPORTED was being returned instead of
EFI_OUT_OF_RESOURCES, which is incorrect.
Even worse, in EmuSimpleFileSystemDriverBindingStart(), an unitiliasied
variable (Status) will be returned in case of an allocation failure with
AllocateZeroPool().
This patch fixes both issues by correctly returning EFI_OUT_OF_RESOURCES.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Paulo Alcantara <pcacjr@zytor.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15615
6f19259b -4bc3-4df7-8a09-
765794883524
Paulo Alcantara [Thu, 3 Jul 2014 20:05:14 +0000 (20:05 +0000)]
EmulatorPkg/EmuSimpleFileSystemDxe: Fix minor typos
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Paulo Alcantara <pcacjr@zytor.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15614
6f19259b -4bc3-4df7-8a09-
765794883524
Star Zeng [Wed, 2 Jul 2014 09:02:35 +0000 (09:02 +0000)]
SecurityPkg HashLibBaseCryptoRouterDxe/Tpm2DeviceLibRouterPei: Fixed GCC build failure after -Wno-missing-braces option in GCC removed.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15613
6f19259b -4bc3-4df7-8a09-
765794883524
Eric Dong [Wed, 2 Jul 2014 05:54:41 +0000 (05:54 +0000)]
Correct the default value for date opcode.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15612
6f19259b -4bc3-4df7-8a09-
765794883524
Star Zeng [Wed, 2 Jul 2014 03:20:49 +0000 (03:20 +0000)]
MdeModulePkg XhciPei/UsbBusPei: Add XHCI recovery support.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: Feng Tian <feng.tian@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15611
6f19259b -4bc3-4df7-8a09-
765794883524
Star Zeng [Wed, 2 Jul 2014 02:29:02 +0000 (02:29 +0000)]
MdeModulePkg SmmLockBoxSmmLib: Add debug message for the address of lockbox(smm) copy.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15610
6f19259b -4bc3-4df7-8a09-
765794883524
Olivier Martin [Tue, 1 Jul 2014 09:27:19 +0000 (09:27 +0000)]
ArmPkg/BdsLib: Prevent memory leak whith TFTP
In some case, the size of the downloaded TFTP image cannot be known.
An arbitrary larger buffer is allocated to receive the image.
We need to make sure when we free the buffer we free the size
of the allocated buffer and not the size of the actual image.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Olivier Martin <olivier.martin@arm.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15609
6f19259b -4bc3-4df7-8a09-
765794883524
Olivier Martin [Tue, 1 Jul 2014 09:26:28 +0000 (09:26 +0000)]
ArmPkg/ArmCacheMaintenanceLib: Fixed comment (and coding style)
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Olivier Martin <olivier.martin@arm.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15608
6f19259b -4bc3-4df7-8a09-
765794883524
Olivier Martin [Tue, 1 Jul 2014 09:25:30 +0000 (09:25 +0000)]
EmbeddedPkg/SerialDxe: Fixed the mixture of RETURN_STATUS and EFI_STATUS
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Olivier Martin <olivier.martin@arm.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15607
6f19259b -4bc3-4df7-8a09-
765794883524
Olivier Martin [Tue, 1 Jul 2014 09:24:07 +0000 (09:24 +0000)]
ArmPkg/CpuDxe/ArmV6: Return error status when ExceptionHandlersStart is not 32-byte aligned
The function should detect and return the error in non-debug builds when the ASSERT does nothing.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Olivier Martin <olivier.martin@arm.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15606
6f19259b -4bc3-4df7-8a09-
765794883524
Gao, Liming [Tue, 1 Jul 2014 07:10:10 +0000 (07:10 +0000)]
Sync BaseTool trunk (version r2670) into EDKII BaseTools.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Gao, Liming <liming.gao@intel.com>
Reviewed-by: Liu, Yingke D (yingke.d.liu@intel.com)
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15605
6f19259b -4bc3-4df7-8a09-
765794883524
Tapan Shah [Mon, 30 Jun 2014 20:14:24 +0000 (20:14 +0000)]
ShellPkg: Fix Ctrl+C support for dmpstore command.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Tapan Shah <tapandshah@hp.com>
Reviewed-by: Jaben Carsey <Jaben.carsey@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15604
6f19259b -4bc3-4df7-8a09-
765794883524
Fu, Siyuan [Mon, 30 Jun 2014 07:48:23 +0000 (07:48 +0000)]
Fix a bug in IP4 driver when computing the network broadcast adress.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Fu, Siyuan <siyuan.fu@intel.com>
Reviewed-By: Ye, Ting <ting.ye@intel.com>
Reviewed-by: Wu, Jiaxin <jiaxin.wu@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15603
6f19259b -4bc3-4df7-8a09-
765794883524
Jeff Fan [Mon, 30 Jun 2014 06:13:53 +0000 (06:13 +0000)]
Fix the potential address overflow issue when checking PE signature.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jeff Fan <jeff.fan@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15602
6f19259b -4bc3-4df7-8a09-
765794883524
Gao, Liming [Fri, 27 Jun 2014 19:15:35 +0000 (19:15 +0000)]
OvmfPkg/QemuFlashFvbServicesRuntimeDxe: Fix GCC44 build failure.
Initialize the input parameter FwhInstance in function GetFvbInstance().
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: "Gao, Liming" <liming.gao@intel.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15601
6f19259b -4bc3-4df7-8a09-
765794883524
Tapan Shah [Fri, 27 Jun 2014 08:50:27 +0000 (08:50 +0000)]
MdeModulePkg/PiSmmCore: Initialize missing LoadedImage protocol fields for SMM driver.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Tapan Shah <tapandshah@hp.com>
Reviewed-by: Feng Tian <feng.tian@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15600
6f19259b -4bc3-4df7-8a09-
765794883524
Chen Fan [Fri, 27 Jun 2014 07:30:21 +0000 (07:30 +0000)]
EmulatorPkg/CpuRuntimeDxe: Fix typos in MpService
mMpSercicesTemplate => mMpServicesTemplate
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chen Fan <chen.fan.fnst@cn.fujitsu.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15599
6f19259b -4bc3-4df7-8a09-
765794883524
Eric Dong [Thu, 26 Jun 2014 03:24:25 +0000 (03:24 +0000)]
Refine code to make it more safely.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Feng Tian <feng.tian@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15598
6f19259b -4bc3-4df7-8a09-
765794883524
Eric Dong [Thu, 26 Jun 2014 03:18:44 +0000 (03:18 +0000)]
Refine code to make it more safely.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15597
6f19259b -4bc3-4df7-8a09-
765794883524
Eric Dong [Thu, 26 Jun 2014 03:17:59 +0000 (03:17 +0000)]
Refine code to make it more safely.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15596
6f19259b -4bc3-4df7-8a09-
765794883524
Eric Dong [Thu, 26 Jun 2014 03:16:27 +0000 (03:16 +0000)]
Refine code to make it more safely.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15595
6f19259b -4bc3-4df7-8a09-
765794883524
Eric Dong [Thu, 26 Jun 2014 01:39:25 +0000 (01:39 +0000)]
Refine code to make it more safely.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Jeff Fan <jeff.fan@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15594
6f19259b -4bc3-4df7-8a09-
765794883524
Eric Dong [Thu, 26 Jun 2014 01:38:46 +0000 (01:38 +0000)]
Refine code to make it more safely.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Jaben Carsey <Jaben.carsey@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15593
6f19259b -4bc3-4df7-8a09-
765794883524
Eric Dong [Wed, 25 Jun 2014 06:51:36 +0000 (06:51 +0000)]
Refine code to make it more safely.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Jeff Fan <jeff.fan@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15592
6f19259b -4bc3-4df7-8a09-
765794883524
Eric Dong [Wed, 25 Jun 2014 06:49:53 +0000 (06:49 +0000)]
Refine code to make it more safely.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Jeff Fan <jeff.fan@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15591
6f19259b -4bc3-4df7-8a09-
765794883524
Eric Dong [Wed, 25 Jun 2014 06:00:49 +0000 (06:00 +0000)]
Refine code to make it more safely.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Guo Dong <guo.dong@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15590
6f19259b -4bc3-4df7-8a09-
765794883524
Eric Dong [Wed, 25 Jun 2014 05:44:37 +0000 (05:44 +0000)]
Refine code to make it more safely.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Siyuan Fu <siyuan.fu@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15589
6f19259b -4bc3-4df7-8a09-
765794883524
Eric Dong [Wed, 25 Jun 2014 05:16:52 +0000 (05:16 +0000)]
Refine code to make it more safely.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15588
6f19259b -4bc3-4df7-8a09-
765794883524
Andrew Fish [Wed, 25 Jun 2014 04:54:47 +0000 (04:54 +0000)]
MdeModulePkg/DxeMain: Zero ImageContext local variable before passing it down to PeCoffLoaderRelocateImageExtraAction()
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Andrew Fish <afish@apple.com>
Reviewed-by: Feng Tian <feng.tian@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15587
6f19259b -4bc3-4df7-8a09-
765794883524
Laszlo Ersek [Wed, 25 Jun 2014 03:35:58 +0000 (03:35 +0000)]
OvmfPkg: add missing braces to aggregate and/or union initializers
Lack of these braces causes build errors when -Wno-missing-braces is
absent. Spelling out more braces also helps understanding the code.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15586
6f19259b -4bc3-4df7-8a09-
765794883524
Dong, Guo [Wed, 25 Jun 2014 02:02:22 +0000 (02:02 +0000)]
Update code to always publish EFI_IMAGE_EXECUTION_INFO_TABLE.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dong, Guo <guo.dong@intel.com>
Reviewed-by: Fu, Siyuan <siyuan.fu@intel.com>
Reviewed-by: Gao, Liming <liming.gao@intel.com>
Reviewed-by: Zhang, Chao B <chao.b.zhang@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15585
6f19259b -4bc3-4df7-8a09-
765794883524
Chris Phillips [Tue, 24 Jun 2014 18:39:15 +0000 (18:39 +0000)]
ShellPkg: Fix 'mv' command to not attempt moving a file from write-protected media
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chris Phillips <chrisp@hp.com>
Reviewed-by: Jaben Carsey <Jaben.carsey@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15584
6f19259b -4bc3-4df7-8a09-
765794883524
Gao, Liming [Tue, 24 Jun 2014 02:25:23 +0000 (02:25 +0000)]
Add DEBUG message for all fields in AcpiS3Context.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Gao, Liming <liming.gao@intel.com>
Reviewed-by: Zeng, Star <star.zeng@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15583
6f19259b -4bc3-4df7-8a09-
765794883524
Gao, Liming [Tue, 24 Jun 2014 02:24:13 +0000 (02:24 +0000)]
Add DEBUG message for all fields in AcpiS3Context.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Gao, Liming <liming.gao@intel.com>
Reviewed-by: Zeng, Star <star.zeng@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15582
6f19259b -4bc3-4df7-8a09-
765794883524
Gao, Liming [Tue, 24 Jun 2014 02:22:47 +0000 (02:22 +0000)]
Correct comment typo in AsmReadCr0() function.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Gao, Liming <liming.gao@intel.com>
Reviewed-by: Ni, Ruiyu <ruiyu.ni@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15581
6f19259b -4bc3-4df7-8a09-
765794883524
Tapan Shah [Mon, 23 Jun 2014 18:36:44 +0000 (18:36 +0000)]
ShellPkg: Move UpdateMapping() out of Map command and added to UefiShellCommandLib library.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Tapan Shah <tapandshah@hp.com>
Reviewed-by: Jaben Carsey <Jaben.carsey@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15580
6f19259b -4bc3-4df7-8a09-
765794883524
Olivier Martin [Fri, 20 Jun 2014 18:24:51 +0000 (18:24 +0000)]
ARM Packages: Fixed missing braces (the warning was disabled by GCC)
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Olivier Martin <olivier.martin@arm.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15578
6f19259b -4bc3-4df7-8a09-
765794883524
Olivier Martin [Fri, 20 Jun 2014 18:23:37 +0000 (18:23 +0000)]
ArmPlatformPkg/SP804TimerLib: Checked both Metronome and Performance timers are initialized
Prior to this change if Metronome timer was already initialized the initialization of the
Performance timer was skipped.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Olivier Martin <olivier.martin@arm.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15577
6f19259b -4bc3-4df7-8a09-
765794883524
Tycho Nightingale [Fri, 20 Jun 2014 07:18:08 +0000 (07:18 +0000)]
PcAtChipsetPkg: Enable timer interrupt through I/O APIC
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Tycho Nightingale <tycho.nightingale@pluribusnetworks.com>
Reviewed-by: Elvin Li <elvin.li@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15576
6f19259b -4bc3-4df7-8a09-
765794883524
Ruiyu Ni [Fri, 20 Jun 2014 06:17:54 +0000 (06:17 +0000)]
Do not create boot option for logical block io device.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Reviewed-by: Elvin Li <elvin.li@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15575
6f19259b -4bc3-4df7-8a09-
765794883524
Laszlo Ersek [Thu, 19 Jun 2014 06:13:29 +0000 (06:13 +0000)]
OvmfPkg: AcpiPlatformDxe: don't rely on unstable QEMU interface
The fw_cfg file "etc/acpi/tables" is not a stable guest interface -- QEMU
could rename it in the future, and/or introduce additional fw_cfg files
with ACPI payload. Only the higher-level "etc/table-loader" file is
considered stable, which contains a sequence of commands to assist
firmware with reading QEMU ACPI tables from the FwCfg interface.
Because edk2 provides publishing support for ACPI tables, OVMF only uses
the Allocate command to find the names of FwCfg files to read and publish
as ACPI tables.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15574
6f19259b -4bc3-4df7-8a09-
765794883524
Laszlo Ersek [Thu, 19 Jun 2014 06:13:22 +0000 (06:13 +0000)]
OvmfPkg: AcpiPlatformDxe: exclude RSD PTR from QEMU's fw_cfg payload
In one of the next patches we'll start scanning all fw_cfg files that QEMU
advertises as carrying ACPI tables, not just "etc/acpi/tables".
The RSD PTR table is known to occur in the "etc/acpi/rsdp" fw_cfg file.
Since edk2 handles RSD PTR automatically, similarly to RSDT and XSDT,
let's exclude RSD PTR too from the manually installed tables.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15573
6f19259b -4bc3-4df7-8a09-
765794883524
Laszlo Ersek [Thu, 19 Jun 2014 06:13:12 +0000 (06:13 +0000)]
OvmfPkg: AcpiPlatformDxe: pass FwCfgFile to InstallQemuLinkedTables()
Split InstallQemuLinkedTables() in two:
- the function now takes the name of the fw_cfg file (from which ACPI
tables are to be extracted) as a parameter,
- the new function InstallAllQemuLinkedTables() calls the former with
fw_cfg file names, and cumulatively tracks the ACPI tables installed by
all invocations of the former.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15572
6f19259b -4bc3-4df7-8a09-
765794883524
Laszlo Ersek [Thu, 19 Jun 2014 06:13:01 +0000 (06:13 +0000)]
OvmgPkg: QemuFwCfgLib: export QEMU_FW_CFG_FNAME_SIZE
Names of firmware configuration files always take 56 bytes (including at
least one terminating NUL byte). Expose this constant to all consumers of
QemuFwCfgLib because further interfaces may depend on it.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15571
6f19259b -4bc3-4df7-8a09-
765794883524
Eric Dong [Thu, 19 Jun 2014 01:58:09 +0000 (01:58 +0000)]
Fix GCC build fail.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eric Dong <eric.dong@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15570
6f19259b -4bc3-4df7-8a09-
765794883524
Alex Williamson [Thu, 19 Jun 2014 01:41:15 +0000 (01:41 +0000)]
The following call tree exposes a bug in the lifetime (ie. too late
creation) of PciIoDevice->DevicePath. The bug can be triggered when
PciBusDxe is built into OVMF, with qemu/KVM device assignment of
a PCI-express device on the default 440FX machine type. OVMF
correctly discovers that the device is PCIe and begins probing
extended configuration space for the device. The root bridge
has no way to access extended config space and correctly errors,
sending us into the error reporting chain seen below. It's
possible that this error path could also be reproduced on physical
hardware when a PCI-to-PCIe bridge is present.
GatherDeviceInfo() | GatherPpbInfo() | GatherP2CInfo() [MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c]
CreatePciIoDevice() [MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c]
AllocateZeroPool()
LocateCapabilityRegBlock() [MdeModulePkg/Bus/Pci/PciBusDxe/PciCommand.c]
PciIoDevice->IsPciExp = TRUE
LocatePciExpressCapabilityRegBlock() [MdeModulePkg/Bus/Pci/PciBusDxe/PciCommand.c]
PciIoConfigRead() via funcptr [MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c]
RootBridgeIoPciRead() via funcptr [PcAtChipsetPkg/PciHostBridgeDxe/PciRootBridgeIo.c]
FAILS
REPORT_STATUS_CODE_WITH_DEVICE_PATH() [MdePkg/Include/Library/ReportStatusCodeLib.h]
ReportStatusCodeWithDevicePath() [MdeModulePkg/Library/DxeReportStatusCodeLib/ReportStatusCodeLib.c]
ASSERT (DevicePath != NULL) <--+
CreatePciDevicePath() | [MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c]
sets PciIoDevice->DevicePath ----------+
In English:
- CreatePciIoDevice() allocates a zeroed out PCI_IO_DEVICE structure.
- PciIoConfigRead() tries to access the (extended) config space, and
fails.
- PciIoConfigRead() wants to report a status code (read error) for the
device path.
- Unfortuantely, PciIoDevice->DevicePath is still NULL at that point.
- The ASSERT() in ReportStatusCodeWithDevicePath() fires.
Fix it by moving CreatePciDevicePath() into CreatePciIoDevice(),
allowing PciIoDevice->DevicePath to be initialized before we
begin probing the device capabilities:
GatherDeviceInfo() | GatherPpbInfo() | GatherP2CInfo() [MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c]
CreatePciIoDevice() [MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c]
AllocateZeroPool()
CreatePciDevicePath() [MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c]
sets PciIoDevice->DevicePath -----------+
LocateCapabilityRegBlock() | [MdeModulePkg/Bus/Pci/PciBusDxe/PciCommand.c]
PciIoDevice->IsPciExp = TRUE |
LocatePciExpressCapabilityRegBlock() | [MdeModulePkg/Bus/Pci/PciBusDxe/PciCommand.c]
PciIoConfigRead() via funcptr | [MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c]
RootBridgeIoPciRead() via funcptr | [PcAtChipsetPkg/PciHostBridgeDxe/PciRootBridgeIo.c]
FAILS |
REPORT_STATUS_CODE_WITH_DEVICE_PATH() | [MdePkg/Include/Library/ReportStatusCodeLib.h]
ReportStatusCodeWithDevicePath() | [MdeModulePkg/Library/DxeReportStatusCodeLib/ReportStatusCodeLib.c]
ASSERT (DevicePath != NULL) <-----+
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15567
6f19259b -4bc3-4df7-8a09-
765794883524
Jaben Carsey [Wed, 18 Jun 2014 16:37:16 +0000 (16:37 +0000)]
ShellPkg: Remove use of ASSERT to test parameters
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <Jaben.carsey@intel.com>
Reviewed-by: Erik Bjorge <erik.c.bjorge@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15566
6f19259b -4bc3-4df7-8a09-
765794883524
Victor Gouveia [Wed, 18 Jun 2014 09:01:33 +0000 (09:01 +0000)]
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Victor Gouveia <vc.gouveia@gmail.com>
Reviewed-by: Gao, Liming <liming.gao@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15565
6f19259b -4bc3-4df7-8a09-
765794883524
Ruiyu Ni [Wed, 18 Jun 2014 05:00:13 +0000 (05:00 +0000)]
Create boot option for all block IO devices no matter what the device path looks like.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Reviewed-by: Feng Tian <feng.tian@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15564
6f19259b -4bc3-4df7-8a09-
765794883524
Eric Dong [Wed, 18 Jun 2014 02:19:50 +0000 (02:19 +0000)]
Support RouteConfig function for BdsDxe driver.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Gao, Liming <liming,gao@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15563
6f19259b -4bc3-4df7-8a09-
765794883524
Jaben Carsey [Mon, 16 Jun 2014 21:58:50 +0000 (21:58 +0000)]
ShellPkg: Fix duplicate String IDs
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <Jaben.carsey@intel.com>
Reviewed-by: Erik Bjorge <erik.c.bjorge@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15562
6f19259b -4bc3-4df7-8a09-
765794883524
Andrew Fish [Mon, 16 Jun 2014 08:31:41 +0000 (08:31 +0000)]
Fix build issues with Xcode in CryptoPkg and SecurityPkg.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Andrew Fish <afish@apple.com>
Reviewed-by: Ye Ting <ting.ye@intel.com>
Reviewed-by: Long Qin <qin.long@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15561
6f19259b -4bc3-4df7-8a09-
765794883524
Andrew Fish [Mon, 16 Jun 2014 08:30:41 +0000 (08:30 +0000)]
Fix build issues with Xcode in CryptoPkg and SecurityPkg.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Andrew Fish <afish@apple.com>
Reviewed-by: Ye Ting <ting.ye@intel.com>
Reviewed-by: Long Qin <qin.long@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15560
6f19259b -4bc3-4df7-8a09-
765794883524
Qiu Shumin [Fri, 6 Jun 2014 08:47:18 +0000 (08:47 +0000)]
Use a compare operator for Non-Boolean comparison in 'map.c'.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin <shumin.qiu@intel.com>
Reviewed-by: Jaben carsey <Jaben.carsey@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15559
6f19259b -4bc3-4df7-8a09-
765794883524
Jaben Carsey [Thu, 5 Jun 2014 22:02:12 +0000 (22:02 +0000)]
ShellPkg: fix Comp command output
The comp command was potentially displaying the incorrect offset into the file due to comparing 3 extra bytes for difference groups.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <Jaben.carsey@intel.com>
Reviewed-by: Tapan Shah <tapandshah@hp.com>
Reviewed-by: Erik Bjorge <erik.c.bjorge@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15558
6f19259b -4bc3-4df7-8a09-
765794883524
Tian, Feng [Wed, 4 Jun 2014 06:35:29 +0000 (06:35 +0000)]
MdeModulePkg/NvmExpressDxe: Check if CSTS.RDY is 0 to wait NVMe Host controller disable
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Tian, Feng <feng.tian@intel.com>
Reviewed-by: Zeng, Star <star.zeng@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15557
6f19259b -4bc3-4df7-8a09-
765794883524
Jeff Fan [Wed, 4 Jun 2014 01:47:24 +0000 (01:47 +0000)]
Rename TimeoutInSeconds to Timeout to avoid confusion.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jeff Fan <jeff.fan@intel.com>
Reviewed-by: Mike Maslenkin <mihailm@parallels.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15556
6f19259b -4bc3-4df7-8a09-
765794883524
Olivier Martin [Tue, 3 Jun 2014 16:44:09 +0000 (16:44 +0000)]
ArmPlatformPkg/ArmVExpressPkg: Set CNTFRQ to 100Mhz for the Fast Models
The timer frequency for the FVP Architectural Timers have been aligned to 100Mhz.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Olivier Martin <olivier.martin@arm.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15555
6f19259b -4bc3-4df7-8a09-
765794883524