mirror_edk2.git
4 years agoCorebootPayloadPkg DSC: Change the section alignment option
Maurice Ma [Wed, 26 Oct 2016 18:15:14 +0000 (11:15 -0700)]
CorebootPayloadPkg DSC: Change the section alignment option

The current CorebootPayloadPkg will print the following message
"InsertImageRecord - Section Alignment(0x20) is not 4K" during
boot. It is caused by the section alignment arranged by the linker.
This patch change the alignment to 4K for runtime drivers.

Cc: Prince Agyeman <prince.agyeman@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Maurice Ma <maurice.ma@intel.com>
Reviewed-by: Prince Agyeman <prince.agyeman@intel.com>
4 years agoCorebootPayloadPkg: Switch to use StatusCode driver in MdeModulePkg
Maurice Ma [Wed, 26 Oct 2016 17:51:54 +0000 (10:51 -0700)]
CorebootPayloadPkg: Switch to use StatusCode driver in MdeModulePkg

The current CorebootPayloadPkg uses PEI/DXE StatusCode drivers from
IntelFrameworkModulePkg. This patch switches to use the StatusCode
driver from MdeModulePkg instead.

Cc: Prince Agyeman <prince.agyeman@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Maurice Ma <maurice.ma@intel.com>
Reviewed-by: Prince Agyeman <prince.agyeman@intel.com>
4 years agoArmPlatformPkg: remove ARM BDS
Ard Biesheuvel [Tue, 25 Oct 2016 17:12:45 +0000 (18:12 +0100)]
ArmPlatformPkg: remove ARM BDS

This is no longer used, and does not belong in a reference code base,
so remove it.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Tested-by: Ryan Harkin <ryan.harkin@linaro.org>
Reviewed-by: Ryan Harkin <ryan.harkin@linaro.org>
4 years agoAppPkg: Update email and URL.
Jaben Carsey [Mon, 24 Oct 2016 16:28:36 +0000 (09:28 -0700)]
AppPkg: Update email and URL.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com>
Reviewed-by: Daryl McDaniel <edk2-lists@mc2research.org>
4 years agoOvmfPkg/XenConsoleSerialPortLib: don't include <Uefi/UefiBaseType.h>
Laszlo Ersek [Tue, 25 Oct 2016 14:25:44 +0000 (16:25 +0200)]
OvmfPkg/XenConsoleSerialPortLib: don't include <Uefi/UefiBaseType.h>

XenConsoleSerialPortLib is a BASE type library instance, without being
restricted to UEFI client modules. (For example, the
"ArmVirtPkg/ArmVirtXen.dsc" platform builds this library instance into
"ArmVirtPkg/PrePi/ArmVirtPrePiUniCoreRelocatable.inf", which is a SEC type
module.) For such library instances, including <Uefi/UefiBaseType.h> is
not right.

Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
4 years agoNetworkPkg: Support bracketed IPv6 address during a redirection in iSCSI
Zhang Lubo [Wed, 26 Oct 2016 06:21:08 +0000 (14:21 +0800)]
NetworkPkg: Support bracketed IPv6 address during a redirection in iSCSI

According to RFC 3720, the TargetAddress provided in a redirection
might be a DNS host name, a dotted-decimal IPv4 address, or a
bracketed IPv6 address. Current ISCSI driver in Networkpkg only
supports dotted-decimal IPv4 address, so we need add IPv6 address
support since it is a combo driver supporting dual stack.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo <lubo.zhang@intel.com>
Cc: Ye Ting <ting.ye@intel.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Cc: Wu Jiaxin <jiaxin.wu@intel.com>
Reviewed-by: Fu Siyuan <siyuan.fu@intel.com>
4 years agoNetworkPkg: Enhance the code in DNS driver.
Zhang Lubo [Fri, 14 Oct 2016 06:51:24 +0000 (14:51 +0800)]
NetworkPkg: Enhance the code in DNS driver.

There may be an error happens when we use the
configure function to set or change the configuration
data for the DNS6 instance, So we will free the
DnsServerList without configured to NULL. If we reset
the instance with the parameter DnsConfigData to NULL, the
DnsServerList will be freed twice.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo <lubo.zhang@intel.com>
Cc: Ye Ting <ting.ye@intel.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Cc: Wu Jiaxin <jiaxin.wu@intel.com>
Reviewed-by: Fu Siyuan <siyuan.fu@intel.com>
Reviewed-by: Wu Jiaxin <jiaxin.wu@intel.com>
4 years agoNetworkPkg: Add dns support for pxe boot based on IPv6.
Zhang Lubo [Fri, 14 Oct 2016 07:12:09 +0000 (15:12 +0800)]
NetworkPkg: Add dns support for pxe boot based on IPv6.

The BootFileURL option (59) in dhcpv6 is used to deliver
the next server address with bootfile name, as an example
"tftp://[FEDC:BA98:7654:3210:FEDC:BA98:7654:3210]/BOOTFILE_NAME;
mode=octet", it can also be “tftp://domain_name/BOOTFILE_NAME;
mode=octet”, this patch is to support this case.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo <lubo.zhang@intel.com>
Cc: Ye Ting <ting.ye@intel.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Cc: Wu Jiaxin <jiaxin.wu@intel.com>
Reviewed-by: Fu Siyuan <siyuan.fu@intel.com>
4 years agoBeagleBoardPkg: move to generic BDS
Ard Biesheuvel [Tue, 25 Oct 2016 16:32:28 +0000 (17:32 +0100)]
BeagleBoardPkg: move to generic BDS

Drop the ARM BDS and related dependencies, and switch to the generic
BDS instead.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
4 years agoBeagleBoardPkg: remove unused modules
Ard Biesheuvel [Tue, 25 Oct 2016 14:32:05 +0000 (15:32 +0100)]
BeagleBoardPkg: remove unused modules

Commit 0bade1054db7 ("BeagleBoardPkg: Replaced the original DSC/FDF files
by their new versions that use the ARM Platform Framework"), which dates
back to 2011, modified BeagleBoardPkg to replace references to its Sec.inf,
Bds.inf and some of its library implementations to refer to versions under
ArmPlatformPkg instead. Since the original modules have been unused ever
since, we can safely remove them now.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
4 years agoOmap35xxPkg: enable -DDISABLE_NEW_DEPRECATED_INTERFACES
Ard Biesheuvel [Tue, 25 Oct 2016 17:09:35 +0000 (18:09 +0100)]
Omap35xxPkg: enable -DDISABLE_NEW_DEPRECATED_INTERFACES

Define DISABLE_NEW_DEPRECATED_INTERFACES on the compiler command line by
default, to prevent deprecated interfaces from being used in core EDK2
code.

Bug: https://bugzilla.tianocore.org/show_bug.cgi?id=164
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
4 years agoOmap35xxPkg/Omap35xxPkg.dsc: fix build and add missing modules
Ard Biesheuvel [Tue, 25 Oct 2016 17:06:42 +0000 (18:06 +0100)]
Omap35xxPkg/Omap35xxPkg.dsc: fix build and add missing modules

Bring Omap35xxPkg.dsc up to date so it covers all modules and builds
correctly with the latest toolchains.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
4 years agoOmap35xxPkg/MMCHSDxe: fix device path initializer
Ard Biesheuvel [Tue, 25 Oct 2016 17:04:42 +0000 (18:04 +0100)]
Omap35xxPkg/MMCHSDxe: fix device path initializer

Fix the braces in a static device path template definition.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
4 years agoOmap35xxPkg: remove unused ResetSystemLib implementation
Ard Biesheuvel [Tue, 25 Oct 2016 17:02:52 +0000 (18:02 +0100)]
Omap35xxPkg: remove unused ResetSystemLib implementation

This code is unused so remove it.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
4 years agoArmPkg/ArmDmaLib: add missing DxeServicesTableLib dependency
Ard Biesheuvel [Tue, 25 Oct 2016 17:01:44 +0000 (18:01 +0100)]
ArmPkg/ArmDmaLib: add missing DxeServicesTableLib dependency

This missing dependency has gone unnoticed until now, but it is breaking
the Omap35xxPkg.dsc build.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
4 years agoedksetup.bat: make sure BASE_TOOLS_PATH be set correctly
Liming Gao [Wed, 26 Oct 2016 03:31:52 +0000 (11:31 +0800)]
edksetup.bat: make sure BASE_TOOLS_PATH be set correctly

Move checkNt32Flag before set BASE_TOOLS_PATH env to make sure it be set

Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Liming Gao <liming.gao@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com>
4 years agoMdePkg ACPI60: Update MADT Revision per ACPI 6.0 Errata A
Liming Gao [Tue, 25 Oct 2016 11:34:15 +0000 (19:34 +0800)]
MdePkg ACPI60: Update MADT Revision per ACPI 6.0 Errata A

Fix issue: https://bugzilla.tianocore.org/show_bug.cgi?id=94

Cc: Jiewen Yao <jiewen.yao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Liming Gao <liming.gao@intel.com>
Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>
4 years agoMdePkg ACPI51: Update GIC version per ACPI 5.1 Errata B
Liming Gao [Fri, 14 Oct 2016 07:30:06 +0000 (15:30 +0800)]
MdePkg ACPI51: Update GIC version per ACPI 5.1 Errata B

Fix issue: https://bugzilla.tianocore.org/show_bug.cgi?id=95

Cc: Jiewen Yao <jiewen.yao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Liming Gao <liming.gao@intel.com>
Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>
4 years agoNetworkPkg: Fix typos in comments
Gary Lin [Wed, 19 Oct 2016 07:01:28 +0000 (15:01 +0800)]
NetworkPkg: Fix typos in comments

- assocated -> associated
- malformated -> malformatted
- mal-formated -> mal-formatted
- formated -> formatted
- octects -> octets
- responsiblity -> responsibility
- enought -> enough
- immediatly -> immediately
- integar -> integer
- Alogrithem -> Algorithm
- Initializeion -> Initialization
- primelenght -> primelength
- Vlaue -> Value
- perfoms -> performs
- randome -> random
- verifed -> verified
- finallization -> finalization
- Intializes -> Initializes
- specifed -> specified
- if -> If
- Decrption -> Decryption
- Autahentication -> Authentication
- informatino -> information
- alogrithm -> algorithm
- Authenticaion -> Authentication
- Alogrithem -> Algorithm
- containning -> containing
- paramter -> parameter

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Gary Lin <glin@suse.com>
Reviewed-By: Siyuan Fu <siyuan.fu@intel.com>
Reviewed-By: Jiaxin Wu <jiaxin.wu@intel.com>
4 years agoQuarkSocPkg: Fix typos in comments
Gary Lin [Wed, 19 Oct 2016 07:01:33 +0000 (00:01 -0700)]
QuarkSocPkg: Fix typos in comments

- paramter -> parameter
- reseting -> resetting
- stoping -> stopping
- hanlder -> handler
- boundry -> boundary
- tempory -> temporary

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Kelly Steele <kelly.steele@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Gary Lin <glin@suse.com>
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
4 years agoQuarkPlatformPkg: Fix typos in comments
Gary Lin [Wed, 19 Oct 2016 07:01:32 +0000 (00:01 -0700)]
QuarkPlatformPkg: Fix typos in comments

- TURE -> TRUE
- reseting -> resetting
- retore -> restore
- boundry -> boundary
- tempory -> temporary

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Kelly Steele <kelly.steele@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Gary Lin <glin@suse.com>
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
4 years agoArmVirtPkg: disable deprecated interfaces
Laszlo Ersek [Fri, 21 Oct 2016 14:30:58 +0000 (16:30 +0200)]
ArmVirtPkg: disable deprecated interfaces

At this point no code in ArmVirtPkg (and apparently no code outside of
ArmVirtPkg that the ArmVirt binaries depend on) uses the deprecated APIs,
so we can disable them in the common platform DSC include file:

BaseLib:
- StrCpy
- StrnCpy
- StrCat
- StrnCat
- UnicodeStrToAsciiStr
- AsciiStrCpy
- AsciiStrnCpy
- AsciiStrCat
- AsciiStrnCat
- AsciiStrToUnicodeStr

PcdLib:
- PcdSet8
- PcdSet16
- PcdSet32
- PcdSet64
- PcdSetPtr
- PcdSetBool
- PcdSetEx8
- PcdSetEx16
- PcdSetEx32
- PcdSetEx64
- PcdSetExPtr
- PcdSetExBool

UefiLib:
- GetVariable
- GetEfiGlobalVariable

Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Tested-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> # RVCT
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
4 years agoArmPkg/DefaultExceptionHandlerLib: replace AsciiStrCat() with AsciiStrCatS()
Laszlo Ersek [Fri, 21 Oct 2016 19:31:09 +0000 (21:31 +0200)]
ArmPkg/DefaultExceptionHandlerLib: replace AsciiStrCat() with AsciiStrCatS()

AsciiStrCat() is deprecated / disabled under the
DISABLE_NEW_DEPRECATED_INTERFACES feature test macro.

The caller of CpsrString() is required to pass in "ReturnStr" with 32
CHAR8 elements. (DefaultExceptionHandler() complies with this.) "Str" is
used to build "ReturnStr" gradually. Just before calling AsciiStrCat(),
"Str" points to the then-terminating NUL character in "ReturnStr".

The difference (Str - ReturnStr) gives the number of non-NUL characters
we've written thus far, hence (32 - (Str - ReturnStr)) yields the number
of remaining bytes in ReturnStr, including the ultimately terminating NUL
character.

Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Michael Zimmermann <sigmaepsilon92@gmail.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=164
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=165
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
4 years agoArmPkg/ArmDisassemblerLib: replace AsciiStrCat() with AsciiStrCatS()
Laszlo Ersek [Fri, 21 Oct 2016 19:31:09 +0000 (21:31 +0200)]
ArmPkg/ArmDisassemblerLib: replace AsciiStrCat() with AsciiStrCatS()

AsciiStrCat() is deprecated / disabled under the
DISABLE_NEW_DEPRECATED_INTERFACES feature test macro.

The "Str" variable serves no particular purpose in the MRegList() and
ThumbMRegList() functions; replace it with the pointed-to "mMregListStr" /
"mThumbMregListStr" global variable (as appropriate), so that the new
AsciiStrCatS() calls are as clear as possible.

Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Michael Zimmermann <sigmaepsilon92@gmail.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=164
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=165
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
4 years agoArmVirtPkg/PlatformBootManagerLib: eliminate unchecked PcdSetXX() calls
Laszlo Ersek [Fri, 21 Oct 2016 09:59:36 +0000 (11:59 +0200)]
ArmVirtPkg/PlatformBootManagerLib: eliminate unchecked PcdSetXX() calls

These are deprecated / disabled under the
DISABLE_NEW_DEPRECATED_INTERFACES feature test macro.

Introduce a variable called PcdStatus, and use it to assert the success of
these operations (there is no reason for them to fail here).

Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=165
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Tested-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> # RVCT
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
4 years agoArmVirtPkg/FdtPciPcdProducerLib: eliminate unchecked PcdSetXX() calls
Laszlo Ersek [Fri, 21 Oct 2016 09:59:36 +0000 (11:59 +0200)]
ArmVirtPkg/FdtPciPcdProducerLib: eliminate unchecked PcdSetXX() calls

These are deprecated / disabled under the
DISABLE_NEW_DEPRECATED_INTERFACES feature test macro.

Introduce a variable called PcdStatus, and use it to assert the success of
these operations (there is no reason for them to fail here).

Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=165
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Tested-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> # RVCT
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
4 years agoArmVirtPkg/ArmVirtTimerFdtClientLib: eliminate unchecked PcdSetXX() calls
Laszlo Ersek [Fri, 21 Oct 2016 09:59:36 +0000 (11:59 +0200)]
ArmVirtPkg/ArmVirtTimerFdtClientLib: eliminate unchecked PcdSetXX() calls

These are deprecated / disabled under the
DISABLE_NEW_DEPRECATED_INTERFACES feature test macro.

Introduce a variable called PcdStatus, and use it to assert the success of
these operations (there is no reason for them to fail here).

Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=165
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Tested-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> # RVCT
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
4 years agoArmVirtPkg/ArmVirtPlatformLib: eliminate unchecked PcdSetXX() calls
Laszlo Ersek [Fri, 21 Oct 2016 09:59:36 +0000 (11:59 +0200)]
ArmVirtPkg/ArmVirtPlatformLib: eliminate unchecked PcdSetXX() calls

These are deprecated / disabled under the
DISABLE_NEW_DEPRECATED_INTERFACES feature test macro.

Introduce a variable called PcdStatus, and use it to assert the success of
these operations (there is no reason for them to fail here).

Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=165
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Tested-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> # RVCT
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
4 years agoArmVirtPkg/ArmVirtPL031FdtClientLib: eliminate unchecked PcdSetXX() calls
Laszlo Ersek [Fri, 21 Oct 2016 09:59:36 +0000 (11:59 +0200)]
ArmVirtPkg/ArmVirtPL031FdtClientLib: eliminate unchecked PcdSetXX() calls

These are deprecated / disabled under the
DISABLE_NEW_DEPRECATED_INTERFACES feature test macro.

Introduce a variable called PcdStatus, and use it to assert the success of
these operations (there is no reason for them to fail here).

Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=165
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Tested-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> # RVCT
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
4 years agoArmVirtPkg/ArmVirtGicArchLib: eliminate unchecked PcdSetXX() calls
Laszlo Ersek [Fri, 21 Oct 2016 09:59:36 +0000 (11:59 +0200)]
ArmVirtPkg/ArmVirtGicArchLib: eliminate unchecked PcdSetXX() calls

These are deprecated / disabled under the
DISABLE_NEW_DEPRECATED_INTERFACES feature test macro.

Introduce a variable called PcdStatus, and use it to assert the success of
these operations (there is no reason for them to fail here).

Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=165
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Tested-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> # RVCT
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
4 years agoOvmfPkg: disable deprecated interfaces
Laszlo Ersek [Fri, 21 Oct 2016 14:30:58 +0000 (16:30 +0200)]
OvmfPkg: disable deprecated interfaces

At this point no code in OvmfPkg (and apparently no code outside of
OvmfPkg that OVMF depends on) uses the deprecated APIs, so we can disable
them in the platform DSC files:

BaseLib:
- StrCpy
- StrnCpy
- StrCat
- StrnCat
- UnicodeStrToAsciiStr
- AsciiStrCpy
- AsciiStrnCpy
- AsciiStrCat
- AsciiStrnCat
- AsciiStrToUnicodeStr

PcdLib:
- PcdSet8
- PcdSet16
- PcdSet32
- PcdSet64
- PcdSetPtr
- PcdSetBool
- PcdSetEx8
- PcdSetEx16
- PcdSetEx32
- PcdSetEx64
- PcdSetExPtr
- PcdSetExBool

UefiLib:
- GetVariable
- GetEfiGlobalVariable

Cc: Jordan Justen <jordan.l.justen@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
4 years agoOvmfPkg/QemuFlashFvbServicesRuntimeDxe: eliminate unchecked PcdSetXX() calls
Laszlo Ersek [Fri, 21 Oct 2016 09:59:36 +0000 (11:59 +0200)]
OvmfPkg/QemuFlashFvbServicesRuntimeDxe: eliminate unchecked PcdSetXX() calls

These are deprecated / disabled under the
DISABLE_NEW_DEPRECATED_INTERFACES feature test macro.

Introduce a variable called PcdStatus, and use it to assert the success of
these operations (there is no reason for them to fail here).

Cc: Jordan Justen <jordan.l.justen@intel.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=166
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
4 years agoOvmfPkg/PlatformPei: eliminate unchecked PcdSetXX() calls
Laszlo Ersek [Fri, 21 Oct 2016 09:59:36 +0000 (11:59 +0200)]
OvmfPkg/PlatformPei: eliminate unchecked PcdSetXX() calls

These are deprecated / disabled under the
DISABLE_NEW_DEPRECATED_INTERFACES feature test macro.

Introduce a variable called PcdStatus, and use it to assert the success of
these operations (there is no reason for them to fail here).

Cc: Anthony PERARD <anthony.perard@citrix.com>
Cc: Gary Lin <glin@suse.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=166
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Gary Lin <glin@suse.com>
Tested-by: Gary Lin <glin@suse.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
4 years agoOvmfPkg/PlatformDxe: eliminate unchecked PcdSetXX() calls
Laszlo Ersek [Fri, 21 Oct 2016 09:59:36 +0000 (11:59 +0200)]
OvmfPkg/PlatformDxe: eliminate unchecked PcdSetXX() calls

These are deprecated / disabled under the
DISABLE_NEW_DEPRECATED_INTERFACES feature test macro.

Introduce a variable called PcdStatus, and use it to assert the success of
these operations (there is no reason for them to fail here).

Cc: Jordan Justen <jordan.l.justen@intel.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=166
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Tested-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> # RVCT
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
4 years agoOvmfPkg/SmbiosVersionLib: eliminate unchecked PcdSetXX() calls
Laszlo Ersek [Fri, 21 Oct 2016 09:59:36 +0000 (11:59 +0200)]
OvmfPkg/SmbiosVersionLib: eliminate unchecked PcdSetXX() calls

These are deprecated / disabled under the
DISABLE_NEW_DEPRECATED_INTERFACES feature test macro.

Introduce a variable called PcdStatus, and use it to assert the success of
these operations (there is no reason for them to fail here).

Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=166
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Tested-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> # RVCT
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
4 years agoOvmfPkg/PlatformBootManagerLib: eliminate unchecked PcdSetXX() calls
Laszlo Ersek [Fri, 21 Oct 2016 09:59:36 +0000 (11:59 +0200)]
OvmfPkg/PlatformBootManagerLib: eliminate unchecked PcdSetXX() calls

These are deprecated / disabled under the
DISABLE_NEW_DEPRECATED_INTERFACES feature test macro.

Introduce a variable called PcdStatus, and use it to assert the success of
these operations (there is no reason for them to fail here).

Cc: Anthony PERARD <anthony.perard@citrix.com>
Cc: Gary Lin <glin@suse.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=166
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Gary Lin <glin@suse.com>
Tested-by: Gary Lin <glin@suse.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
4 years agoOvmfPkg/EmuVariableFvbRuntimeDxe: eliminate unchecked PcdSetXX() calls
Laszlo Ersek [Fri, 21 Oct 2016 09:59:36 +0000 (11:59 +0200)]
OvmfPkg/EmuVariableFvbRuntimeDxe: eliminate unchecked PcdSetXX() calls

These are deprecated / disabled under the
DISABLE_NEW_DEPRECATED_INTERFACES feature test macro.

Introduce a variable called PcdStatus, and use it to assert the success of
these operations (there is no reason for them to fail here).

Cc: Anthony PERARD <anthony.perard@citrix.com>
Cc: Gary Lin <glin@suse.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=166
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Gary Lin <glin@suse.com>
Tested-by: Gary Lin <glin@suse.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
4 years agoOvmfPkg/XenBusDxe: eliminate AsciiStrCat() calls
Laszlo Ersek [Fri, 21 Oct 2016 09:46:09 +0000 (11:46 +0200)]
OvmfPkg/XenBusDxe: eliminate AsciiStrCat() calls

AsciiStrCat() is deprecated / disabled under the
DISABLE_NEW_DEPRECATED_INTERFACES feature test macro.

Replace AsciiStrCat() with AsciiSPrint(). Spell out the (already existent)
PrintLib dependency in the INF file. Add an explicit ASSERT() to document
that XenStoreJoin() assumes that the pool allocation always succeeds.

Cc: Anthony PERARD <anthony.perard@citrix.com>
Cc: Gary Lin <glin@suse.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=166
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Gary Lin <glin@suse.com>
Tested-by: Gary Lin <glin@suse.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
4 years agoOvmfPkg/XenBusDxe: eliminate AsciiStrCpy() calls
Laszlo Ersek [Fri, 21 Oct 2016 09:28:54 +0000 (11:28 +0200)]
OvmfPkg/XenBusDxe: eliminate AsciiStrCpy() calls

AsciiStrCpy() is deprecated / disabled under the
DISABLE_NEW_DEPRECATED_INTERFACES feature test macro.

Cc: Anthony PERARD <anthony.perard@citrix.com>
Cc: Gary Lin <glin@suse.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=166
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Gary Lin <glin@suse.com>
Tested-by: Gary Lin <glin@suse.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
4 years agoMdePkg/DebugLib.h: add ASSERT_RETURN_ERROR()
Laszlo Ersek [Fri, 21 Oct 2016 11:01:44 +0000 (13:01 +0200)]
MdePkg/DebugLib.h: add ASSERT_RETURN_ERROR()

ASSERT_EFI_ERROR() cannot be used in BASE type modules because
- the replacement text calls EFI_ERROR(),
- EFI_ERROR() is defined in "MdePkg/Include/Uefi/UefiBaseType.h",
- the inclusion of "UefiBaseType.h" is not required for BASE type modules.

While

  ASSERT (!RETURN_ERROR (StatusParameter))

would be a functional statement in BASE type modules, it would be less
convenient and less informative: ASSERT_EFI_ERROR() prints the actual
StatusParameter.

Hence add ASSERT_RETURN_ERROR(), paralleling ASSERT_EFI_ERROR(). Copy the
original macro definition and update it as follows:
- replace EFI with RETURN,
- wrap overlong lines in the comment block and in the code,
- EFI_D_ERROR is deprecated, so employ DEBUG_ERROR instead.

Cc: Liming Gao <liming.gao@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=166
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Michael Kinney <michael.d.kinney@intel.com>
Tested-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> # RVCT
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
4 years agoShellPkg: update ping to use timer service instead of timer arch protocol .
Fu Siyuan [Thu, 8 Sep 2016 03:27:12 +0000 (11:27 +0800)]
ShellPkg: update ping to use timer service instead of timer arch protocol .

The ping command uses PI CPU arch protocol to calculate the RTT time, which is
not allowed to use in UEFI shell. This patch updates it to use the UEFI timer
event and Stall service to estimate the system timer period.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Fu Siyuan <siyuan.fu@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
Reviewed-by: Hegde, Nagaraj P <nagaraj-p.hegde@hpe.com>
4 years agoMdePkg BaseMemoryLibOptDxe: Add function comment for InternalMemCompareGuid
Liming Gao [Thu, 20 Oct 2016 05:57:14 +0000 (13:57 +0800)]
MdePkg BaseMemoryLibOptDxe: Add function comment for InternalMemCompareGuid

Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Liming Gao <liming.gao@intel.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
4 years agoMdeModulePkg LoadFileOnFv2: Correct the parameter name in function comment
Liming Gao [Thu, 20 Oct 2016 05:55:06 +0000 (13:55 +0800)]
MdeModulePkg LoadFileOnFv2: Correct the parameter name in function comment

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Liming Gao <liming.gao@intel.com>
Reviewed-by: Feng Tian <feng.tian@intel.com>
4 years agoMdeModulePkg/HiiDatabaseDxe.inf: Correct the GUID usages
Ruiyu Ni [Thu, 20 Oct 2016 01:58:45 +0000 (09:58 +0800)]
MdeModulePkg/HiiDatabaseDxe.inf: Correct the GUID usages

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Reviewed-by: Dandan Bi <dandan.bi@intel.com>
4 years agoMdeModulePkg/GraphicsOutputDxe.inf: Correct the protocol/GUID usages
Ruiyu Ni [Thu, 20 Oct 2016 01:58:12 +0000 (09:58 +0800)]
MdeModulePkg/GraphicsOutputDxe.inf: Correct the protocol/GUID usages

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Reviewed-by: Dandan Bi <dandan.bi@intel.com>
4 years agoMdeModulePkg: Add PcdPciDegradeResourceForOptionRom prompt&help to UNI
Ruiyu Ni [Thu, 20 Oct 2016 01:57:01 +0000 (09:57 +0800)]
MdeModulePkg: Add PcdPciDegradeResourceForOptionRom prompt&help to UNI

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Reviewed-by: Dandan Bi <dandan.bi@intel.com>
4 years agoShellPkg: handle '-t or -terse' and '-s' flags for 'ver' command properly
Tapan Shah [Mon, 24 Oct 2016 16:56:37 +0000 (09:56 -0700)]
ShellPkg: handle '-t or -terse' and '-s' flags for 'ver' command properly

'-t or -terse' and '-s' flags are multiple exclusive
So when both flags are used together, command should report an error message.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Tapan Shah <tapandshah@hpe.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
4 years agoArmPlatformPkg/NorFlashDxe: eliminate void pointer arithmetic
Ard Biesheuvel [Mon, 24 Oct 2016 12:33:02 +0000 (13:33 +0100)]
ArmPlatformPkg/NorFlashDxe: eliminate void pointer arithmetic

While most compilers happily allow arithmetic on void pointer,
the RVCT compiler does not, and throws the following warning for
NorFlashDxe:

  ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.c(894,48) :
  error  #1254-D: arithmetic on pointer to void or function type

Since the expression in question involves a cast from UINTN to VOID*,
simply add some parentheses to eliminate this warning.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Ryan Harkin <ryan.harkin@linaro.org>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
4 years agoArmPkg: remove BaseMemoryLibStm
Ard Biesheuvel [Wed, 21 Sep 2016 07:59:36 +0000 (08:59 +0100)]
ArmPkg: remove BaseMemoryLibStm

All users have moved to the generic or accelerated versions in MdePkg,
so remove the obsolete BaseMemoryLibStm.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
4 years agoBeagleBoardPkg: remove dependency on ArmPkg/BaseMemoryLibStm
Ard Biesheuvel [Wed, 21 Sep 2016 07:57:14 +0000 (08:57 +0100)]
BeagleBoardPkg: remove dependency on ArmPkg/BaseMemoryLibStm

The library BaseMemoryLibStm in ArmPkg is deprecated and is going to be
removed. Move to the generic version in MdePkg instead.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
4 years agoArmPlatformPkg/PrePi: avoid global variable write to mSystemMemoryEnd
Ard Biesheuvel [Mon, 24 Oct 2016 08:48:32 +0000 (09:48 +0100)]
ArmPlatformPkg/PrePi: avoid global variable write to mSystemMemoryEnd

The global variable mSystemMemoryEnd is initialized by PrePi only if
it has not been initialized by ArmPlatformPeiBootAction(). This allows
platforms executing under, e.g., ARM Trusted Firmware to dynamically
reserve a window at the top of memory that will be used by the secure
firmware.

However, PrePi is a SEC module, and writing to a global variable
violates the SEC constraints, since SEC and PEI may execute from NOR
flash.

So instead, initialize mSystemMemoryEnd statically. This will ensure
it holds the correct value for all implementations where the value
is not overridden, but still allows it to be overridden during the
call to ArmPlatformPeiBootAction().

Note that this patch also fixes a latent bug on 32-bit platforms where
a value of mSystemMemoryEnd exceeding 4 GB would be truncated to 32-bits
rather than limited to (4 GB - 1)

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Acked-by: Laszlo Ersek <lersek@redhat.com>
Tested-by: Ryan Harkin <ryan.harkin@linaro.org>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
4 years agoArmVirtPkg/PrePi: remove mSystemMemoryEnd
Ard Biesheuvel [Mon, 24 Oct 2016 08:22:22 +0000 (09:22 +0100)]
ArmVirtPkg/PrePi: remove mSystemMemoryEnd

Recording the top of SEC visible system memory in a global variable is
not necessary, and violates the constraints of the SEC/PEI environment,
given that it may execute from NOR flash. So remove it.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Acked-by: Laszlo Ersek <lersek@redhat.com>
4 years agoedksetup.sh, BaseTools/BuildEnv: add --reconfig support
Leif Lindholm [Thu, 20 Oct 2016 15:29:46 +0000 (16:29 +0100)]
edksetup.sh, BaseTools/BuildEnv: add --reconfig support

Add command line option --reconfig to edksetup.sh, forcing cached
copies of Conf/*.txt to be overwritten.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
Reviewed-by: Liming Gao <liming.gao@intel.com>
4 years agoedksetup.sh: rework argument parsing and update usage information
Leif Lindholm [Thu, 20 Oct 2016 14:47:31 +0000 (15:47 +0100)]
edksetup.sh: rework argument parsing and update usage information

Rework the argument parsing logic to a more extensible traditional
while/case setup to prepare for further additions.

While doing that, align the Usage printout to look a bit more like
the output of Edk2Setup.bat (and be more correct).

And also stop passing around command line options to the BuildEnv
script (which does not check them anyway).

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
Reviewed-by: Liming Gao <liming.gao@intel.com>
4 years agoEdk2Setup.bat: Support building platforms with Python source
Cinnamon Shia [Fri, 21 Oct 2016 07:41:21 +0000 (15:41 +0800)]
Edk2Setup.bat: Support building platforms with Python source

Following the same approach as toolsetup.bat:
If build.exe, TargetTool.exe, Trim.exe or GenFds.exe is missing, run its
Python source instead.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Cinnamon Shia <cinnamon.shia@hpe.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
4 years agoedksetup.bat: Support --nt32 X64
Cinnamon Shia [Wed, 19 Oct 2016 04:31:36 +0000 (12:31 +0800)]
edksetup.bat: Support --nt32 X64

Support --nt32 X64 for building 64-bit NT32.
For setting up Windows environment variables requited by NT32, follow the
same approach as Edk2Setup.bat by using the get_vsvars.bat and
SetVisualStudio.bat.

Sync the help text of NT32 with Edk2Setup.bat.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Cinnamon Shia <cinnamon.shia@hpe.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
4 years agoIntelFsp2WrapperPkg: Fix a typo in the comment
Gary Lin [Wed, 19 Oct 2016 07:01:20 +0000 (15:01 +0800)]
IntelFsp2WrapperPkg: Fix a typo in the comment

- boundry -> boundary

Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Giri P Mudusuru <giri.p.mudusuru@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Gary Lin <glin@suse.com>
Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>
Reviewed-by: Giri P Mudusuru <giri.p.mudusuru@intel.com>
4 years agoIntelFsp2Pkg: Fix typos in comments
Gary Lin [Wed, 19 Oct 2016 07:01:19 +0000 (15:01 +0800)]
IntelFsp2Pkg: Fix typos in comments

- tempory -> temporary
- immediatly -> immediately
- permenent -> permanent
- funciton -> function

Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Giri P Mudusuru <giri.p.mudusuru@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Gary Lin <glin@suse.com>
Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>
Reviewed-by: Giri P Mudusuru <giri.p.mudusuru@intel.com>
4 years agoIntelFspWrapperPkg: Fix typos in comments
Gary Lin [Wed, 19 Oct 2016 07:01:18 +0000 (15:01 +0800)]
IntelFspWrapperPkg: Fix typos in comments

- inforamtion -> information
- tempory -> temporary
- boundry -> boundary
- immediatly -> immediately
- permenent -> permanent

Cc: Jiewen Yao <jiewen.yao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Gary Lin <glin@suse.com>
Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>
Reviewed-by: Giri P Mudusuru <giri.p.mudusuru@intel.com>
4 years agoIntelFspPkg: Fix typos in comments
Gary Lin [Wed, 19 Oct 2016 07:01:17 +0000 (15:01 +0800)]
IntelFspPkg: Fix typos in comments

- tempory -> temporary
- immediatly -> immediately
- permenent -> permanent
- paramter -> parameter
- funciton -> function

Cc: Jiewen Yao <jiewen.yao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Gary Lin <glin@suse.com>
Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>
Reviewed-by: Giri P Mudusuru <giri.p.mudusuru@intel.com>
4 years agoSourceLevelDebugPkg: Fix typos in comments
Gary Lin [Wed, 19 Oct 2016 07:01:36 +0000 (15:01 +0800)]
SourceLevelDebugPkg: Fix typos in comments

- descrption -> description
- Libary -> Library
- funciton -> function
- paramter -> parameter
- triggerred -> triggered
- hanlde -> handle

Cc: Jeff Fan <jeff.fan@intel.com>
Cc: Hao Wu <hao.a.wu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Gary Lin <glin@suse.com>
Reviewed-by: Hao Wu <hao.a.wu@intel.com>
Reviewed-by: Jeff Fan <jeff.fan@intel.com>
4 years agoUefiCpuPkg: Fix typos in comments
Gary Lin [Thu, 20 Oct 2016 06:53:02 +0000 (14:53 +0800)]
UefiCpuPkg: Fix typos in comments

- excute -> execute
- Retrive -> Retrieve
- possilbe -> possible
- CONTINOUS -> CONTINUOUS
- storgage -> storage
- allcated -> allocated
- triggerred -> triggered
- paramter -> parameter
- perodically -> periodically
- retore -> restore

v2:
- ruturn -> return

Cc: Jeff Fan <jeff.fan@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Gary Lin <glin@suse.com>
Reviewed-by: Jeff Fan <jeff.fan@intel.com>
4 years agoIntelFrameworkPkg: Fix typos in comments
Gary Lin [Wed, 19 Oct 2016 07:01:16 +0000 (15:01 +0800)]
IntelFrameworkPkg: Fix typos in comments

- paramter -> parameter
- availible -> available

Cc: Jeff Fan <jeff.fan@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Gary Lin <glin@suse.com>
Reviewed-by: Jeff Fan <jeff.fan@intel.com>
4 years agoIntelFrameworkModulePkg: Fix typos in comments
Gary Lin [Wed, 19 Oct 2016 07:01:15 +0000 (15:01 +0800)]
IntelFrameworkModulePkg: Fix typos in comments

- stoping -> stopping
- Pointion -> Position
- Arrary -> Array
- reseting -> resetting
- excute -> execute
- isTRUE -> is TRUE
- connectted -> connected
- Retrive -> Retrieve
- dirvers -> drivers
- funciton -> function
- paramter -> parameter
- availible -> available
- permenent -> permanent
- boundry -> boundary

Cc: Jeff Fan <jeff.fan@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Gary Lin <glin@suse.com>
Reviewed-by: Jeff Fan <jeff.fan@intel.com>
4 years agoSecurityPkg: SmmTcg2PhysicalPresenceLib: Fix coding style issue
Zhang, Chao B [Fri, 21 Oct 2016 05:22:18 +0000 (13:22 +0800)]
SecurityPkg: SmmTcg2PhysicalPresenceLib: Fix coding style issue

Fix coding style issue for function descriptor.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chao Zhang <chao.b.zhang@intel.com>
Reviewed-by: Long Qin <qin.long@intel.com>
Reviewed-by: Bi Dandan <dandan.bi@intel.com>
4 years agoMdePkg: Fix typos in comments
Gary Lin [Wed, 19 Oct 2016 07:01:27 +0000 (15:01 +0800)]
MdePkg: Fix typos in comments

- Resuts -> Results
- outputed -> outputted
- specifiecd -> specified
- TURE -> TRUE
- specifed -> specified
- Pointion -> Position
- Arrary -> Array
- elasped -> elapsed
- paramter -> parameter
- Sumbit -> Submit

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Gary Lin <glin@suse.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
4 years agoEdkCompatibilityPkg: Fix typos in comments
Gary Lin [Wed, 19 Oct 2016 07:01:12 +0000 (15:01 +0800)]
EdkCompatibilityPkg: Fix typos in comments

- excute -> execute
- Pacakges -> Packages
- successfull -> successfully
- outputed -> outputted
- triggerred -> triggered
- specifiecd -> specified
- hexidecimal -> hexadecimal
- Arrary -> Array
- Pointion -> Position
- paramter -> parameter
- stardard -> standard
- perodically -> periodically
- dependecy -> dependency
- evauated -> evaluated
- availible -> available
- boundry -> boundary
- discontiguous -> discontinuous

Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Gary Lin <glin@suse.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
4 years agoBaseTools VS Makefile: Use /MT in replace of /MD to remove specific dll
Liming Gao [Fri, 21 Oct 2016 05:25:19 +0000 (13:25 +0800)]
BaseTools VS Makefile: Use /MT in replace of /MD to remove specific dll

/MD option will introduce the specific version dll dependency. It will cause
the compiled C tools not work on some system.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Liming Gao <liming.gao@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com>
4 years agoArmVirtPkg/ArmVirtGicArchLib: adapt ASSERT()s to 64-bit base addresses
Dennis Chen [Fri, 21 Oct 2016 05:50:24 +0000 (13:50 +0800)]
ArmVirtPkg/ArmVirtGicArchLib: adapt ASSERT()s to 64-bit base addresses

Since All the GIC base address variables has been aligned to 64-bit, it
doesn't make sense to continue use MAX_UINT32 in ASSERT() statement, so
this patch uses MAX_UINTN to adapt to this kind of change.

Contributed-under: TianoCore Contribution Agreement 1.0
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Signed-off-by: Dennis Chen <dennis.chen@arm.com>
Acked-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
4 years agoMdePkg: Add ACPI Low Power Idle Table (LPIT) definitions
Giri P Mudusuru [Tue, 18 Oct 2016 11:18:11 +0000 (04:18 -0700)]
MdePkg: Add ACPI Low Power Idle Table (LPIT) definitions

ACPI Low Power Idle Table (LPIT) Revision 001, dated July 2014
http://www.uefi.org/sites/default/files/resources/ACPI_Low_Power_Idle_Table.pdf

Cc: Michael Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Giri P Mudusuru <giri.p.mudusuru@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>
4 years agoNetworkPkg: Coding style refine for IpSecDxe
Jiaxin Wu [Thu, 20 Oct 2016 01:46:19 +0000 (09:46 +0800)]
NetworkPkg: Coding style refine for IpSecDxe

Cc: Bi Dandan <dandan.bi@intel.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jiaxin Wu <jiaxin.wu@intel.com>
Reviewed-by: Dandan Bi <dandan.bi@intel.com>
4 years agoBaseTools/PatchCheck.py: Update to report error for EFI_D_*
Yonghong Zhu [Mon, 17 Oct 2016 03:13:47 +0000 (11:13 +0800)]
BaseTools/PatchCheck.py: Update to report error for EFI_D_*

In EDK2, DEBUG_* is recommended to be used instead of EFI_D_*. For new
code, they should use DEBUG_* macro.

Fixes:https://bugzilla.tianocore.org/show_bug.cgi?id=143
Cc: Liming Gao <liming.gao@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
4 years agoBaseTools/PatchCheck.py: Update to handle the two [] as prefix
Yonghong Zhu [Mon, 17 Oct 2016 03:12:04 +0000 (11:12 +0800)]
BaseTools/PatchCheck.py: Update to handle the two [] as prefix

The bug is that only remove the first [] when it does the char count,
however sometimes we use [edk2][patch] as prefix, this patch fix this bug.

Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=113
Cc: Liming Gao <liming.gao@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
4 years agoBaseTools/PatchCheck.py: Update for max length of subject and message line
Yonghong Zhu [Mon, 17 Oct 2016 03:06:33 +0000 (11:06 +0800)]
BaseTools/PatchCheck.py: Update for max length of subject and message line

This patch update PatchCheck.py:
1. The subject line of the commit message should be < 72 characters.
2. The other lines of the commit message should be < 76 characters.

Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=113
Cc: Liming Gao <liming.gao@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
4 years agoMdeModulePkg: add ARM/AARCH64 requirements to .dsc
Leif Lindholm [Tue, 27 Sep 2016 01:15:52 +0000 (02:15 +0100)]
MdeModulePkg: add ARM/AARCH64 requirements to .dsc

Some LibraryClasses entries are missing to enable standalone builds
of MdeModulePkg components for ARM/AARCH64. Add those.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
4 years agoBaseTools: Fix typos in comments and variables
Gary Lin [Wed, 19 Oct 2016 07:01:07 +0000 (15:01 +0800)]
BaseTools: Fix typos in comments and variables

- Pacakge -> Package
- outputed -> outputted
- successull -> successfully
- Libary -> Library
- Pointion -> Position
- paramter -> parameter

Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Gary Lin <glin@suse.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com>
4 years agoOvmfPkg: Fix typos in comments
Gary Lin [Wed, 19 Oct 2016 07:01:31 +0000 (15:01 +0800)]
OvmfPkg: Fix typos in comments

- Incude -> Include
- futhure -> future
- Predfined -> Predefined
- minimue -> minimum
- predeined -> predefined
- excute -> execute
- dirver -> driver
- inforamtion -> information

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Gary Lin <glin@suse.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
4 years agoEmulatorPkg: Fix typos in comments and variables
Gary Lin [Wed, 19 Oct 2016 07:01:13 +0000 (15:01 +0800)]
EmulatorPkg: Fix typos in comments and variables

- Predfined -> Predefined
- minimue -> minimum
- predeined -> predefined
- excute -> execute
- availible -> available
- discontiguous -> discontinuous
- permenent -> permanent
- immediatly -> immediately
- environmemt -> environment
- Seperator -> Separator
- remmeber -> remember
- initailized -> initialized

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Gary Lin <glin@suse.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
4 years agoEmbeddedPkg: Fix typos in comments
Gary Lin [Wed, 19 Oct 2016 07:01:14 +0000 (15:01 +0800)]
EmbeddedPkg: Fix typos in comments

- reseting -> resetting
- stoping -> stopping
- Libary -> Library
- paramter -> parameter
- availible -> available
- availble -> available
- proccessed -> processed

Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Gary Lin <glin@suse.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
4 years agoArmPkg: Fix typos in comments
Gary Lin [Wed, 19 Oct 2016 07:01:06 +0000 (15:01 +0800)]
ArmPkg: Fix typos in comments

- differnt -> different
- Libary -> Library
- intialized -> initialized

Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Gary Lin <glin@suse.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
4 years agoArmPlatformPkg/ArmVExpressPkg: add missing '0x' prefix to hex value
Sudeep Holla [Wed, 19 Oct 2016 13:24:34 +0000 (14:24 +0100)]
ArmPlatformPkg/ArmVExpressPkg: add missing '0x' prefix to hex value

Interestingly the build used to succeed even with missing leading '0x'
prefix for a hex value before the commit 0613ccbd1357
("CorebootPayloadPkg/PciHostBridgeLib: Fix the wrong PCI resource limit")

With the above commit, luckily we get
  ...
  raise BadExpression(ERR_ARRAY_ELE % self._Token)
  BadExpression: This must be HEX value for NList or Array: [e6].

This patch fixes the above error by adding the missing '0x' prefix to
the hex value.

Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
4 years agoCorebootPayloadPkg/PciHostBridgeLib: Fix the wrong PCI resource limit
Maurice Ma [Mon, 17 Oct 2016 17:48:04 +0000 (10:48 -0700)]
CorebootPayloadPkg/PciHostBridgeLib: Fix the wrong PCI resource limit

The current PCI resource limit calculation in CorebootPayloadPkg
PciHostBridgeLib is wrong. Adjusted it to match the PciHostBridge
driver's expectation.

Cc: Prince Agyeman <prince.agyeman@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Maurice Ma <maurice.ma@intel.com>
Reviewed-by : Prince Agyeman <prince.agyeman@intel.com>

4 years agoMdeModulePkg/BMMUI: Add error handling codes
Dandan Bi [Mon, 17 Oct 2016 06:51:37 +0000 (14:51 +0800)]
MdeModulePkg/BMMUI: Add error handling codes

The function which handles the "Boot####", "BootOrder" ...
may return failure. This patch adds the error handling codes.
return the failure info to browser.

Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
Reviewed-by: Eric Dong <eric.dong@intel.com>
4 years agoMdeModulePkg/BMMUI: Show "Change Boot/Driver order" page correctly
Dandan Bi [Mon, 17 Oct 2016 06:32:51 +0000 (14:32 +0800)]
MdeModulePkg/BMMUI: Show "Change Boot/Driver order" page correctly

When user enter the "Change Boot Order" page, the BootOptionOrder in
BmmFakeNvData may maintain some uncommitted data which are not saved
in "BootOrder" Variable and BootOptionMenu. So we should not always get
the BootOptionOrder through the function GetBootOrder, it will
result in incorrect UI behaviors. When the BootOptionOrder has not been
saved, we should use the BootOptionOrder in current BmmFakeNvData.

Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
Reviewed-by: Eric Dong <eric.dong@intel.com>
4 years agoMdeModulePkg/BMMUI: Make the BmmFakeNvData and BmmOldFakeNVData consistent
Dandan Bi [Mon, 17 Oct 2016 06:04:21 +0000 (14:04 +0800)]
MdeModulePkg/BMMUI: Make the BmmFakeNvData and BmmOldFakeNVData consistent

In BootMaintRouteConfig function, it will compare the data in BmmFakeNvData
and BmmOldFakeNVData to see whether there are some changes need to save.
In current codes when discarding changes or removing the useless changes,
it will update the related fields in BmmFakeNvData.
But also need to update related fields in BmmOldFakeNVData,
or it will result in incorrect comparison in BootMaintRouteConfig function,
then resulting in incorrect UI behaviors.

Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
Reviewed-by: Eric Dong <eric.dong@intel.com>
4 years agoMdeModulePkg/BMMUI: Remove the incorrect and useless codes
Dandan Bi [Mon, 17 Oct 2016 05:51:05 +0000 (13:51 +0800)]
MdeModulePkg/BMMUI: Remove the incorrect and useless codes

When updating console page, the "ConsoleCheck" in BmmFakeNvData may maintain
the old uncommitted data, we should not copy it to BmmOldFakeNVData.
And in BootMaintRouteConfig function, when save data successfully,
it will copy the BmmFakeNvData to the BmmOldFakeNVData.
So we can delete the logic here.

Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
Reviewed-by: Eric Dong <eric.dong@intel.com>
4 years agoMdeModulePkg/BMMUI: Update TerminalMenu and ConsoleMenu in callback
Dandan Bi [Tue, 11 Oct 2016 02:42:04 +0000 (10:42 +0800)]
MdeModulePkg/BMMUI: Update TerminalMenu and ConsoleMenu in callback

In current codes, When user does some change related to Console or Terminal,
when saving data, it will update the content in TerminalMenu and ConsoleMenu
in BootMaintRouteConfig function. This patch moves the update action to the
BootMaintCallback function with EFI_BROWSER_ACTION_CHANGED type.
The reason for this change is: in BootMaintRouteConfig function when
Var_UpdateConsoleXXXOption() return failure and user discard the previous
change, we should re_update the content in the TerminalMenu and ConsoleMenu.
So we move the update action to the changed callback.

Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
Reviewed-by: Eric Dong <eric.dong@intel.com>
4 years agoMdeModulePkg/SetupBrowser: Send discard info to driver when fail to submit
Dandan Bi [Tue, 6 Sep 2016 10:14:58 +0000 (18:14 +0800)]
MdeModulePkg/SetupBrowser: Send discard info to driver when fail to submit

When fail to submit data and user discard the change, we should send
the discard info to driver with EFI_BROWSER_ACTION_CHANGED callback.

Cc: Liming Gao <liming.gao@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
4 years agoArmPlatformPkg/ArmShellCmdRunAxf: Reference MdePkg protocol definition
Ruiyu Ni [Tue, 18 Oct 2016 06:32:34 +0000 (14:32 +0800)]
ArmPlatformPkg/ArmShellCmdRunAxf: Reference MdePkg protocol definition

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
4 years agoShellPkg: Update sources to include MdePkg protocol definitions
Ruiyu Ni [Tue, 18 Oct 2016 06:30:42 +0000 (14:30 +0800)]
ShellPkg: Update sources to include MdePkg protocol definitions

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
4 years agoEmbeddedPkg/FdtPlatformDxe: Reference Shell protocols in MdePkg
Ruiyu Ni [Fri, 14 Oct 2016 09:31:48 +0000 (17:31 +0800)]
EmbeddedPkg/FdtPlatformDxe: Reference Shell protocols in MdePkg

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
4 years agoArmPkg/LinuxLoader: Reference Shell protocols in MdePkg
Ruiyu Ni [Fri, 14 Oct 2016 09:23:41 +0000 (17:23 +0800)]
ArmPkg/LinuxLoader: Reference Shell protocols in MdePkg

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
4 years agoMdePkg: Merge ShellBase.h and remove Efi prefix from header files
Ruiyu Ni [Tue, 18 Oct 2016 08:37:30 +0000 (16:37 +0800)]
MdePkg: Merge ShellBase.h and remove Efi prefix from header files

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
4 years agoShellPkg: Update header files to reference MdePkg protocol definition
Ruiyu Ni [Tue, 18 Oct 2016 08:27:48 +0000 (16:27 +0800)]
ShellPkg: Update header files to reference MdePkg protocol definition

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
4 years agoMdePkg: Include Shell/ShellDynamicCommand/ShellParameters definitions
Ruiyu Ni [Tue, 18 Oct 2016 08:22:36 +0000 (16:22 +0800)]
MdePkg: Include Shell/ShellDynamicCommand/ShellParameters definitions

Move Shell/ShellDynamicCommand/ShellParameters definitions from
ShellPkg to MdePkg.

The following patches will rename the header file name.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
4 years agoShellPkg: Move SHELL_FREE_NON_NULL from ShellBase.h to ShellLib.h
Ruiyu Ni [Fri, 14 Oct 2016 07:59:53 +0000 (15:59 +0800)]
ShellPkg: Move SHELL_FREE_NON_NULL from ShellBase.h to ShellLib.h

The more proper place for macro SHELL_FREE_NON_NULL is ShellLib.h
instead of ShellBase.h.

Modify Compress.c to resolve build failure due to this change.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
4 years agoMdePkg UefiDevicePathLibDevicePathProtocol: Validate before use.
Eric Dong [Wed, 12 Oct 2016 12:34:05 +0000 (20:34 +0800)]
MdePkg UefiDevicePathLibDevicePathProtocol: Validate before use.

In IsDevicePathValid API, code should validate the device path
buffer not exceed the input MaxSize before reference the path
info.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
4 years agoMdePkg UefiDevicePathLib: Validate buffer length before use buffer.
Eric Dong [Wed, 12 Oct 2016 12:32:16 +0000 (20:32 +0800)]
MdePkg UefiDevicePathLib: Validate buffer length before use buffer.

In IsDevicePathValid API, code should validate the device path
buffer not exceed the input MaxSize before reference the path
info.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
4 years agoBaseTools: support PCD value to use expression in the DEC file
Yonghong Zhu [Wed, 12 Oct 2016 05:28:36 +0000 (13:28 +0800)]
BaseTools: support PCD value to use expression in the DEC file

This patch add the support for Pcd value to use expression in the DEC file.

Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
4 years agoBaseTools: Enhance tool to generate EFI_HII_IIBT_DUPLICATE image block
Yonghong Zhu [Mon, 17 Oct 2016 09:43:45 +0000 (17:43 +0800)]
BaseTools: Enhance tool to generate EFI_HII_IIBT_DUPLICATE image block

When *.IDF file contains multiple definitions of image which point to the
same image, current build tool generates multiple image blocks which
contain the same image content.
This patch enhance tool to generate EFI_HII_IIBT_DUPLICATE image blocks
for non-first images for such case, to save the HII package size.

Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=145
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>