mirror_edk2.git
5 years agoIntelFspWrapperPkg: Fix typos in comments
Gary Lin [Wed, 19 Oct 2016 07:01:18 +0000 (15:01 +0800)]
IntelFspWrapperPkg: Fix typos in comments

- inforamtion -> information
- tempory -> temporary
- boundry -> boundary
- immediatly -> immediately
- permenent -> permanent

Cc: Jiewen Yao <jiewen.yao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Gary Lin <glin@suse.com>
Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>
Reviewed-by: Giri P Mudusuru <giri.p.mudusuru@intel.com>
5 years agoIntelFspPkg: Fix typos in comments
Gary Lin [Wed, 19 Oct 2016 07:01:17 +0000 (15:01 +0800)]
IntelFspPkg: Fix typos in comments

- tempory -> temporary
- immediatly -> immediately
- permenent -> permanent
- paramter -> parameter
- funciton -> function

Cc: Jiewen Yao <jiewen.yao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Gary Lin <glin@suse.com>
Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>
Reviewed-by: Giri P Mudusuru <giri.p.mudusuru@intel.com>
5 years agoSourceLevelDebugPkg: Fix typos in comments
Gary Lin [Wed, 19 Oct 2016 07:01:36 +0000 (15:01 +0800)]
SourceLevelDebugPkg: Fix typos in comments

- descrption -> description
- Libary -> Library
- funciton -> function
- paramter -> parameter
- triggerred -> triggered
- hanlde -> handle

Cc: Jeff Fan <jeff.fan@intel.com>
Cc: Hao Wu <hao.a.wu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Gary Lin <glin@suse.com>
Reviewed-by: Hao Wu <hao.a.wu@intel.com>
Reviewed-by: Jeff Fan <jeff.fan@intel.com>
5 years agoUefiCpuPkg: Fix typos in comments
Gary Lin [Thu, 20 Oct 2016 06:53:02 +0000 (14:53 +0800)]
UefiCpuPkg: Fix typos in comments

- excute -> execute
- Retrive -> Retrieve
- possilbe -> possible
- CONTINOUS -> CONTINUOUS
- storgage -> storage
- allcated -> allocated
- triggerred -> triggered
- paramter -> parameter
- perodically -> periodically
- retore -> restore

v2:
- ruturn -> return

Cc: Jeff Fan <jeff.fan@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Gary Lin <glin@suse.com>
Reviewed-by: Jeff Fan <jeff.fan@intel.com>
5 years agoIntelFrameworkPkg: Fix typos in comments
Gary Lin [Wed, 19 Oct 2016 07:01:16 +0000 (15:01 +0800)]
IntelFrameworkPkg: Fix typos in comments

- paramter -> parameter
- availible -> available

Cc: Jeff Fan <jeff.fan@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Gary Lin <glin@suse.com>
Reviewed-by: Jeff Fan <jeff.fan@intel.com>
5 years agoIntelFrameworkModulePkg: Fix typos in comments
Gary Lin [Wed, 19 Oct 2016 07:01:15 +0000 (15:01 +0800)]
IntelFrameworkModulePkg: Fix typos in comments

- stoping -> stopping
- Pointion -> Position
- Arrary -> Array
- reseting -> resetting
- excute -> execute
- isTRUE -> is TRUE
- connectted -> connected
- Retrive -> Retrieve
- dirvers -> drivers
- funciton -> function
- paramter -> parameter
- availible -> available
- permenent -> permanent
- boundry -> boundary

Cc: Jeff Fan <jeff.fan@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Gary Lin <glin@suse.com>
Reviewed-by: Jeff Fan <jeff.fan@intel.com>
5 years agoSecurityPkg: SmmTcg2PhysicalPresenceLib: Fix coding style issue
Zhang, Chao B [Fri, 21 Oct 2016 05:22:18 +0000 (13:22 +0800)]
SecurityPkg: SmmTcg2PhysicalPresenceLib: Fix coding style issue

Fix coding style issue for function descriptor.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chao Zhang <chao.b.zhang@intel.com>
Reviewed-by: Long Qin <qin.long@intel.com>
Reviewed-by: Bi Dandan <dandan.bi@intel.com>
5 years agoMdePkg: Fix typos in comments
Gary Lin [Wed, 19 Oct 2016 07:01:27 +0000 (15:01 +0800)]
MdePkg: Fix typos in comments

- Resuts -> Results
- outputed -> outputted
- specifiecd -> specified
- TURE -> TRUE
- specifed -> specified
- Pointion -> Position
- Arrary -> Array
- elasped -> elapsed
- paramter -> parameter
- Sumbit -> Submit

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Gary Lin <glin@suse.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
5 years agoEdkCompatibilityPkg: Fix typos in comments
Gary Lin [Wed, 19 Oct 2016 07:01:12 +0000 (15:01 +0800)]
EdkCompatibilityPkg: Fix typos in comments

- excute -> execute
- Pacakges -> Packages
- successfull -> successfully
- outputed -> outputted
- triggerred -> triggered
- specifiecd -> specified
- hexidecimal -> hexadecimal
- Arrary -> Array
- Pointion -> Position
- paramter -> parameter
- stardard -> standard
- perodically -> periodically
- dependecy -> dependency
- evauated -> evaluated
- availible -> available
- boundry -> boundary
- discontiguous -> discontinuous

Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Gary Lin <glin@suse.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
5 years agoBaseTools VS Makefile: Use /MT in replace of /MD to remove specific dll
Liming Gao [Fri, 21 Oct 2016 05:25:19 +0000 (13:25 +0800)]
BaseTools VS Makefile: Use /MT in replace of /MD to remove specific dll

/MD option will introduce the specific version dll dependency. It will cause
the compiled C tools not work on some system.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Liming Gao <liming.gao@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com>
5 years agoArmVirtPkg/ArmVirtGicArchLib: adapt ASSERT()s to 64-bit base addresses
Dennis Chen [Fri, 21 Oct 2016 05:50:24 +0000 (13:50 +0800)]
ArmVirtPkg/ArmVirtGicArchLib: adapt ASSERT()s to 64-bit base addresses

Since All the GIC base address variables has been aligned to 64-bit, it
doesn't make sense to continue use MAX_UINT32 in ASSERT() statement, so
this patch uses MAX_UINTN to adapt to this kind of change.

Contributed-under: TianoCore Contribution Agreement 1.0
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Signed-off-by: Dennis Chen <dennis.chen@arm.com>
Acked-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
5 years agoMdePkg: Add ACPI Low Power Idle Table (LPIT) definitions
Giri P Mudusuru [Tue, 18 Oct 2016 11:18:11 +0000 (04:18 -0700)]
MdePkg: Add ACPI Low Power Idle Table (LPIT) definitions

ACPI Low Power Idle Table (LPIT) Revision 001, dated July 2014
http://www.uefi.org/sites/default/files/resources/ACPI_Low_Power_Idle_Table.pdf

Cc: Michael Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Giri P Mudusuru <giri.p.mudusuru@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>
5 years agoNetworkPkg: Coding style refine for IpSecDxe
Jiaxin Wu [Thu, 20 Oct 2016 01:46:19 +0000 (09:46 +0800)]
NetworkPkg: Coding style refine for IpSecDxe

Cc: Bi Dandan <dandan.bi@intel.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jiaxin Wu <jiaxin.wu@intel.com>
Reviewed-by: Dandan Bi <dandan.bi@intel.com>
5 years agoBaseTools/PatchCheck.py: Update to report error for EFI_D_*
Yonghong Zhu [Mon, 17 Oct 2016 03:13:47 +0000 (11:13 +0800)]
BaseTools/PatchCheck.py: Update to report error for EFI_D_*

In EDK2, DEBUG_* is recommended to be used instead of EFI_D_*. For new
code, they should use DEBUG_* macro.

Fixes:https://bugzilla.tianocore.org/show_bug.cgi?id=143
Cc: Liming Gao <liming.gao@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
5 years agoBaseTools/PatchCheck.py: Update to handle the two [] as prefix
Yonghong Zhu [Mon, 17 Oct 2016 03:12:04 +0000 (11:12 +0800)]
BaseTools/PatchCheck.py: Update to handle the two [] as prefix

The bug is that only remove the first [] when it does the char count,
however sometimes we use [edk2][patch] as prefix, this patch fix this bug.

Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=113
Cc: Liming Gao <liming.gao@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
5 years agoBaseTools/PatchCheck.py: Update for max length of subject and message line
Yonghong Zhu [Mon, 17 Oct 2016 03:06:33 +0000 (11:06 +0800)]
BaseTools/PatchCheck.py: Update for max length of subject and message line

This patch update PatchCheck.py:
1. The subject line of the commit message should be < 72 characters.
2. The other lines of the commit message should be < 76 characters.

Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=113
Cc: Liming Gao <liming.gao@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
5 years agoMdeModulePkg: add ARM/AARCH64 requirements to .dsc
Leif Lindholm [Tue, 27 Sep 2016 01:15:52 +0000 (02:15 +0100)]
MdeModulePkg: add ARM/AARCH64 requirements to .dsc

Some LibraryClasses entries are missing to enable standalone builds
of MdeModulePkg components for ARM/AARCH64. Add those.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
5 years agoBaseTools: Fix typos in comments and variables
Gary Lin [Wed, 19 Oct 2016 07:01:07 +0000 (15:01 +0800)]
BaseTools: Fix typos in comments and variables

- Pacakge -> Package
- outputed -> outputted
- successull -> successfully
- Libary -> Library
- Pointion -> Position
- paramter -> parameter

Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Gary Lin <glin@suse.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com>
5 years agoOvmfPkg: Fix typos in comments
Gary Lin [Wed, 19 Oct 2016 07:01:31 +0000 (15:01 +0800)]
OvmfPkg: Fix typos in comments

- Incude -> Include
- futhure -> future
- Predfined -> Predefined
- minimue -> minimum
- predeined -> predefined
- excute -> execute
- dirver -> driver
- inforamtion -> information

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Gary Lin <glin@suse.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
5 years agoEmulatorPkg: Fix typos in comments and variables
Gary Lin [Wed, 19 Oct 2016 07:01:13 +0000 (15:01 +0800)]
EmulatorPkg: Fix typos in comments and variables

- Predfined -> Predefined
- minimue -> minimum
- predeined -> predefined
- excute -> execute
- availible -> available
- discontiguous -> discontinuous
- permenent -> permanent
- immediatly -> immediately
- environmemt -> environment
- Seperator -> Separator
- remmeber -> remember
- initailized -> initialized

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Gary Lin <glin@suse.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
5 years agoEmbeddedPkg: Fix typos in comments
Gary Lin [Wed, 19 Oct 2016 07:01:14 +0000 (15:01 +0800)]
EmbeddedPkg: Fix typos in comments

- reseting -> resetting
- stoping -> stopping
- Libary -> Library
- paramter -> parameter
- availible -> available
- availble -> available
- proccessed -> processed

Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Gary Lin <glin@suse.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
5 years agoArmPkg: Fix typos in comments
Gary Lin [Wed, 19 Oct 2016 07:01:06 +0000 (15:01 +0800)]
ArmPkg: Fix typos in comments

- differnt -> different
- Libary -> Library
- intialized -> initialized

Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Gary Lin <glin@suse.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
5 years agoArmPlatformPkg/ArmVExpressPkg: add missing '0x' prefix to hex value
Sudeep Holla [Wed, 19 Oct 2016 13:24:34 +0000 (14:24 +0100)]
ArmPlatformPkg/ArmVExpressPkg: add missing '0x' prefix to hex value

Interestingly the build used to succeed even with missing leading '0x'
prefix for a hex value before the commit 0613ccbd1357
("CorebootPayloadPkg/PciHostBridgeLib: Fix the wrong PCI resource limit")

With the above commit, luckily we get
  ...
  raise BadExpression(ERR_ARRAY_ELE % self._Token)
  BadExpression: This must be HEX value for NList or Array: [e6].

This patch fixes the above error by adding the missing '0x' prefix to
the hex value.

Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
5 years agoCorebootPayloadPkg/PciHostBridgeLib: Fix the wrong PCI resource limit
Maurice Ma [Mon, 17 Oct 2016 17:48:04 +0000 (10:48 -0700)]
CorebootPayloadPkg/PciHostBridgeLib: Fix the wrong PCI resource limit

The current PCI resource limit calculation in CorebootPayloadPkg
PciHostBridgeLib is wrong. Adjusted it to match the PciHostBridge
driver's expectation.

Cc: Prince Agyeman <prince.agyeman@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Maurice Ma <maurice.ma@intel.com>
Reviewed-by : Prince Agyeman <prince.agyeman@intel.com>

5 years agoMdeModulePkg/BMMUI: Add error handling codes
Dandan Bi [Mon, 17 Oct 2016 06:51:37 +0000 (14:51 +0800)]
MdeModulePkg/BMMUI: Add error handling codes

The function which handles the "Boot####", "BootOrder" ...
may return failure. This patch adds the error handling codes.
return the failure info to browser.

Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
Reviewed-by: Eric Dong <eric.dong@intel.com>
5 years agoMdeModulePkg/BMMUI: Show "Change Boot/Driver order" page correctly
Dandan Bi [Mon, 17 Oct 2016 06:32:51 +0000 (14:32 +0800)]
MdeModulePkg/BMMUI: Show "Change Boot/Driver order" page correctly

When user enter the "Change Boot Order" page, the BootOptionOrder in
BmmFakeNvData may maintain some uncommitted data which are not saved
in "BootOrder" Variable and BootOptionMenu. So we should not always get
the BootOptionOrder through the function GetBootOrder, it will
result in incorrect UI behaviors. When the BootOptionOrder has not been
saved, we should use the BootOptionOrder in current BmmFakeNvData.

Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
Reviewed-by: Eric Dong <eric.dong@intel.com>
5 years agoMdeModulePkg/BMMUI: Make the BmmFakeNvData and BmmOldFakeNVData consistent
Dandan Bi [Mon, 17 Oct 2016 06:04:21 +0000 (14:04 +0800)]
MdeModulePkg/BMMUI: Make the BmmFakeNvData and BmmOldFakeNVData consistent

In BootMaintRouteConfig function, it will compare the data in BmmFakeNvData
and BmmOldFakeNVData to see whether there are some changes need to save.
In current codes when discarding changes or removing the useless changes,
it will update the related fields in BmmFakeNvData.
But also need to update related fields in BmmOldFakeNVData,
or it will result in incorrect comparison in BootMaintRouteConfig function,
then resulting in incorrect UI behaviors.

Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
Reviewed-by: Eric Dong <eric.dong@intel.com>
5 years agoMdeModulePkg/BMMUI: Remove the incorrect and useless codes
Dandan Bi [Mon, 17 Oct 2016 05:51:05 +0000 (13:51 +0800)]
MdeModulePkg/BMMUI: Remove the incorrect and useless codes

When updating console page, the "ConsoleCheck" in BmmFakeNvData may maintain
the old uncommitted data, we should not copy it to BmmOldFakeNVData.
And in BootMaintRouteConfig function, when save data successfully,
it will copy the BmmFakeNvData to the BmmOldFakeNVData.
So we can delete the logic here.

Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
Reviewed-by: Eric Dong <eric.dong@intel.com>
5 years agoMdeModulePkg/BMMUI: Update TerminalMenu and ConsoleMenu in callback
Dandan Bi [Tue, 11 Oct 2016 02:42:04 +0000 (10:42 +0800)]
MdeModulePkg/BMMUI: Update TerminalMenu and ConsoleMenu in callback

In current codes, When user does some change related to Console or Terminal,
when saving data, it will update the content in TerminalMenu and ConsoleMenu
in BootMaintRouteConfig function. This patch moves the update action to the
BootMaintCallback function with EFI_BROWSER_ACTION_CHANGED type.
The reason for this change is: in BootMaintRouteConfig function when
Var_UpdateConsoleXXXOption() return failure and user discard the previous
change, we should re_update the content in the TerminalMenu and ConsoleMenu.
So we move the update action to the changed callback.

Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
Reviewed-by: Eric Dong <eric.dong@intel.com>
5 years agoMdeModulePkg/SetupBrowser: Send discard info to driver when fail to submit
Dandan Bi [Tue, 6 Sep 2016 10:14:58 +0000 (18:14 +0800)]
MdeModulePkg/SetupBrowser: Send discard info to driver when fail to submit

When fail to submit data and user discard the change, we should send
the discard info to driver with EFI_BROWSER_ACTION_CHANGED callback.

Cc: Liming Gao <liming.gao@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
5 years agoArmPlatformPkg/ArmShellCmdRunAxf: Reference MdePkg protocol definition
Ruiyu Ni [Tue, 18 Oct 2016 06:32:34 +0000 (14:32 +0800)]
ArmPlatformPkg/ArmShellCmdRunAxf: Reference MdePkg protocol definition

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
5 years agoShellPkg: Update sources to include MdePkg protocol definitions
Ruiyu Ni [Tue, 18 Oct 2016 06:30:42 +0000 (14:30 +0800)]
ShellPkg: Update sources to include MdePkg protocol definitions

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
5 years agoEmbeddedPkg/FdtPlatformDxe: Reference Shell protocols in MdePkg
Ruiyu Ni [Fri, 14 Oct 2016 09:31:48 +0000 (17:31 +0800)]
EmbeddedPkg/FdtPlatformDxe: Reference Shell protocols in MdePkg

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
5 years agoArmPkg/LinuxLoader: Reference Shell protocols in MdePkg
Ruiyu Ni [Fri, 14 Oct 2016 09:23:41 +0000 (17:23 +0800)]
ArmPkg/LinuxLoader: Reference Shell protocols in MdePkg

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
5 years agoMdePkg: Merge ShellBase.h and remove Efi prefix from header files
Ruiyu Ni [Tue, 18 Oct 2016 08:37:30 +0000 (16:37 +0800)]
MdePkg: Merge ShellBase.h and remove Efi prefix from header files

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
5 years agoShellPkg: Update header files to reference MdePkg protocol definition
Ruiyu Ni [Tue, 18 Oct 2016 08:27:48 +0000 (16:27 +0800)]
ShellPkg: Update header files to reference MdePkg protocol definition

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
5 years agoMdePkg: Include Shell/ShellDynamicCommand/ShellParameters definitions
Ruiyu Ni [Tue, 18 Oct 2016 08:22:36 +0000 (16:22 +0800)]
MdePkg: Include Shell/ShellDynamicCommand/ShellParameters definitions

Move Shell/ShellDynamicCommand/ShellParameters definitions from
ShellPkg to MdePkg.

The following patches will rename the header file name.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
5 years agoShellPkg: Move SHELL_FREE_NON_NULL from ShellBase.h to ShellLib.h
Ruiyu Ni [Fri, 14 Oct 2016 07:59:53 +0000 (15:59 +0800)]
ShellPkg: Move SHELL_FREE_NON_NULL from ShellBase.h to ShellLib.h

The more proper place for macro SHELL_FREE_NON_NULL is ShellLib.h
instead of ShellBase.h.

Modify Compress.c to resolve build failure due to this change.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
5 years agoMdePkg UefiDevicePathLibDevicePathProtocol: Validate before use.
Eric Dong [Wed, 12 Oct 2016 12:34:05 +0000 (20:34 +0800)]
MdePkg UefiDevicePathLibDevicePathProtocol: Validate before use.

In IsDevicePathValid API, code should validate the device path
buffer not exceed the input MaxSize before reference the path
info.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
5 years agoMdePkg UefiDevicePathLib: Validate buffer length before use buffer.
Eric Dong [Wed, 12 Oct 2016 12:32:16 +0000 (20:32 +0800)]
MdePkg UefiDevicePathLib: Validate buffer length before use buffer.

In IsDevicePathValid API, code should validate the device path
buffer not exceed the input MaxSize before reference the path
info.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
5 years agoBaseTools: support PCD value to use expression in the DEC file
Yonghong Zhu [Wed, 12 Oct 2016 05:28:36 +0000 (13:28 +0800)]
BaseTools: support PCD value to use expression in the DEC file

This patch add the support for Pcd value to use expression in the DEC file.

Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
5 years agoBaseTools: Enhance tool to generate EFI_HII_IIBT_DUPLICATE image block
Yonghong Zhu [Mon, 17 Oct 2016 09:43:45 +0000 (17:43 +0800)]
BaseTools: Enhance tool to generate EFI_HII_IIBT_DUPLICATE image block

When *.IDF file contains multiple definitions of image which point to the
same image, current build tool generates multiple image blocks which
contain the same image content.
This patch enhance tool to generate EFI_HII_IIBT_DUPLICATE image blocks
for non-first images for such case, to save the HII package size.

Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=145
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
5 years agoShellPkg/Shell: fix CopyGuid() arg order in EfiShellGetGuidFromName()
Laszlo Ersek [Tue, 18 Oct 2016 10:53:48 +0000 (12:53 +0200)]
ShellPkg/Shell: fix CopyGuid() arg order in EfiShellGetGuidFromName()

The destination GUID comes first; from
"MdePkg/Include/Library/BaseMemoryLib.h":

> GUID *
> EFIAPI
> CopyGuid (
>   OUT GUID       *DestinationGuid,
>   IN CONST GUID  *SourceGuid
>   );

Here "NewGuid" is the GUID looked up by GetGuidFromStringName(), and
"Guid" is where EfiShellGetGuidFromName() has to propagate that result to.

Cc: Jaben Carsey <jaben.carsey@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Tim Lewis <tim.lewis@insyde.com>
Reported-by: Tim Lewis <tim.lewis@insyde.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Tim Lewis <tim.lewis@insyde.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
5 years agoMdePkg/BaseLib: Remove the unnecessary '_' before library APIs in ASM/NASM
Hao Wu [Mon, 17 Oct 2016 06:54:24 +0000 (14:54 +0800)]
MdePkg/BaseLib: Remove the unnecessary '_' before library APIs in ASM/NASM

The leading underscore (i.e. '_') before the names of some BaseLib library
API in ASM/NASM files is unnecessary. It will cause link error with GCC
tool chains.

Cc: Liming Gao <liming.gao@intel.com>
Cc: Michael Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hao Wu <hao.a.wu@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
5 years agoIntelSiliconPkg: Fixed bug in IgdOpregion spec
Giri P Mudusuru [Tue, 18 Oct 2016 03:10:16 +0000 (20:10 -0700)]
IntelSiliconPkg: Fixed bug in IgdOpregion spec

Spec documents Mailbox3 - RM31 size as 0x45(69) instead of 0x46(70)

Cc: Jiewen Yao <jiewen.yao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Giri P Mudusuru <giri.p.mudusuru@intel.com>
Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>
5 years agoMdeModulePkg FileExplorerLib: Fix potential Integer Overflow.
Liming Gao [Fri, 14 Oct 2016 06:49:54 +0000 (14:49 +0800)]
MdeModulePkg FileExplorerLib: Fix potential Integer Overflow.

In function 'LibAppendFileName' of 'FileExplorer.c':
"
MaxLen = (Size1 + Size2 + sizeof (CHAR16))/ sizeof (CHAR16);
"
Overflow may happen here. MaxLen might become a very small number.
This patch adds integer overflow checker.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Liming Gao <liming.gao@intel.com>
Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>
5 years agoMdePkg BaseSynchronizationLib InterlockedCompareExchange64: Fix ICC build
Liming Gao [Fri, 14 Oct 2016 06:47:33 +0000 (14:47 +0800)]
MdePkg BaseSynchronizationLib InterlockedCompareExchange64: Fix ICC build

Remove extra qword in nasm code to make it pass build.
This file is only built in INTEL ICC compiler. So, there is missing
build check for it.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Liming Gao <liming.gao@intel.com>
Reviewed-by: Jeff Fan <jeff.fan@intel.com>
5 years agoSecurityPkg: Fix typo 'Ihis' with 'This' in codes
Hao Wu [Mon, 17 Oct 2016 01:26:13 +0000 (09:26 +0800)]
SecurityPkg: Fix typo 'Ihis' with 'This' in codes

Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Chao Zhang <chao.b.zhang@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hao Wu <hao.a.wu@intel.com>
Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>
5 years agoMdePkg/TrEEProtocol.h: Fix typo 'Ihis' with 'This' in comment
Hao Wu [Mon, 17 Oct 2016 01:22:53 +0000 (09:22 +0800)]
MdePkg/TrEEProtocol.h: Fix typo 'Ihis' with 'This' in comment

Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Michael Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hao Wu <hao.a.wu@intel.com>
Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>
5 years agoUefiCpuPkg/Cpuid: Remove wrong while-loop check after for-loop
Jeff Fan [Fri, 14 Oct 2016 06:40:58 +0000 (14:40 +0800)]
UefiCpuPkg/Cpuid: Remove wrong while-loop check after for-loop

while-loop check should not co-exist with for-loop. This should be typo when we
check-in the original code. We should keep one loop only.

This issue caused CLANG38 build failure reported by
https://tianocore.acgmultimedia.com/show_bug.cgi?id=148

Contributed-under: TianoCore Contribution Agreement 1.0
Cc: Liming Gao <liming.gao@intel.com>
Cc: Michael Kinney <michael.d.kinney@intel.com>
Cc: Feng Tian <feng.tian@intel.com>
Signed-off-by: Jeff Fan <jeff.fan@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
5 years agoBaseTools: Update sign tool to make MonotonicCount *after* Payload
Yonghong Zhu [Thu, 13 Oct 2016 07:59:06 +0000 (15:59 +0800)]
BaseTools: Update sign tool to make MonotonicCount *after* Payload

The WIN_CERTIFICATE_UEFI_GUID AuthInfo defined in the UEFI spec
mentioned that It is a signature across the image data and the
Monotonic Count value. After clarification, we do the signature
calculation, we put MonotonicCount after Payload.

Cc: Liming Gao <liming.gao@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>
Tested-by: Jiewen Yao <jiewen.yao@intel.com>
5 years agoOvmfPkg/QemuVideoDxe: upgrade VERBOSE debug messages to INFO
Laszlo Ersek [Wed, 12 Oct 2016 08:50:18 +0000 (10:50 +0200)]
OvmfPkg/QemuVideoDxe: upgrade VERBOSE debug messages to INFO

In commit 5b2291f9567a ("OvmfPkg: QemuVideoDxe uses
MdeModulePkg/FrameBufferLib"), QemuVideoDxe was rebased to
FrameBufferBltLib.

The FrameBufferBltLib instance added in commit b1ca386074bd
("MdeModulePkg: Add FrameBufferBltLib library instance") logs many
messages on the VERBOSE level; for example, a normal boot with OVMF can
produce 500+ "VideoFill" messages, dependent on the progress bar, when the
VERBOSE bit is set in PcdDebugPrintErrorLevel. While FrameBufferBltLib is
certainly allowed to log such messages on the VERBOSE level, we should
separate those frequent messages from the (infrequent) ones produced by
QemuVideoDxe itself.

QemuVideoDxe logs VERBOSE messages in three locations (in two functions)
at the moment. All of them are infrequent: both QemuVideoBochsModeSetup()
and InstallVbeShim() are called from QemuVideoControllerDriverStart(),
that is, when a device is bound. Upgrade these messages to INFO level, so
that VERBOSE can be disabled in PcdDebugPrintErrorLevel -- perhaps
selectively for OvmfPkg/QemuVideoDxe -- without hiding these infrequent
messages.

Cc: Jordan Justen <jordan.l.justen@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
5 years agoOvmfPkg/QemuVideoDxe: remove useless QEMU_VIDEO_PRIVATE_DATA.LineBuffer
Laszlo Ersek [Wed, 12 Oct 2016 08:38:49 +0000 (10:38 +0200)]
OvmfPkg/QemuVideoDxe: remove useless QEMU_VIDEO_PRIVATE_DATA.LineBuffer

This field is (re)allocated in QemuVideoGraphicsOutputSetMode(), released
in QemuVideoGraphicsOutputDestructor(), and used for nothing else. Remove
it.

Cc: Jordan Justen <jordan.l.justen@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
5 years agoOvmfPkg/QemuVideoDxe: remove useless QEMU_VIDEO_PRIVATE_DATA.CurrentMode
Laszlo Ersek [Wed, 12 Oct 2016 08:28:09 +0000 (10:28 +0200)]
OvmfPkg/QemuVideoDxe: remove useless QEMU_VIDEO_PRIVATE_DATA.CurrentMode

This field is never used.

Cc: Jordan Justen <jordan.l.justen@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
5 years agoOvmfPkg/QemuVideoDxe: drop QEMU_VIDEO_CIRRUS_MODES.RefreshRate
Laszlo Ersek [Wed, 12 Oct 2016 08:09:52 +0000 (10:09 +0200)]
OvmfPkg/QemuVideoDxe: drop QEMU_VIDEO_CIRRUS_MODES.RefreshRate

Thanks to the previous patch, this field is also unnecessary now. Remove
it.

The patch is best reviewed with "git show --word-diff".

Cc: Jordan Justen <jordan.l.justen@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
5 years agoOvmfPkg/QemuVideoDxe: drop useless QEMU_VIDEO_MODE_DATA.RefreshRate
Laszlo Ersek [Wed, 12 Oct 2016 08:00:10 +0000 (10:00 +0200)]
OvmfPkg/QemuVideoDxe: drop useless QEMU_VIDEO_MODE_DATA.RefreshRate

This field is never used beyond assignment and debug-logging. Remove it.

Cc: Jordan Justen <jordan.l.justen@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
5 years agoArmVirtPkg: undo bogus component name and driver diagnostics disablement
Laszlo Ersek [Sat, 15 Oct 2016 15:39:44 +0000 (17:39 +0200)]
ArmVirtPkg: undo bogus component name and driver diagnostics disablement

The entry point function of any UEFI_DRIVER that conforms to the UEFI
driver model must install an instance of the EFI_DRIVER_BINDING_PROTOCOL
on the image handle. Beyond that, the following protocols are optional:

- EFI_COMPONENT_NAME_PROTOCOL
- EFI_COMPONENT_NAME2_PROTOCOL
- EFI_DRIVER_CONFIGURATION_PROTOCOL
- EFI_DRIVER_CONFIGURATION2_PROTOCOL
- EFI_DRIVER_DIAGNOSTICS_PROTOCOL
- EFI_DRIVER_DIAGNOSTICS2_PROTOCOL

The UefiLib functions

- EfiLibInstallAllDriverProtocols()
- EfiLibInstallAllDriverProtocols2()
- EfiLibInstallDriverBindingComponentName2()

are convenience helpers for such UEFI_DRIVERs. They simplify the
installation of the above protocols.

The UefiLib instance in "MdePkg/Library/UefiLib/UefiDriverModel.c" allows
platforms to control these functions through the MdePkg feature PCDs

- PcdComponentNameDisable
- PcdComponentName2Disable
- PcdDriverDiagnosticsDisable
- PcdDriverDiagnostics2Disable

If any of these PCDs are set to TRUE, then the helper functions will not
install the corresponding protocol interfaces on the image handle, even if
the driver passes in non-NULL protocol interfaces.

In other words, at build time, a platform can forcibly prevent all drivers
that employ UefiLib from producing these protocols.

In ArmVirtPkg, that's what we've been doing forever, for no reason at all.
This is why we haven't been seeing component and driver names from the DH,
DEVICES, DRIVERS and DEVTREE shell commands, unlike in OvmfPkg.

The default value for all these PCDs is FALSE, in "MdePkg/MdePkg.dec".
Revert ArmVirtPkg to the sane defaults.

This bug dates back to the inception of ArmVirtPkg (called
ArmPlatformPkg/ArmVirtualizationPkg at the time).

Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Fixes: 6f5872b1f4013f58c6d2f446d885edd6c8ea6d21
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
5 years agoIntelSiliconPkg: Add Intel Firmware Version Info (FVI) definitions
Giri P Mudusuru [Wed, 12 Oct 2016 05:13:56 +0000 (22:13 -0700)]
IntelSiliconPkg: Add Intel Firmware Version Info (FVI) definitions

Adding Intel Firmware Version Info (FVI) related defines & structures.
FVI enables reporting the Firmware Versions using SMBIOS OEM Type.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Giri P Mudusuru <giri.p.mudusuru@intel.com>
Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>
Reviewed-by: Star Zeng <star.zeng@intel.com>
5 years agoNetworkPkg: Record user configured TargetIP/Port in iBFT
Ye Ting [Thu, 29 Sep 2016 05:52:05 +0000 (13:52 +0800)]
NetworkPkg: Record user configured TargetIP/Port in iBFT

Current ISCSI driver records redirected iSCSI targetIP/Port in iBFT
once redirection occurs, which removes the possibility of the OS
to reconnect to the configured IP for load balancing. The behavior
is not explicitly described in IBFT spec, though the MSFT expert
confirm we should record original user setting rather than
publish the redirected IP.

Thanks Sriram for reviewing and validating this patch in his test-bed.

Cc: Subramanian Sriram <sriram-s@hpe.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Cc: Zhang Lubo <lubo.zhang@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ye Ting <ting.ye@intel.com>
Reviewed-by: Fu Siyuan <siyuan.fu@intel.com>
Reviewed-by: Subramanian Sriram <sriram-s@hpe.com>
5 years agoIntelFsp2Pkg/FspSecCore: Make FSP functions position independent
Maurice Ma [Thu, 13 Oct 2016 01:00:44 +0000 (18:00 -0700)]
IntelFsp2Pkg/FspSecCore: Make FSP functions position independent

The current AsmGetFspInfoHeader function in FspHeader.nasm is
position dependent code since it uses absolute address. Change
to use relative address instead to make it position independent.

Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Giri P Mudusuru <giri.p.mudusuru@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Maurice Ma <maurice.ma@intel.com>
Reviewed-by: Giri P Mudusuru <giri.p.mudusuru@intel.com>
5 years agoShellPkg/UefiShellTftpCommandLib: Update TFTP help text
Thomas Palmer [Wed, 12 Oct 2016 20:14:34 +0000 (13:14 -0700)]
ShellPkg/UefiShellTftpCommandLib: Update TFTP help text

Clear up some help text for the TFTP shell command

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Thomas Palmer <thomas.palmer@hpe.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
5 years agoBaseTools/GenFds: Support FDF sections in any order
Michael Kinney [Fri, 7 Oct 2016 21:07:03 +0000 (14:07 -0700)]
BaseTools/GenFds: Support FDF sections in any order

https://bugzilla.tianocore.org/show_bug.cgi?id=141

This patch updates EDK II FDF parser in GenFds to allow sections
to be placed in any order in the FDF file.

Cc: Kelly Steele <kelly.steele@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Michael Kinney <michael.d.kinney@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com>
5 years agoShellPkg:?cd \? command fails to go back to the root directory of a file system
Tapan Shah [Fri, 7 Oct 2016 20:59:34 +0000 (13:59 -0700)]
ShellPkg:?cd \? command fails to go back to the root directory of a file system

Allows cd command to go back to the root directory when 'cd \' executed in system.

This change prevents last PathRemoveLastItem() call which truncates '\' from 'fs0:\'
in desired root path which is required to set CWD to the root directory.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Tapan Shah <tapandshah@hpe.com>
Reviewed-by: Jaben Carsey <Jaben.carsey@intel.com>
5 years agoMdeModulePkg RegularExpressionDxe: Add the missing EFIAPI for the function
Liming Gao [Sun, 9 Oct 2016 02:20:30 +0000 (10:20 +0800)]
MdeModulePkg RegularExpressionDxe: Add the missing EFIAPI for the function

The function with the variable parameters should have EFIAPI.

Cc: Feng Tian <feng.tian@intel.com>
Cc: Cinnamon Shia <cinnamon.shia@hpe.com>
Cc: Cecil Sheng <cecil.sheng@hpe.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Liming Gao <liming.gao@intel.com>
Reviewed-by: Feng Tian <feng.tian@intel.com>
5 years agoDuetPkg DxeIpl and EfiLdr: Add the missing EFIAPI for the function
Liming Gao [Tue, 11 Oct 2016 01:44:07 +0000 (09:44 +0800)]
DuetPkg DxeIpl and EfiLdr: Add the missing EFIAPI for the function

The function with the variable parameters should have EFIAPI.

Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Liming Gao <liming.gao@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
5 years agoIntelSiliconPkg: Fixing syntax bug in IGD_OPREGION_HEADER
Giri P Mudusuru [Wed, 12 Oct 2016 04:58:46 +0000 (21:58 -0700)]
IntelSiliconPkg: Fixing syntax bug in IGD_OPREGION_HEADER

Added missing ; for DVER in IGD_OPREGION_HEADER

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Giri P Mudusuru <giri.p.mudusuru@intel.com>
Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>
5 years agoMdeModulePkg/MdeModulePkg.dec: Fix EBC build failure of PciBus driver
Ruiyu Ni [Tue, 11 Oct 2016 05:00:48 +0000 (13:00 +0800)]
MdeModulePkg/MdeModulePkg.dec: Fix EBC build failure of PciBus driver

When PciBus is built as EBC, PcdPciDegradeResourceForOptionRom does
not have associated value resulting build failure.
The patch sets the default value to TRUE, covering the EBC ARCH.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Acked-by: Laszlo Ersek <lersek@redhat.com>
Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Feng Tian <feng.tian@intel.com>
5 years agoNetworkPkg: Remove redundant code in HTTP boot driver.
Fu Siyuan [Tue, 13 Sep 2016 02:25:27 +0000 (10:25 +0800)]
NetworkPkg: Remove redundant code in HTTP boot driver.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Fu Siyuan <siyuan.fu@intel.com>
Reviewed-by: Sriram Subramanian <sriram-s@hpe.com>
Reviewed-by: Wu Jiaxin <jiaxin.wu@intel.com>
Reviewed-by: Zhang Lubo <lubo.zhang@intel.com>
5 years agoArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe: Fix for PCI Dual Address Cycle
Daniil Egranov [Thu, 22 Sep 2016 22:33:01 +0000 (17:33 -0500)]
ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe: Fix for PCI Dual Address Cycle

The fix handles the PCI Dual Address Cycle Attribute case. It allows
drivers using PCI DAC run on Juno.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Daniil Egranov <daniil.egranov@arm.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Tested-by: Ryan Harkin <ryan.harkin@linaro.org>
5 years agoOvmfPkg: add NOOPT build target for source level debugging
Bruce Cran [Mon, 10 Oct 2016 15:43:24 +0000 (09:43 -0600)]
OvmfPkg: add NOOPT build target for source level debugging

Contributed-under: TianoCore Contribution Agreement 1.0
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Bruce Cran <bruce.cran@sandisk.com>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
[lersek@redhat.com: beautify subject line]
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
5 years agoSecurityPkg OpalPasswordSmm: Fix S3 resume failure.
Eric Dong [Tue, 11 Oct 2016 08:00:21 +0000 (16:00 +0800)]
SecurityPkg OpalPasswordSmm: Fix S3 resume failure.

Changes includes:
1.Check SMM device list before update it to avoid duplicate creation.
2.Clean up the configuration buffer before use it in S3 resume phase.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Feng Tian <feng.tian@intel.com>
5 years agoBaseTools: Extend FMP to support FV statement and FD statement
Yonghong Zhu [Sun, 9 Oct 2016 01:30:06 +0000 (09:30 +0800)]
BaseTools: Extend FMP to support FV statement and FD statement

This patch extend the <FmpFileData> to support <FvStatements> and
<FdStatenents>, just like the normal [Capsule] section format.
In order to fix the bug https://bugzilla.tianocore.org/show_bug.cgi?id=132

Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
5 years agoArmVirtPkg: Remove unused BltLib reference
Ruiyu Ni [Tue, 11 Oct 2016 05:43:28 +0000 (13:43 +0800)]
ArmVirtPkg: Remove unused BltLib reference

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Reviewed-by: Laszlo Ersek <lersek at redhat.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
5 years agoOvmfPkg: Remove unused BltLib reference
Ruiyu Ni [Tue, 11 Oct 2016 05:42:24 +0000 (13:42 +0800)]
OvmfPkg: Remove unused BltLib reference

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Reviewed-by: Laszlo Ersek <lersek at redhat.com>
5 years agoOvmfPkg: QemuVideoDxe uses MdeModulePkg/FrameBufferLib
Ruiyu Ni [Tue, 11 Oct 2016 05:26:27 +0000 (13:26 +0800)]
OvmfPkg: QemuVideoDxe uses MdeModulePkg/FrameBufferLib

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Reviewed-by: Laszlo Ersek <lersek at redhat.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
5 years agoArmVirtPkg: Include MdeModulePkg/FrameBufferLib in ArmVirtPkg
Ruiyu Ni [Tue, 11 Oct 2016 05:24:23 +0000 (13:24 +0800)]
ArmVirtPkg: Include MdeModulePkg/FrameBufferLib in ArmVirtPkg

One of the following patches will change QemuVideoDxe driver
to use the new FrameBufferLib.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Reviewed-by: Laszlo Ersek <lersek at redhat.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
5 years agoOvmfPkg: Include MdeModulePkg/FrameBufferLib in OvmfPkg
Ruiyu Ni [Mon, 27 Jun 2016 09:28:54 +0000 (17:28 +0800)]
OvmfPkg: Include MdeModulePkg/FrameBufferLib in OvmfPkg

One of the following patches will change QemuVideoDxe driver
to use the new FrameBufferLib.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Reviewed-by: Laszlo Ersek <lersek at redhat.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
5 years agoMdeModulePkg: Add GraphicsOutputDxe driver.
Ruiyu Ni [Thu, 30 Jun 2016 05:01:56 +0000 (13:01 +0800)]
MdeModulePkg: Add GraphicsOutputDxe driver.

The driver uses the GraphicsInfo HOB and GraphicsDeviceInfo HOB
passed from PEI to find the graphics controller to manage and
produce the GraphicsOutput protocol.

GraphicsInfo HOB and GraphicsDeviceInfo HOB are created by
a PEIM which initializes the graphics controller hardware in
PEI phase.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Reviewed-by: Feng Tian <feng.tian@intel.com>
5 years agoMdeModulePkg: Add FrameBufferBltLib library instance
Ruiyu Ni [Thu, 7 Jul 2016 05:31:27 +0000 (13:31 +0800)]
MdeModulePkg: Add FrameBufferBltLib library instance

This library provides interfaces to perform UEFI Graphics
Output Protocol Video BLT operations.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Reviewed-by: Feng Tian <feng.tian@intel.com>
Cc: Justen Jordan <jordan.l.justen@intel.com>
Tested-by: Laszlo Ersek <lersek at redhat.com>
5 years agoMdeModulePkg: Add FrameBufferBltLib library class
Ruiyu Ni [Thu, 30 Jun 2016 02:59:42 +0000 (10:59 +0800)]
MdeModulePkg: Add FrameBufferBltLib library class

This library provides interfaces to perform UEFI Graphics
Output Protocol Video BLT operations.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Reviewed-by: Feng Tian <feng.tian@intel.com>
Cc: Justen Jordan <jordan.l.justen@intel.com>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
5 years agoMdePkg/GraphicsInfoHob: Add GraphicsDeviceInfo HOB GUID and structure
Ruiyu Ni [Wed, 29 Jun 2016 01:53:27 +0000 (09:53 +0800)]
MdePkg/GraphicsInfoHob: Add GraphicsDeviceInfo HOB GUID and structure

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
5 years agoFatPkg/FatPei: Use PcdRecoveryFileName PCD.
Jiewen Yao [Sat, 8 Oct 2016 01:55:59 +0000 (09:55 +0800)]
FatPkg/FatPei: Use PcdRecoveryFileName PCD.

This PCD is used to indicated the recovery file name.
The previous name - FvMain.Fv is hardcoded in FatPei.
It does not make sense to force the name.

Now a platform may use any recovery file name.

Tested-by: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Feng Tian <feng.tian@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jiewen Yao <jiewen.yao@intel.com>
Reviewed-by: Feng Tian <feng.tian@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
5 years agoMdeModulePkg/CdExpressPei: Use PcdRecoveryFileName PCD.
Jiewen Yao [Sat, 8 Oct 2016 01:55:20 +0000 (09:55 +0800)]
MdeModulePkg/CdExpressPei: Use PcdRecoveryFileName PCD.

This PCD is used to indicated the recovery file name.
The previous name - FvMain.Fv is hardcoded in CdExpressPei.
It does not make sense to force the name.

Now a platform may use any recovery file name.

Cc: Feng Tian <feng.tian@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jiewen Yao <jiewen.yao@intel.com>
Reviewed-by: Feng Tian <feng.tian@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
5 years agoMdeModulePkg/dec: Add PcdRecoveryFileName PCD.
Jiewen Yao [Sat, 8 Oct 2016 01:54:33 +0000 (09:54 +0800)]
MdeModulePkg/dec: Add PcdRecoveryFileName PCD.

This PCD is used to indicated the recovery file name.
The previous name - FvMain.Fv is hardcoded in FatPei and CdExpressPei.
It does not make sense to force the name.

Now a platform may use any recovery file name.

Tested-by: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Feng Tian <feng.tian@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jiewen Yao <jiewen.yao@intel.com>
Reviewed-by: Feng Tian <feng.tian@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
5 years agoBaseTools: support the NOOPT target with the GCC tool chains
Yonghong Zhu [Fri, 30 Sep 2016 07:30:59 +0000 (15:30 +0800)]
BaseTools: support the NOOPT target with the GCC tool chains

Update the tools_def.template to add NOOPT support with GCC tool chains.
Also disable -flto and -Os in NOOPT target for GCC5.

Cc: Liming Gao <liming.gao@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Tested-by: Bruce Cran <bruce.cran@sandisk.com>
5 years agoArmPlatformPkg: Remove UINTN cast when setting BaudRate.
Alexei [Wed, 21 Sep 2016 20:33:15 +0000 (21:33 +0100)]
ArmPlatformPkg: Remove UINTN cast when setting BaudRate.

SerialPortInitialize() set the BaudRate variable (type UINT64) as:
BaudRate = (UINTN)FixedPcdGet64 (PcdUartDefaultBaudRate);

This commit fixes a potential problem on ARM 32-bit builds, where the
UINTN type is defined as UINT32, by removing the cast:

BaudRate = FixedPcdGet64 (PcdUartDefaultBaudRate);

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Alexei Fedorov <alexei.fedorov@arm.com>
Signed-off-by: Evan Lloyd <evan.lloyd@arm.com>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
5 years agoArmPlatformPkg: Correct mendacious comments.
Alexei [Wed, 21 Sep 2016 20:33:14 +0000 (21:33 +0100)]
ArmPlatformPkg: Correct mendacious comments.

Correct some obviously incorrect comments that have invalid details for
the returned values.  (Copy /Paste problem?)
There are no functional changes in this commit.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Alexei Fedorov <alexei.fedorov@arm.com>
Signed-off-by: Evan Lloyd <evan.lloyd@arm.com>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
5 years agoArmPlatformPkg: Fix PL011 FIFO size test
Evan Lloyd [Wed, 21 Sep 2016 20:33:13 +0000 (21:33 +0100)]
ArmPlatformPkg: Fix PL011 FIFO size test

This change updates PL011UartInitializePort to compare ReceiveFifoDepth
with the correct hardware FIFO size instead of the constant 32 used
previously.
This corrects a minor bug where a request for a fifo size > 15 and < 32
would not have been honoured on a system with a 16 byte FIFO.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
Signed-off-by: Evan Lloyd <evan.lloyd@arm.com>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
5 years agoPcAtChipsetPkg AcpiTimerLib: Clear bits [31:24] after reading by IoRead32()
Star Zeng [Wed, 28 Sep 2016 10:17:55 +0000 (18:17 +0800)]
PcAtChipsetPkg AcpiTimerLib: Clear bits [31:24] after reading by IoRead32()

Clear bits [31:24] after reading ACPI timer count by IoRead32(), and also add
comments "Note: The implementation uses the lower 24-bits of the ACPI timer
and is compatible with both 24-bit and 32-bit ACPI timers." in INF.

Cc: Michael Kinney <michael.d.kinney@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: Michael Kinney <michael.d.kinney@intel.com>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
5 years agoNt32Pkg WinNtSimpleFileSystemDxe: Correct file length.
Dong, Eric [Mon, 10 Oct 2016 08:36:18 +0000 (16:36 +0800)]
Nt32Pkg WinNtSimpleFileSystemDxe: Correct file length.

In GetInfo interface, current code copy real file name buffer
with full path file length. It should use real file name
length. This patch fix this error.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
5 years agoSecurityPkg: SmmTcg2PhysicalPresenceLib: Fix GCC build failure
Zhang, Chao B [Mon, 10 Oct 2016 08:42:01 +0000 (16:42 +0800)]
SecurityPkg: SmmTcg2PhysicalPresenceLib: Fix GCC build failure

GCC is case sensitive. Also add BaseMemoryLib in INF.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chao Zhang <chao.b.zhang@intel.com>
Reviewed-by: Gao Liming <liming.gao@intel.com>
Reviewed-by: Long Qin <qin.long@intel.com>
5 years agoNt32Pkg/PlatformBootManagerLib: Signal the End of DXE Event
Cinnamon Shia [Mon, 3 Oct 2016 09:28:30 +0000 (17:28 +0800)]
Nt32Pkg/PlatformBootManagerLib: Signal the End of DXE Event

From PI spec vol2:
Prior to invoking any UEFI drivers, applications, or connecting consoles,
the platform should signal the event EFI_END_OF_DXE_EVENT_GUID

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Cinnamon Shia <cinnamon.shia@hpe.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
5 years agoMdePkg:Correct the comment for the DEBUG_NET.
Zhang Lubo [Fri, 23 Sep 2016 04:08:46 +0000 (12:08 +0800)]
MdePkg:Correct the comment for the DEBUG_NET.

Generalize the comment for the DEBUG_NET
#define DEBUG_NET  0x00004000  // SNP Driver
to Network IO Driver.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo <lubo.zhang@intel.com>
Cc: Hegde Nagaraj P <nagaraj-p.hegde@hpe.com>
Cc: Subramanian Sriram <sriram-s@hpe.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Cc: Ye Ting <ting.ye@intel.com>
Reviewed-by: Sriram Subramanian <sriram-s@hpe.com>
5 years agoMdeModulePkg:TcpDriver need to use EFI_D_NET for DEBUG maessage.
Zhang Lubo [Fri, 23 Sep 2016 04:01:28 +0000 (12:01 +0800)]
MdeModulePkg:TcpDriver need to use EFI_D_NET for DEBUG maessage.

Tcp driver need to use EFI_D_NET to log DEBUG message,
So it becomes easy to separate/filter out debug messages
from network stack versus generic EFI_D_INFO debugs.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo <lubo.zhang@intel.com>
Cc: Hegde Nagaraj P <nagaraj-p.hegde@hpe.com>
Cc: Subramanian Sriram <sriram-s@hpe.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Cc: Ye Ting <ting.ye@intel.com>
Reviewed-by: Sriram Subramanian <sriram-s@hpe.com>
5 years agoNetworkPkg: TcpDriver use EFI_D_NET for DEBUG maessage.
Zhang Lubo [Fri, 23 Sep 2016 03:55:01 +0000 (11:55 +0800)]
NetworkPkg: TcpDriver use EFI_D_NET for DEBUG maessage.

Tcp driver need to use EFI_D_NET to log DEBUG message,
So it becomes easy to separate/filter out debug messages
from network stack versus generic EFI_D_INFO debugs.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo <lubo.zhang@intel.com>
Cc: Hegde Nagaraj P <nagaraj-p.hegde@hpe.com>
Cc: Subramanian Sriram <sriram-s@hpe.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Cc: Ye Ting <ting.ye@intel.com>
Reviewed-by: Sriram Subramanian <sriram-s@hpe.com>
5 years agoOptionRomPkg: Fix GCC build failure
Bi, Dandan [Thu, 22 Sep 2016 02:51:10 +0000 (10:51 +0800)]
OptionRomPkg: Fix GCC build failure

Remove the variable which is set but not used to pass GCC build.

Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
5 years agoShellPkg/UefiShellNetwork1CommandsLib: Remove unnecessary EFIAPI
Chen A Chen [Thu, 29 Sep 2016 06:55:26 +0000 (14:55 +0800)]
ShellPkg/UefiShellNetwork1CommandsLib: Remove unnecessary EFIAPI

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chen A Chen <chen.a.chen@intel.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Ruiyu Ni <Ruiyu.ni@intel.com>
5 years agoShellPkg/UefiShellLib: Remove unnecessary EFIAPI
Chen A Chen [Thu, 29 Sep 2016 06:54:40 +0000 (14:54 +0800)]
ShellPkg/UefiShellLib: Remove unnecessary EFIAPI

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chen A Chen <chen.a.chen@intel.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Ruiyu Ni <Ruiyu.ni@intel.com>
5 years agoShellPkg/UefiShellCommandLib: Remove unnecessary EFIAPI
Chen A Chen [Thu, 29 Sep 2016 06:53:47 +0000 (14:53 +0800)]
ShellPkg/UefiShellCommandLib: Remove unnecessary EFIAPI

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chen A Chen <chen.a.chen@intel.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Ruiyu Ni <Ruiyu.ni@intel.com>
5 years agoShellPkg/UefiShellBcfgCommandLib: Remove unnecessary EFIAPI
Chen A Chen [Thu, 29 Sep 2016 06:51:57 +0000 (14:51 +0800)]
ShellPkg/UefiShellBcfgCommandLib: Remove unnecessary EFIAPI

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chen A Chen <chen.a.chen@intel.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Ruiyu Ni <Ruiyu.ni@intel.com>