mirror_edk2.git
6 years agoFatBinPkg: Update EBC/IA32/X64/IPF binaries
Ruiyu Ni [Fri, 28 Aug 2015 03:14:25 +0000 (03:14 +0000)]
FatBinPkg: Update EBC/IA32/X64/IPF binaries

Based on MdePkg and BaseTools (r18341), FatPkg (r96)

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18347 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoMdePkg: Refine the device path text format for Bluetooth to follow spec.
Qiu Shumin [Fri, 28 Aug 2015 02:59:20 +0000 (02:59 +0000)]
MdePkg: Refine the device path text format for Bluetooth to follow spec.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin <shumin.qiu@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18346 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoFatBinPkg: Update EBC/IA32/X64/IPF binaries
Ruiyu Ni [Fri, 28 Aug 2015 02:57:09 +0000 (02:57 +0000)]
FatBinPkg: Update EBC/IA32/X64/IPF binaries

Based on MdePkg and BaseTools (r18341), FatPkg (r96)

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18345 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoSecurityPkg: Use safe string function.
Qiu Shumin [Fri, 28 Aug 2015 02:51:50 +0000 (02:51 +0000)]
SecurityPkg: Use safe string function.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin <shumin.qiu@intel.com>
Reviewed-by: Yao Jiewen <Jiewen.Yao@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18344 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoIntelFrameworkModulePkg: Ad the missing module UNI files.
Liming Gao [Fri, 28 Aug 2015 02:47:31 +0000 (02:47 +0000)]
IntelFrameworkModulePkg: Ad the missing module UNI files.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Liming Gao <liming.gao@intel.com>
Reviewed-by: Jeff Fan <jeff.fan@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18343 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoMdeModulePkg: Add the missing module UNI files.
Liming Gao [Fri, 28 Aug 2015 02:46:46 +0000 (02:46 +0000)]
MdeModulePkg: Add the missing module UNI files.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Liming Gao <liming.gao@intel.com>
Reviewed-by: Feng Tian <feng.tian@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18342 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoMdePkg: Change the EFI_ACPI_PNP_HID_END to EFI_PNP_ID (0x0000)
Ruiyu Ni [Fri, 28 Aug 2015 02:46:22 +0000 (02:46 +0000)]
MdePkg: Change the EFI_ACPI_PNP_HID_END to EFI_PNP_ID (0x0000)

The current value doesn't follow the PI 1.4 spec.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18341 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoMdePkg: Add the missing module UNI files
Liming Gao [Fri, 28 Aug 2015 02:45:50 +0000 (02:45 +0000)]
MdePkg: Add the missing module UNI files

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Liming Gao <liming.gao@intel.com>
Reviewed-by: Qiu Shumin <shumin.qiu@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18340 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoBaseTools: Fixed bug for single FV generating.
Yingke Liu [Fri, 28 Aug 2015 02:04:37 +0000 (02:04 +0000)]
BaseTools: Fixed bug for single FV generating.

If -i is specified and this FV has no BlockSize defined,
tool did not inherit FD's BlockSize.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Yingke Liu <yingke.d.liu@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18339 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoNetworkPkg: Add Dns and HttpUtilities driver UNI files
Jiaxin Wu [Fri, 28 Aug 2015 01:31:38 +0000 (01:31 +0000)]
NetworkPkg: Add Dns and HttpUtilities driver UNI files

This patch is used to add Dns and HttpUtilities driver UNI files.

Cc: Ye Ting <ting.ye@intel.com>
Cc: Siyuan Fu <siyuan.fu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jiaxin Wu <jiaxin.wu@intel.com>
Reviewed-by: Fu Siyuan <siyuan.fu@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18338 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoMdeModulePkg:Set default string value
Dandan Bi [Thu, 27 Aug 2015 08:35:19 +0000 (08:35 +0000)]
MdeModulePkg:Set default string value

Previously construct Default Value in AltResp for string opcode is String Id,
Now change it to string value if the string opcode has default value.
This change is compatible for SetupBrowser to handle.And add default value
for string in DriverSample to test this case.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18337 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoBaseTools:To generate string default type correctly in VfrCompiler
Dandan Bi [Thu, 27 Aug 2015 08:19:40 +0000 (08:19 +0000)]
BaseTools:To generate string default type correctly in VfrCompiler

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18336 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoSecurityPkg: Refine the local variable name to follow EDK2 coding style.
Qiu Shumin [Thu, 27 Aug 2015 05:27:51 +0000 (05:27 +0000)]
SecurityPkg: Refine the local variable name to follow EDK2 coding style.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin <shumin.qiu@intel.com>
Reviewed-by: Yao Jiewen <Jiewen.Yao@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18335 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoSecurityPkg: Add missing Lib definition in DEC file.
Qiu Shumin [Thu, 27 Aug 2015 05:26:24 +0000 (05:26 +0000)]
SecurityPkg: Add missing Lib definition in DEC file.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin <shumin.qiu@intel.com>
Reviewed-by: Yao Jiewen <Jiewen.Yao@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18334 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoSecurityPkg: Add missing PCD usage information.
Qiu Shumin [Thu, 27 Aug 2015 05:23:46 +0000 (05:23 +0000)]
SecurityPkg: Add missing PCD usage information.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin <shumin.qiu@intel.com>
Reviewed-by: Chao Zhang <chao.b.zhang@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18333 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoMdeModulePkg: Replace deprecated function.
Eric Dong [Thu, 27 Aug 2015 04:52:24 +0000 (04:52 +0000)]
MdeModulePkg: Replace deprecated function.

Replace GetEfiGlobalVariable with GetEfiGlobalVariable2.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18332 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoIntelFrameworkModulePkg: Replace deprecated function.
Eric Dong [Thu, 27 Aug 2015 04:51:27 +0000 (04:51 +0000)]
IntelFrameworkModulePkg: Replace deprecated function.

Replace GetEfiGlobalVariable with GetEfiGlobalVariable2.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18331 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoShellPkg: Replace use case of deprecated function GetVariable with GetVariable2.
Eric Dong [Thu, 27 Aug 2015 04:45:23 +0000 (04:45 +0000)]
ShellPkg: Replace use case of deprecated function GetVariable with GetVariable2.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18330 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoSourceLevelDebugPkg/DebugTimer: Timer count value 0 not calculated
Jeff Fan [Thu, 27 Aug 2015 02:08:56 +0000 (02:08 +0000)]
SourceLevelDebugPkg/DebugTimer: Timer count value 0 not calculated

Actually, TimerCycle is APIC timer's initial count. Timer count value 0 is
missed when calculating Delta value.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jeff Fan <jeff.fan@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18329 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoSourceLevelDebugPkg/DebugTimer: Fix the issue if CurrentTimer = Timer
Jeff Fan [Thu, 27 Aug 2015 02:05:20 +0000 (02:05 +0000)]
SourceLevelDebugPkg/DebugTimer: Fix the issue if CurrentTimer = Timer

If CPU runs fast and timer runs slow, two GetApicTimerCurrentCount() may return
the same timer count value. We need to consider timer roll-over not happened.
Otherwise, one false timeout flag will be set.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jeff Fan <jeff.fan@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18328 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoShellPkg: Fix the ASSERT issue in drvcfg command.
Qiu Shumin [Thu, 27 Aug 2015 01:23:55 +0000 (01:23 +0000)]
ShellPkg: Fix the ASSERT issue in drvcfg command.

Initialize the local pointer to avoid to free a dangling pointer.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin <shumin.qiu@intel.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18327 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoNetworkPkg: Convert the UNIX to DOS end of line format
Jiaxin Wu [Thu, 27 Aug 2015 01:07:31 +0000 (01:07 +0000)]
NetworkPkg: Convert the UNIX to DOS end of line format

Convert the UNIX to DOS end of line format.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jiaxin Wu <jiaxin.wu@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18326 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoMdePkg: Convert the UNIX to DOS end of line format
Jiaxin Wu [Thu, 27 Aug 2015 01:05:39 +0000 (01:05 +0000)]
MdePkg: Convert the UNIX to DOS end of line format

Convert the UNIX to DOS end of line format.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jiaxin Wu <jiaxin.wu@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18325 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoMdeModulePkg: Convert the UNIX to DOS end of line format
Jiaxin Wu [Thu, 27 Aug 2015 01:04:59 +0000 (01:04 +0000)]
MdeModulePkg: Convert the UNIX to DOS end of line format

Convert the UNIX to DOS end of line format.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jiaxin Wu <jiaxin.wu@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18324 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoMdeModulePkg: Fix mixed Dos and Linux end of line format issue.
Eric Dong [Thu, 27 Aug 2015 01:01:14 +0000 (01:01 +0000)]
MdeModulePkg: Fix mixed Dos and Linux end of line format issue.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eric Dong <eric.dong@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18323 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoIntelFrameworkModulePkg: Fix mixed Dos and Linux end of line format issue.
Eric Dong [Thu, 27 Aug 2015 01:00:37 +0000 (01:00 +0000)]
IntelFrameworkModulePkg: Fix mixed Dos and Linux end of line format issue.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eric Dong <eric.dong@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18322 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoArmVirtPkg: revert unintended change to ArmVirt.dsc.inc
Ard Biesheuvel [Wed, 26 Aug 2015 12:09:39 +0000 (12:09 +0000)]
ArmVirtPkg: revert unintended change to ArmVirt.dsc.inc

The recent changes to ArmVExpress-FVP-AArch64 in SVN r18309
contained a hunk to ArmVirt.dsc.inc which was included in
error. So remove it.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18321 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoMdeModulePkg FaultTolerantWrite: Error handling for erase operation failure
Star Zeng [Wed, 26 Aug 2015 09:46:29 +0000 (09:46 +0000)]
MdeModulePkg FaultTolerantWrite: Error handling for erase operation failure

There may be anti-flash wear out feature to forbid erase operation after end of dxe.
The code is missing some error handling for erase operation failure,
it should return directly after the erase operation failed.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18320 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoIntelFrameworkModulePkg/BiosThunk: Fix 32 bits arch build failure when disable optimi...
eric Dong [Wed, 26 Aug 2015 08:31:27 +0000 (08:31 +0000)]
IntelFrameworkModulePkg/BiosThunk: Fix 32 bits arch build failure when disable optimization.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: eric Dong <eric.dong@intel.com>
Reviewed-by: Feng Tian <feng.tian@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18319 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoBaseTools: Fix the missing depex file in GenFds
Liming Gao [Wed, 26 Aug 2015 06:33:31 +0000 (06:33 +0000)]
BaseTools: Fix the missing depex file in GenFds

If FDF FfsRule describes |.depex for depex file on source build, it may
be missed in the generated FD image. GenFds tool needs to check the
output file list and find the matched one.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Liming Gao <liming.gao@intel.com>
Reviewed-by: Yingke Liu <yingke.d.liu@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18318 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoBaseTools: Nested !include support in DSC and FDF files
Cecil Sheng [Wed, 26 Aug 2015 06:28:59 +0000 (06:28 +0000)]
BaseTools: Nested !include support in DSC and FDF files

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Cecil Sheng <cecil.sheng@hp.com>
Reviewed-by: Samer El-Haj-Mahmoud <elhaj@hp.com>
Reviewed-by: Yingke Liu <yingke.d.liu@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18317 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoNetworkPkg: Update HttpDxe driver to consume EFI_HTTP_UTILITIES_PROTOCOL
Jiaxin Wu [Wed, 26 Aug 2015 06:19:53 +0000 (06:19 +0000)]
NetworkPkg: Update HttpDxe driver to consume EFI_HTTP_UTILITIES_PROTOCOL

v2:
* Register a notification function to be executed for Http utilities protocol
in the drivers entry points.

Since we add EFI_HTTP_UTILITIES_PROTOCOL support, HttpDxe driver should
be updated to remove internal http utilities functions and consume this
protocol directly.

Cc: Ye Ting <ting.ye@intel.com>
Cc: Siyuan Fu <siyuan.fu@intel.com>
Cc: Samer El-Haj-Mahmoud <elhaj@hp.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jiaxin Wu <jiaxin.wu@intel.com>
Reviewed-by: Fu Siyuan <siyuan.fu@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18316 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoNetworkPkg: Update the DnsDhcp.c to use BSD license
Jiaxin Wu [Wed, 26 Aug 2015 06:19:19 +0000 (06:19 +0000)]
NetworkPkg: Update the DnsDhcp.c to use BSD license

This patch is used to update the DnsDhcp.c to use BSD license.

Cc: Ye Ting <ting.ye@intel.com>
Cc: Siyuan Fu <siyuan.fu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jiaxin Wu <jiaxin.wu@intel.com>
Reviewed-by: Fu Siyuan <siyuan.fu@intel.com>
Reviewed-by: Ye Ting <ting.ye@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18315 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoMdePkg: Make the FileHandleGetFileName return the file name in right format.
Qiu Shumin [Wed, 26 Aug 2015 02:25:42 +0000 (02:25 +0000)]
MdePkg: Make the FileHandleGetFileName return the file name in right format.

1. If the file is not a directory remove the redundant '\' char in file name string returned from UefiFileHandleLib.FileHandleGetFileName.
2. Update function comments.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin <shumin.qiu@intel.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18314 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoMdeModulePkg/Xhci: Remove TDs from transfer ring when timeout happens
Feng Tian [Wed, 26 Aug 2015 01:19:09 +0000 (01:19 +0000)]
MdeModulePkg/Xhci: Remove TDs from transfer ring when timeout happens

The error handling for timeout case is enhanced to remove TDs from
transfer ring. The original code only removed s/w URB, but the h/w
transfer descriptor TDs didn't get removed. It would cause data lost
for data stream peripheral, such as usb-to-serial device, from the
s/w perspective.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Feng Tian <feng.tian@intel.com>
Reviewed-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: Baraneedharan Anbazhagan <anbazhagan@hp.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18313 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoMdeModulePkg PiSmmCore: Prevent overlap for gSmmCorePrivate and CommBuffer
Star Zeng [Wed, 26 Aug 2015 01:10:39 +0000 (01:10 +0000)]
MdeModulePkg PiSmmCore: Prevent overlap for gSmmCorePrivate and CommBuffer

InternalIsBufferOverlapped() is created to check overlap between buffers.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18312 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoSecurityPkg: Fix one returned code issue in P7Verify Protocol
Qin Long [Wed, 26 Aug 2015 00:59:17 +0000 (00:59 +0000)]
SecurityPkg: Fix one returned code issue in P7Verify Protocol

VerifyBuffer() in PKCS7 Verify Protocol should return EFI_UNSUPPORTED
when the embedded content is found in SignedData but InData is not NULL.
This patch is to comply with the spec definition.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qin Long <qin.long@intel.com>
Reviewed-by: Chao Zhang <chao.b.zhang@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18311 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoShellPkg: use UEFI_APPLICATION module type for Shell components
Ard Biesheuvel [Tue, 25 Aug 2015 14:54:36 +0000 (14:54 +0000)]
ShellPkg: use UEFI_APPLICATION module type for Shell components

Some of the libraries under ShellPkg/Library/ are only intended to be
loaded into the Shell by means of a NULL LibraryClass resolution, and
serve no other purpose. Since the Shell itself is a UEFI_APPLICATION, it
makes sense to set the module type of those libraries to UEFI_APPLICATION
as well.

This allows us to use different compiler flags for the Shell application
itself but also for the majority of its constituent parts that are built
separately via these libraries.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18310 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoArmPlatformPkg/FVP: unify support for Foundation and Base models
Ard Biesheuvel [Tue, 25 Aug 2015 13:11:25 +0000 (13:11 +0000)]
ArmPlatformPkg/FVP: unify support for Foundation and Base models

Now that the PL180 and PL111 drivers know how to behave when executed
on the Foundation model (which does not emulate the hardware), we can
remove the ARM_FOUNDATION_FVP ifdefs and produce a single build that
runs on both the Foundation model and the Base model.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18309 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoArmPlatformPkg/LcdGraphicsOutputDxe: check PrimeCell ID before initializing
Ard Biesheuvel [Tue, 25 Aug 2015 13:11:11 +0000 (13:11 +0000)]
ArmPlatformPkg/LcdGraphicsOutputDxe: check PrimeCell ID before initializing

To deal gracefully with the absence of the PL111 hardware on
the Foundation model, check the PrimeCell ID before proceeding
with the installation.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18308 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoArmPlatformPkg/PL180MciDxe: check PrimeCell ID before initializing
Ard Biesheuvel [Tue, 25 Aug 2015 13:11:02 +0000 (13:11 +0000)]
ArmPlatformPkg/PL180MciDxe: check PrimeCell ID before initializing

To deal gracefully with the absence of the PL180 hardware on
the Foundation model, check the PrimeCell ID before proceeding
with the installation.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18307 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoNt32Pkg: Keep boot behavior using new BDS almost same as that using old BDS
Ruiyu Ni [Tue, 25 Aug 2015 09:51:07 +0000 (09:51 +0000)]
Nt32Pkg: Keep boot behavior using new BDS almost same as that using old BDS

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18306 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoMdeModulePkg PeiCore: Recheck SwitchStackSignal after ProcessNotifyList()
Star Zeng [Tue, 25 Aug 2015 07:05:48 +0000 (07:05 +0000)]
MdeModulePkg PeiCore: Recheck SwitchStackSignal after ProcessNotifyList()

in case PeiInstallPeiMemory() is done in a callback with
EFI_PEI_PPI_DESCRIPTOR_NOTIFY_DISPATCH, and the callback is registered on
a PPI that is installed in the last PEIM.

At the case, PeiCore SwitchStack code will be not being invoked.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18305 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoMdeModulePkg SmmLegacyBoot.h: Add a "," after copyright year
Star Zeng [Tue, 25 Aug 2015 06:29:33 +0000 (06:29 +0000)]
MdeModulePkg SmmLegacyBoot.h: Add a "," after copyright year

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18299 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoMdeModulePkg: Fix UefiBootManagerLib.inf license header.
Ruiyu Ni [Tue, 25 Aug 2015 06:27:01 +0000 (06:27 +0000)]
MdeModulePkg: Fix UefiBootManagerLib.inf license header.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18298 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoMdeModulePkg: Add PlatformVarCleanupLib library
Star Zeng [Tue, 25 Aug 2015 03:11:06 +0000 (03:11 +0000)]
MdeModulePkg: Add PlatformVarCleanupLib library

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18295 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoMdeModulePkg: Add VarCheckPcdLib NULL class library
Star Zeng [Tue, 25 Aug 2015 03:10:32 +0000 (03:10 +0000)]
MdeModulePkg: Add VarCheckPcdLib NULL class library

The check will be based on PcdVarCheck binary that generated
by BaseTools.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18294 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoMdeModulePkg: Add VarCheckHiiLib NULL class library
Star Zeng [Tue, 25 Aug 2015 03:10:04 +0000 (03:10 +0000)]
MdeModulePkg: Add VarCheckHiiLib NULL class library

The check will be based on VarCheckHiiBin that generated
from FV and Hii Database.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18293 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoVlv2TbltDevicePkg: Link separated VarCheckUefiLib NULL class library instance
Star Zeng [Tue, 25 Aug 2015 03:04:18 +0000 (03:04 +0000)]
Vlv2TbltDevicePkg: Link separated VarCheckUefiLib NULL class library instance

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: David Wei <david.wei@intel.com>
Reviewed-by: Tim He <tim.he@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18292 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoArmPlatformPkg: Link separated VarCheckUefiLib NULL class library instance
Star Zeng [Tue, 25 Aug 2015 03:03:52 +0000 (03:03 +0000)]
ArmPlatformPkg: Link separated VarCheckUefiLib NULL class library instance

Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18291 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoArmVirtPkg: Link separated VarCheckUefiLib NULL class library instance
Star Zeng [Tue, 25 Aug 2015 03:03:23 +0000 (03:03 +0000)]
ArmVirtPkg: Link separated VarCheckUefiLib NULL class library instance

Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18290 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoEmulatorPkg: Link separated VarCheckUefiLib NULL class library instance
Star Zeng [Tue, 25 Aug 2015 03:03:05 +0000 (03:03 +0000)]
EmulatorPkg: Link separated VarCheckUefiLib NULL class library instance

Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Andrew Fish <afish@apple.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18289 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoOvmfPkg: Link separated VarCheckUefiLib NULL class library instance
Star Zeng [Tue, 25 Aug 2015 03:02:46 +0000 (03:02 +0000)]
OvmfPkg: Link separated VarCheckUefiLib NULL class library instance

Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18288 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoNt32Pkg: Link separated VarCheckUefiLib NULL class library instance
Star Zeng [Tue, 25 Aug 2015 03:02:18 +0000 (03:02 +0000)]
Nt32Pkg: Link separated VarCheckUefiLib NULL class library instance

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18287 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoMdeModulePkg Variable: Consume the separated VarCheckLib
Star Zeng [Tue, 25 Aug 2015 03:01:56 +0000 (03:01 +0000)]
MdeModulePkg Variable: Consume the separated VarCheckLib

Since the variable check service has be separated to VarCheckLib
from Variable driver, so update Variable driver to consume the
separated VarCheckLib.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18286 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoVlv2TbltDevicePkg: Add VarCheckLib library mapping
Star Zeng [Tue, 25 Aug 2015 03:01:13 +0000 (03:01 +0000)]
Vlv2TbltDevicePkg: Add VarCheckLib library mapping

Since Variable driver has been updated to consume the separated VarCheckLib.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: David Wei <david.wei@intel.com>
Reviewed-by: Tim He <tim.he@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18285 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoArmPlatformPkg: Add VarCheckLib library mapping
Star Zeng [Tue, 25 Aug 2015 03:00:44 +0000 (03:00 +0000)]
ArmPlatformPkg: Add VarCheckLib library mapping

Since Variable driver has been updated to consume the separated VarCheckLib.

Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18284 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoArmVirtPkg: Add VarCheckLib library mapping
Star Zeng [Tue, 25 Aug 2015 03:00:20 +0000 (03:00 +0000)]
ArmVirtPkg: Add VarCheckLib library mapping

Since Variable driver has been updated to consume the separated VarCheckLib.

Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18283 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoEmulatorPkg: Add VarCheckLib library mapping
Star Zeng [Tue, 25 Aug 2015 02:59:52 +0000 (02:59 +0000)]
EmulatorPkg: Add VarCheckLib library mapping

Since Variable driver has been updated to consume the separated VarCheckLib.

Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Andrew Fish <afish@apple.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18282 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoOvmfPkg: Add VarCheckLib library mapping
Star Zeng [Tue, 25 Aug 2015 02:59:25 +0000 (02:59 +0000)]
OvmfPkg: Add VarCheckLib library mapping

Since Variable driver has been updated to consume the separated VarCheckLib.

Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18281 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoNt32Pkg: Add VarCheckLib library mapping
Star Zeng [Tue, 25 Aug 2015 02:59:00 +0000 (02:59 +0000)]
Nt32Pkg: Add VarCheckLib library mapping

Since Variable driver has been updated to consume the separated VarCheckLib.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18280 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoMdeModulePkg: Add VarCheckUefiLib NULL class library
Star Zeng [Tue, 25 Aug 2015 02:58:36 +0000 (02:58 +0000)]
MdeModulePkg: Add VarCheckUefiLib NULL class library

What to do: Implement VarCheckUefiLib NULL class library instance.
The code logic are separated from Variable driver, and it will consume VarCheckLib
to register var check handler and variable property set for UEFI defined variables.

Why to do: Share code.
Separate variable check UEFI code from Variable driver in MdeModulePkg.
We are going to separate generic software logic code from Variable Driver
to benefit other variable driver implementation. Auth services has been done
to be AuthVariableLib, now to cover variable check service.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18279 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoMdeModulePkg: Add VarCheckLib library
Star Zeng [Tue, 25 Aug 2015 02:58:09 +0000 (02:58 +0000)]
MdeModulePkg: Add VarCheckLib library

What to do:
1. Add VarCheckLib LibraryClass definitions.
2. Implement VarCheckLib library instance.
The code logic are separated from Variable driver.

Why to do: Share code.
Separate variable check service from Variable driver in MdeModulePkg.
We are going to separate generic software logic code from Variable Driver
to benefit other variable driver implementation. Auth services has been done
to be AuthVariableLib, now to cover variable check service.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18278 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoSecurityPkg: Use PcdGetSize to get the size of VOID* PCD value.
Liming Gao [Tue, 25 Aug 2015 01:55:52 +0000 (01:55 +0000)]
SecurityPkg: Use PcdGetSize to get the size of VOID* PCD value.

PcdLib introduces generic API to get the size of VOID* PCD value.
Update Pei and Dxe RsaGuidedLib to use generic PCD API instead of GetEx API.
This change can remove PCD type limitation in these two libraries.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Liming Gao <liming.gao@intel.com>
Reviewed-by: Star Zeng <star.zeng@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18277 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoMdePkg/Library/UefiFileHandleLib: Make FileHandleReadLine return the right buffer...
Qiu Shumin [Mon, 24 Aug 2015 07:42:27 +0000 (07:42 +0000)]
MdePkg/Library/UefiFileHandleLib: Make FileHandleReadLine return the right buffer size.

1. '\r' char will not return in buffer so buffer size should exclude the number of '\r' char.
2. When 'Truncate' is TRUE return the truncated string with 'EFI_SUCCESS' status.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin <shumin.qiu@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18276 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoSourceLevelDebugPkg: Update package version to 0.96 to reflect new changes
Ruiyu Ni [Mon, 24 Aug 2015 06:38:24 +0000 (06:38 +0000)]
SourceLevelDebugPkg: Update package version to 0.96 to reflect new changes

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Reviewed-by: Fan Jeff <jeff.fan@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18275 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoMdeModulePkg:Refine the code in HiiDatabaseDxe
Dandan Bi [Mon, 24 Aug 2015 06:25:50 +0000 (06:25 +0000)]
MdeModulePkg:Refine the code in HiiDatabaseDxe

Check the local variable 'NameSpace' before use it.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
Reviewed-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Qiu Shumin <shumin.qiu@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18274 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoMdeModulePkg: Fix BdsDxe VS2015 build failure
Ruiyu Ni [Mon, 24 Aug 2015 05:49:24 +0000 (05:49 +0000)]
MdeModulePkg: Fix BdsDxe VS2015 build failure

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Reviewed-by: Feng Tian <feng.tian@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18273 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoBaseTools: Update SetPcdPtr in AutoGen Code
Liming Gao [Mon, 24 Aug 2015 05:02:35 +0000 (05:02 +0000)]
BaseTools: Update SetPcdPtr in AutoGen Code

For patchable PCD, map SetPcdPtr() to LibPatchPcdSetPtrAndSize(),
then the size of the updated VOID* value can be cached.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Liming Gao <liming.gao@intel.com>
Reviewed-by: Star Zeng <star.zeng@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18272 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoBaseTools: Fix AutoGen issue for Patchable VOID* PCD.
Liming Gao [Mon, 24 Aug 2015 05:02:07 +0000 (05:02 +0000)]
BaseTools: Fix AutoGen issue for Patchable VOID* PCD.

Patchable VOID* PCD set operation should map LibPatchPcdSetPtr()
and LibPatchPcdSetPtrS() API. This has been done when PCD is used
in driver, but not done when PCD is used in library.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Liming Gao <liming.gao@intel.com>
Reviewed-by: Star Zeng <star.zeng@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18271 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoBaseTools: Generate macro for the size of PCD value
Bob Feng [Mon, 24 Aug 2015 05:01:38 +0000 (05:01 +0000)]
BaseTools: Generate macro for the size of PCD value

PcdLib introduces new APIs to get the size of PCD value.
BaseTools generates those macros in AutoGen code.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Bob Feng <bob.c.feng@intel.com>
Reviewed-by: Star Zeng <star.zeng@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18270 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoMdePkg: Add two PcdApi for Patch VOID* PCD set operation.
Liming Gao [Mon, 24 Aug 2015 05:01:11 +0000 (05:01 +0000)]
MdePkg: Add two PcdApi for Patch VOID* PCD set operation.

Two new APIs LibPatchPcdSetPtrAndSize() and LibPatchPcdSetPtrAndSizeS()
are added to catch the size of the updated VOID* PCD value buffer, then
PcdGetSize() API can return the actual size.

Update three PcdLib instances to implement these two APIs.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Liming Gao <liming.gao@intel.com>
Reviewed-by: Star Zeng <star.zeng@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18269 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoMdePkg: Add four PcdGetSize() API in PcdLib
Liming Gao [Mon, 24 Aug 2015 05:00:32 +0000 (05:00 +0000)]
MdePkg: Add four PcdGetSize() API in PcdLib

Add below four PcdGetSize() API in PcdLib header file. They can be used
to get the size of PCD value.
FixedPcdGetSize()
PatchPcdGetSize()
PcdGetSize()
PcdGetExSize()

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Liming Gao <liming.gao@intel.com>
Reviewed-by: Star Zeng <star.zeng@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18268 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoBaseTools: Add NULL pointer check in AutoGen code
Liming Gao [Mon, 24 Aug 2015 05:00:05 +0000 (05:00 +0000)]
BaseTools: Add NULL pointer check in AutoGen code

For DynamicEx PCD, if NULL pointer is specified as token space GUID,
it will directly be used to compare GUID value in AutoGen code.
To avoid access NULL pointer, NULL pointer will be checked first.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Liming Gao <liming.gao@intel.com>
Reviewed-by: Star Zeng <star.zeng@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18267 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoMdePkg: Update DEC and DSC version from 1.05 to 1.06
Liming Gao [Mon, 24 Aug 2015 04:59:38 +0000 (04:59 +0000)]
MdePkg: Update DEC and DSC version from 1.05 to 1.06

UEFI2.5 and PI1.4 have been added in MdePkg. Update DEC and DSC version
to reflect those changes in MdePkg.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Liming Gao <liming.gao@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18266 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoMdePkg/Library/UefiFileHandleLib: Update the module Basename and module type to ...
Qiu Shumin [Mon, 24 Aug 2015 03:05:02 +0000 (03:05 +0000)]
MdePkg/Library/UefiFileHandleLib: Update the module Basename and module type to 'UEFI*'.

The library instance is not BASE type, to follow naming convention this patch change Basename into 'Uefi*Lib' and module type into 'UEFI_DRIVER'.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin <shumin.qiu@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18265 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoBaseTools/Ecc: Remove checkpoint for STATIC modifier
Hess Chen [Mon, 24 Aug 2015 02:53:27 +0000 (02:53 +0000)]
BaseTools/Ecc: Remove checkpoint for STATIC modifier

Remove checkpoint for STATIC modifier to allow this usage

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hess Chen <hesheng.chen@intel.com>
Reviewed-by: YangX Li <yangx.li@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18264 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoMdePkg: Follow PI spec to update ExtendedSize in EFI_FFS_FILE_HEADER2
Star Zeng [Mon, 24 Aug 2015 01:43:20 +0000 (01:43 +0000)]
MdePkg: Follow PI spec to update ExtendedSize in EFI_FFS_FILE_HEADER2

for FFS data above 16 bytes alignment requirement.

PI spec requires FFS header to be at 8 bytes alignment to FV header.
And, FFS data alignment requires the beginning of the file data must
be aligned on a particular boundary, such as 1, 16, 128 bytes or above.
If FFS data alignment requires to be above 16 bytes, and FFS header
must be at 8 byte alignment, so FFS header size must be multiple of 8.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18263 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoBaseTools: Follow PI spec to update ExtendedSize in EFI_FFS_FILE_HEADER2
Star Zeng [Mon, 24 Aug 2015 01:42:37 +0000 (01:42 +0000)]
BaseTools: Follow PI spec to update ExtendedSize in EFI_FFS_FILE_HEADER2

for FFS data above 16 bytes alignment requirement.

PI spec requires FFS header to be at 8 bytes alignment to FV header.
And, FFS data alignment requires the beginning of the file data must
be aligned on a particular boundary, such as 1, 16, 128 bytes or above.
If FFS data alignment requires to be above 16 bytes, and FFS header
must be at 8 byte alignment, so FFS header size must be multiple of 8.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18262 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoNt32Pkg: Add HttpUtilitiesDxe module
Jiaxin Wu [Mon, 24 Aug 2015 01:24:44 +0000 (01:24 +0000)]
Nt32Pkg: Add HttpUtilitiesDxe module

This patch is used to add HttpUtilitiesDxe module.

Cc: Ye Ting <ting.ye@intel.com>
Cc: Siyuan Fu <siyuan.fu@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jiaxin Wu <jiaxin.wu@intel.com>
Reviewed-by: Ye Ting <ting.ye@intel.com>
Reviewed-by: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@hp.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18261 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoNetworkPkg: Add HTTP utilities driver
Jiaxin Wu [Mon, 24 Aug 2015 01:24:20 +0000 (01:24 +0000)]
NetworkPkg: Add HTTP utilities driver

This patch is used to add HTTP utilities driver.

Cc: Ye Ting <ting.ye@intel.com>
Cc: Siyuan Fu <siyuan.fu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jiaxin Wu <jiaxin.wu@intel.com>
Reviewed-by: Ye Ting <ting.ye@intel.com>
Reviewed-by: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@hp.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18260 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoMdePkg: Add header file for HTTP utilities protocol
Jiaxin Wu [Mon, 24 Aug 2015 01:23:50 +0000 (01:23 +0000)]
MdePkg: Add header file for HTTP utilities protocol

This patch is used to add header files for HTTP utilities protocol.

Cc: Ye Ting <ting.ye@intel.com>
Cc: Siyuan Fu <siyuan.fu@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jiaxin Wu <jiaxin.wu@intel.com>
Reviewed-by: Ye Ting <ting.ye@intel.com>
Reviewed-by: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@hp.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18259 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoOvmfPkg: Add HttpBoot support
Gary Ching-Pang Lin [Sun, 23 Aug 2015 01:44:15 +0000 (01:44 +0000)]
OvmfPkg: Add HttpBoot support

This commit introdues a new build option to OvmfPkg: HTTP_BOOT_ENABLE.
When HttpBoot is enabled, a new Network boot option will show in the
boot manager menu with the device path like this:

PciRoot(0x0)/Pci(0x3,0x0)/MAC(525400123456,0x1)/IPv4(0.0.0.0)/Uri()

It works like the PXE one but fetches the NBP from the given http
url instead of the tftp service.

A simple testing environment can be set up with the QEMU tap network
and dnsmasq + lighttpd.

Here is the example of the dnsmasq config:

  interface=<tap interface>
  dhcp-range=192.168.111.100,192.168.111.120,12h
  dhcp-option=60,"HTTPClient"
  dhcp-boot="http://<tap ip>/<efi file>"

It's similar to the PXE server settings except the tftp function is
disabled, the option 60 must be "HTTPClient", and the boot uri is a
http url.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Gary Ching-Pang Lin <glin@suse.com>
Reviewed-by: Fu Siyuan <siyuan.fu@intel.com>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18258 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoNetworkPkg: Remove the hostname from the http request URL.
Gary Ching-Pang Lin [Sat, 22 Aug 2015 12:35:19 +0000 (12:35 +0000)]
NetworkPkg: Remove the hostname from the http request URL.

Per RFC7230, the URL must be a absolute-path when making a request directly to
the server. Since proxy is not supported now, all requests to the HTTP driver
are actually direct requests. This commit removes the scheme and the hostname
from the URL in the http request if the URL is an absolute-URI so that the HTTP
server can interpret the request properly.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Gary Ching-Pang Lin <glin@suse.com>
Reviewed-by: Ye Ting <ting.ye@intel.com>
Reviewed-by: Fu Siyuan <siyuan.fu@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18257 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoBaseTools: Fix build fail when the number in validlist is long type.
Bob Feng [Fri, 21 Aug 2015 01:09:16 +0000 (01:09 +0000)]
BaseTools: Fix build fail when the number in validlist is long type.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: "Bob Feng" <bob.c.feng@intel.com>
Reviewed-by: "Chen, Hesheng" <hesheng.chen@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18256 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoCryptoPkg: Add a missed include file to fix the possible build issue.
Qin Long [Thu, 20 Aug 2015 08:49:31 +0000 (08:49 +0000)]
CryptoPkg: Add a missed include file to fix the possible build issue.

Add a missed include file (UefiBaseType.h) into BaseCryptLib.h, since
EFI_TIME was introduced in the new crypto API (ImageTimestampVerify).

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qin Long <qin.long@intel.com>
Reviewed-by: Ye Ting <ting.ye@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18255 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoMdeModulePkg:Fix build fail in VS2008
Dandan Bi [Thu, 20 Aug 2015 08:46:15 +0000 (08:46 +0000)]
MdeModulePkg:Fix build fail in VS2008

Fix the potentially uninitialized local variable

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
Reviewed-by: Eric Dong <eric.dong@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18254 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoIntelFrameworkModulePkg: Update DEC and DSC version from 0.94 to 0.96
Feng Tian [Thu, 20 Aug 2015 08:46:05 +0000 (08:46 +0000)]
IntelFrameworkModulePkg: Update DEC and DSC version from 0.94 to 0.96

Update DEC and DSC version to reflect new changes.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Feng Tian <feng.tian@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18253 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoIntelFrameworkPkg: Update DEC and DSC version from 0.94 to 0.96
Feng Tian [Thu, 20 Aug 2015 08:45:45 +0000 (08:45 +0000)]
IntelFrameworkPkg: Update DEC and DSC version from 0.94 to 0.96

Update DEC and DSC version to reflect new changes.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Feng Tian <feng.tian@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18252 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoMdeModulePkg: Update DSC version from 0.94 to 0.96
Feng Tian [Thu, 20 Aug 2015 08:45:01 +0000 (08:45 +0000)]
MdeModulePkg: Update DSC version from 0.94 to 0.96

Update DSC version to reflect new changes for UEFI2.5 and PI1.4.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Feng Tian <feng.tian@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18251 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoFixed build error for VS2008 toolchain.
Eric Dong [Thu, 20 Aug 2015 08:05:27 +0000 (08:05 +0000)]
Fixed build error for VS2008 toolchain.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eric Dong <eric.dong@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18250 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoMdeModulePkg:Full support F10 hot key in UiApp.
Dandan Bi [Thu, 20 Aug 2015 07:05:53 +0000 (07:05 +0000)]
MdeModulePkg:Full support F10 hot key in UiApp.

In current UiApp/Boot Maintenance manager,some pages don't support F10,
they use Commit Changes and Exit menu to save changes.Now support F10
in these pages.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
Reviewed-by: Eric Dong <eric.dong@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18249 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoNetworkPkg: Fix DHCP TransmitReceive EFI_NO_MAPPING return in DnsDxe
Jiaxin Wu [Thu, 20 Aug 2015 07:01:47 +0000 (07:01 +0000)]
NetworkPkg: Fix DHCP TransmitReceive EFI_NO_MAPPING return in DnsDxe

v2:
* Add Timeout check, if time out, return EFI_DEVICE_ERROR.

If the default station address is not available, TransmitReceive
function will return EFI_NO_MAPPING. DNS driver should handle this
case. This issue is caused by the r18201 fix.

Cc: Ye Ting <ting.ye@intel.com>
Cc: Zhang Lubo <lubo.zhang@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jiaxin Wu <jiaxin.wu@intel.com>
Reviewed-by: Ye Ting <ting.ye@intel.com>
Reviewed-by: Lubo Zhang <lubo.zhang@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18248 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoCryptoPkg: Update Package version to 0.96
Qin Long [Thu, 20 Aug 2015 06:58:44 +0000 (06:58 +0000)]
CryptoPkg: Update Package version to 0.96

Update Package version to 0.9.6

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qin Long <qin.long@intel.com>
Reviewed-by: Ye Ting <ting.ye@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18247 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoNetworkPkg: Update the NetworkPkg package version
Jiaxin Wu [Thu, 20 Aug 2015 06:50:32 +0000 (06:50 +0000)]
NetworkPkg: Update the NetworkPkg package version

This patch is used to update the NetworkPkg package version.

Cc: Fu Siyuan <siyuan.fu@intel.com>
Cc: Ye Ting <ting.ye@intel.com>
Cc: Chao Zhang <chao.b.zhang@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jiaxin Wu <jiaxin.wu@intel.com>
Reviewed-by: Ye Ting <ting.ye@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18246 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoMdeModulePkg: Fix default router table and interface missing error
Jiaxin Wu [Thu, 20 Aug 2015 06:47:13 +0000 (06:47 +0000)]
MdeModulePkg: Fix default router table and interface missing error

Ip4StartAutoConfig() will always free its default router table and interface,
which may cause IP instance missing its correct default interface. e.g. when
the policy is dhcp, and one child is configured to use default address.

Cc: Ye Ting <ting.ye@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jiaxin Wu <jiaxin.wu@intel.com>
Reviwed-by: Ye Ting <ting.ye@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18245 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoShellPkg: Fix 'ifconfig' can't get the address from dhcp in some case
Jiaxin Wu [Thu, 20 Aug 2015 06:45:19 +0000 (06:45 +0000)]
ShellPkg: Fix 'ifconfig' can't get the address from dhcp in some case

R18201 fix caused ifconfig in shell failed to get the address from dhcp with the
command "ifconfig -s eth0 dhcp" since the default policy is dhcp already.
We can fix it by following the rule to starting the Ip4 auto configuration.

Cc: Ye Ting <ting.ye@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jiaxin Wu <jiaxin.wu@intel.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
Reviwed-by: Ye Ting <ting.ye@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18244 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoShellBinPkg: Arm/AArch64 Shell binary update.
Ard Biesheuvel [Thu, 20 Aug 2015 06:39:45 +0000 (06:39 +0000)]
ShellBinPkg: Arm/AArch64 Shell binary update.

The binaries of ShellBinPkg are generated with ShellPkg project 18222.

The AArch64 binaries are generated using the tiny code model introduced
in the previous patch.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18243 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoBaseTools AARCH64: use tiny code model by default
Ard Biesheuvel [Thu, 20 Aug 2015 06:39:12 +0000 (06:39 +0000)]
BaseTools AARCH64: use tiny code model by default

The AARCH64 tiny code model produces more efficient code, since it
uses relative symbol references rather than absolute references, i.e.,
an emitted relative reference refers to the symbol directly rather
than a literal containing its 64-bit absolute address. This saves
space in the binary, and reduces the number of relocation fixups that
need to be applied by the PE/COFF loader.

So now that we support relative relocations in GenFw, move to the
tiny code model by default. Note that the large model can still be
selected by individual modules by adding -mcmodel=large to the
appropriate CC_FLAGS.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Tested-by: Leif Lindholm <leif.lindholm@linaro.org>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18242 6f19259b-4bc3-4df7-8a09-765794883524

6 years agoShellPkg: force use of AARCH64 small model when building DEBUG shell
Ard Biesheuvel [Thu, 20 Aug 2015 06:39:04 +0000 (06:39 +0000)]
ShellPkg: force use of AARCH64 small model when building DEBUG shell

The tiny code model used by AARCH64 only supports binaries of up to
1 MB in size. Since the Shell application exceeds that when built in
DEBUG mode, make sure we build it using the small code model instead.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Tested-by: Leif Lindholm <leif.lindholm@linaro.org>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18241 6f19259b-4bc3-4df7-8a09-765794883524