From b2e043b6895d70c57ef390d160e05c9d6f44298d Mon Sep 17 00:00:00 2001 From: "Kinney, Michael D" Date: Fri, 8 Jun 2018 20:49:43 -0700 Subject: [PATCH] BaseTools/BinToPcd: Clarify error message for --type HII https://bugzilla.tianocore.org/show_bug.cgi?id=963 Update error message for --type HII. If either --variable-guid or --variable-name is missing, then print an error message that states that both --variable-guid and --variable-name are required. Cc: Yanyan Sun Cc: Yonghong Zhu Cc: Liming Gao Signed-off-by: Michael D Kinney Contributed-under: TianoCore Contribution Agreement 1.1 Reviewed-by: Yonghong Zhu --- BaseTools/Scripts/BinToPcd.py | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/BaseTools/Scripts/BinToPcd.py b/BaseTools/Scripts/BinToPcd.py index 014aad9800..7e3380190e 100644 --- a/BaseTools/Scripts/BinToPcd.py +++ b/BaseTools/Scripts/BinToPcd.py @@ -186,11 +186,8 @@ if __name__ == '__main__': print ' [PcdsDynamicVpd]' print ' [PcdsDynamicExVpd]' elif args.PcdType == 'HII': - if args.VariableGuid is None: - print 'BinToPcd: error: argument --variable-guid is required for --type HII.' - sys.exit() - if args.VariableName is None: - print 'BinToPcd: error: argument --variable-name is required for --type HII.' + if args.VariableGuid is None or args.VariableName is None: + print 'BinToPcd: error: arguments --variable-guid and --variable-name are required for --type HII.' sys.exit() if args.Offset is None: # -- 2.39.2