From 817e36690ad3156b9413d48e3ff5c3509d34c03f Mon Sep 17 00:00:00 2001 From: "Carsey, Jaben" Date: Sat, 28 Apr 2018 06:32:29 +0800 Subject: [PATCH] BaseTools: eliminate {} from dictionary contructor call no need to construct 2 dictionaries. Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey Reviewed-by: Yonghong Zhu --- BaseTools/Source/Python/Workspace/BuildClassObject.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/BaseTools/Source/Python/Workspace/BuildClassObject.py b/BaseTools/Source/Python/Workspace/BuildClassObject.py index 226277a451..8b3e2ec299 100644 --- a/BaseTools/Source/Python/Workspace/BuildClassObject.py +++ b/BaseTools/Source/Python/Workspace/BuildClassObject.py @@ -123,16 +123,16 @@ class StructurePcd(PcdClassObject): self.StructuredPcdIncludeFile = [] if StructuredPcdIncludeFile is None else StructuredPcdIncludeFile self.PackageDecs = Packages self.DefaultStoreName = [default_store] - self.DefaultValues = collections.OrderedDict({}) + self.DefaultValues = collections.OrderedDict() self.PcdMode = None - self.SkuOverrideValues = collections.OrderedDict({}) + self.SkuOverrideValues = collections.OrderedDict() self.FlexibleFieldName = None self.StructName = None self.PcdDefineLineNo = 0 self.PkgPath = "" self.DefaultValueFromDec = "" self.ValueChain = dict() - self.PcdFieldValueFromComm = collections.OrderedDict({}) + self.PcdFieldValueFromComm = collections.OrderedDict() def __repr__(self): return self.TypeName @@ -146,9 +146,9 @@ class StructurePcd(PcdClassObject): self.DefaultValueFromDec = DefaultValue def AddOverrideValue (self, FieldName, Value, SkuName, DefaultStoreName, FileName="", LineNo=0): if SkuName not in self.SkuOverrideValues: - self.SkuOverrideValues[SkuName] = collections.OrderedDict({}) + self.SkuOverrideValues[SkuName] = collections.OrderedDict() if DefaultStoreName not in self.SkuOverrideValues[SkuName]: - self.SkuOverrideValues[SkuName][DefaultStoreName] = collections.OrderedDict({}) + self.SkuOverrideValues[SkuName][DefaultStoreName] = collections.OrderedDict() if FieldName in self.SkuOverrideValues[SkuName][DefaultStoreName]: del self.SkuOverrideValues[SkuName][DefaultStoreName][FieldName] self.SkuOverrideValues[SkuName][DefaultStoreName][FieldName] = [Value.strip(), FileName, LineNo] -- 2.39.2