From 9920ae74af5a38672ddde0a997a7ec0960c96275 Mon Sep 17 00:00:00 2001 From: eric_tian Date: Mon, 28 Jul 2008 02:43:46 +0000 Subject: [PATCH] modify coding style to pass ecc tool git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5575 6f19259b-4bc3-4df7-8a09-765794883524 --- MdeModulePkg/Bus/Pci/UhciDxe/UhciDebug.c | 5 --- MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus.h | 13 +++++++ MdeModulePkg/Bus/Usb/UsbBusDxe/UsbEnumer.h | 10 ----- MdeModulePkg/Core/RuntimeDxe/Crc32.c | 16 +++----- MdeModulePkg/Core/RuntimeDxe/Runtime.h | 37 ++++++------------- .../FaultTolerantWriteDxe/FtwWorkSpace.c | 9 +++-- 6 files changed, 34 insertions(+), 56 deletions(-) diff --git a/MdeModulePkg/Bus/Pci/UhciDxe/UhciDebug.c b/MdeModulePkg/Bus/Pci/UhciDxe/UhciDebug.c index caf2cc9cf2..744976cd02 100644 --- a/MdeModulePkg/Bus/Pci/UhciDxe/UhciDebug.c +++ b/MdeModulePkg/Bus/Pci/UhciDxe/UhciDebug.c @@ -22,8 +22,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. @param QhSw Pointer to software QH structure. - @return None. - **/ VOID UhciDumpQh ( @@ -43,9 +41,6 @@ UhciDumpQh ( Dump the content of TD structure. @param TdSw Pointer to software TD structure. - @param IsCur Whether dump the whole list, or only dump the current TD. - - @return None. **/ VOID diff --git a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus.h b/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus.h index 4bee1836f9..dc6d215947 100644 --- a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus.h +++ b/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus.h @@ -257,6 +257,19 @@ struct _USB_BUS { }; +// +// USB Hub Api +// +struct _USB_HUB_API{ + USB_HUB_INIT Init; + USB_HUB_GET_PORT_STATUS GetPortStatus; + USB_HUB_CLEAR_PORT_CHANGE ClearPortChange; + USB_HUB_SET_PORT_FEATURE SetPortFeature; + USB_HUB_CLEAR_PORT_FEATURE ClearPortFeature; + USB_HUB_RESET_PORT ResetPort; + USB_HUB_RELEASE Release; +}; + #define USB_US_LAND_ID 0x0409 #define DEVICE_PATH_LIST_ITEM_SIGNATURE EFI_SIGNATURE_32('d','p','l','i') diff --git a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbEnumer.h b/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbEnumer.h index 1b36a6d853..a528e43a23 100644 --- a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbEnumer.h +++ b/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbEnumer.h @@ -91,16 +91,6 @@ EFI_STATUS IN USB_INTERFACE *UsbIf ); -struct _USB_HUB_API{ - USB_HUB_INIT Init; - USB_HUB_GET_PORT_STATUS GetPortStatus; - USB_HUB_CLEAR_PORT_CHANGE ClearPortChange; - USB_HUB_SET_PORT_FEATURE SetPortFeature; - USB_HUB_CLEAR_PORT_FEATURE ClearPortFeature; - USB_HUB_RESET_PORT ResetPort; - USB_HUB_RELEASE Release; -}; - /** Return the endpoint descriptor in this interface. diff --git a/MdeModulePkg/Core/RuntimeDxe/Crc32.c b/MdeModulePkg/Core/RuntimeDxe/Crc32.c index 0f22d1f6b7..14370dbc7d 100644 --- a/MdeModulePkg/Core/RuntimeDxe/Crc32.c +++ b/MdeModulePkg/Core/RuntimeDxe/Crc32.c @@ -1,6 +1,11 @@ /** @file CalculateCrc32 Boot Services as defined in DXE CIS. + This Boot Services is in the Runtime Driver because this service is + also required by SetVirtualAddressMap() when the EFI System Table and + EFI Runtime Services Table are converted from physical address to + virtual addresses. This requires that the 32-bit CRC be recomputed. + Copyright (c) 2006, Intel Corporation.
All rights reserved. This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License @@ -10,17 +15,6 @@ http://opensource.org/licenses/bsd-license.php THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. -Module Name: - - Crc32.c - -Abstract: - - This Boot Services is in the Runtime Driver because this service is - also required by SetVirtualAddressMap() when the EFI System Table and - EFI Runtime Services Table are converted from physical address to - virtual addresses. This requires that the 32-bit CRC be recomputed. - **/ diff --git a/MdeModulePkg/Core/RuntimeDxe/Runtime.h b/MdeModulePkg/Core/RuntimeDxe/Runtime.h index e85c47d9b1..c19cc733fd 100644 --- a/MdeModulePkg/Core/RuntimeDxe/Runtime.h +++ b/MdeModulePkg/Core/RuntimeDxe/Runtime.h @@ -1,6 +1,8 @@ /** @file Runtime Architectural Protocol as defined in the DXE CIS. + This code is used to produce the EFI runtime architectural protocol. + Copyright (c) 2006, Intel Corporation.
All rights reserved. This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License @@ -10,15 +12,6 @@ http://opensource.org/licenses/bsd-license.php THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. - -Module Name: - - Runtime.h - -Abstract: - - This code is used to produce the EFI runtime architectural protocol. - **/ #ifndef _RUNTIME_H_ @@ -43,9 +36,7 @@ Abstract: // Function Prototypes // /** - - Calculate CRC32 for target data - + Calculate CRC32 for target data. @param Data The target data. @param DataSize The target data size. @@ -66,7 +57,6 @@ RuntimeDriverCalculateCrc32 ( ; /** - Determines the new virtual address that is to be used on subsequent memory accesses. @@ -89,14 +79,12 @@ RuntimeDriverConvertPointer ( ; /** - Changes the runtime addressing mode of EFI firmware from physical to virtual. - - @param MemoryMapSize The size in bytes of VirtualMap. - @param DescriptorSize The size in bytes of an entry in the VirtualMap. - @param DescriptorVersion The version of the structure entries in VirtualMap. - @param VirtualMap An array of memory descriptors which contain new virtual + @param MemoryMapSize The size in bytes of VirtualMap. + @param DescriptorSize The size in bytes of an entry in the VirtualMap. + @param DescriptorVersion The version of the structure entries in VirtualMap. + @param VirtualMap An array of memory descriptors which contain new virtual address mapping information for all runtime ranges. @retval EFI_SUCCESS The virtual address map has been applied. @@ -120,7 +108,6 @@ RuntimeDriverSetVirtualAddressMap ( ; /** - Initialize CRC32 table. **/ @@ -131,16 +118,14 @@ RuntimeDriverInitializeCrc32Table ( ; /** - Install Runtime AP. This code includes the EfiRuntimeLib, but it only functions at RT in physical mode. + @param ImageHandle Image handle of this driver. + @param SystemTable Pointer to the EFI System Table. - @param ImageHandle Image handle of this driver. - @param SystemTable Pointer to the EFI System Table. - - @retval EFI_SUCEESS Runtime Driver Architectural Protocol Installed - @return Other value if gBS->InstallMultipleProtocolInterfaces fails. Check + @retval EFI_SUCEESS Runtime Driver Architectural Protocol Installed + @return Other value if gBS->InstallMultipleProtocolInterfaces fails. Check gBS->InstallMultipleProtocolInterfaces for details. **/ diff --git a/MdeModulePkg/Universal/FirmwareVolume/FaultTolerantWriteDxe/FtwWorkSpace.c b/MdeModulePkg/Universal/FirmwareVolume/FaultTolerantWriteDxe/FtwWorkSpace.c index 5583518e52..6831504db8 100644 --- a/MdeModulePkg/Universal/FirmwareVolume/FaultTolerantWriteDxe/FtwWorkSpace.c +++ b/MdeModulePkg/Universal/FirmwareVolume/FaultTolerantWriteDxe/FtwWorkSpace.c @@ -302,11 +302,12 @@ WorkSpaceRefresh ( Reclaim the work space on the working block. - @param FtwLiteDevice Point to private data of FTW driver + @param FtwLiteDevice Point to private data of FTW driver + @param PreserveRecord Whether get the last record or not - @retval EFI_SUCCESS The function completed successfully - @retval EFI_OUT_OF_RESOURCES Allocate memory error - @retval EFI_ABORTED The function could not complete successfully + @retval EFI_SUCCESS The function completed successfully + @retval EFI_OUT_OF_RESOURCES Allocate memory error + @retval EFI_ABORTED The function could not complete successfully **/ EFI_STATUS -- 2.39.2