From 3b1464d5ac4e8b917c54b9f29a43ad972d2a2c85 Mon Sep 17 00:00:00 2001 From: rsun3 Date: Fri, 19 Mar 2010 06:55:58 +0000 Subject: [PATCH] git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10288 6f19259b-4bc3-4df7-8a09-765794883524 --- .../Include/Guid/LoadModuleAtFixedAddress.h | 4 ++-- MdeModulePkg/Include/Library/IpIoLib.h | 7 +++---- MdeModulePkg/Include/Library/NetLib.h | 19 ++++++++++--------- MdeModulePkg/Library/DxeIpIoLib/DxeIpIoLib.c | 7 +++---- MdeModulePkg/Library/DxeNetLib/DxeNetLib.c | 9 +++++---- MdeModulePkg/Library/DxeNetLib/NetBuffer.c | 4 ++-- 6 files changed, 25 insertions(+), 25 deletions(-) diff --git a/MdeModulePkg/Include/Guid/LoadModuleAtFixedAddress.h b/MdeModulePkg/Include/Guid/LoadModuleAtFixedAddress.h index d2b01cea68..68e41cd178 100644 --- a/MdeModulePkg/Include/Guid/LoadModuleAtFixedAddress.h +++ b/MdeModulePkg/Include/Guid/LoadModuleAtFixedAddress.h @@ -27,8 +27,8 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. extern EFI_GUID gLoadFixedAddressConfigurationTableGuid; typedef struct { - EFI_PHYSICAL_ADDRESS DxeCodeTopAddress; ///< The top address below which the Dxe runtime code and below which the Dxe runtime/boot code and PEI code. - EFI_PHYSICAL_ADDRESS SmramBase; ///< SMM RAME base. build tool will assigned an offset relative to SMRAM base for SMM driver. + EFI_PHYSICAL_ADDRESS DxeCodeTopAddress; ///< The top address below which the Dxe runtime code and below which the Dxe runtime/boot code and PEI code. + EFI_PHYSICAL_ADDRESS SmramBase; ///< SMRAM base address. The build tool assigns an offset relative to the SMRAM base for a SMM driver. } EFI_LOAD_FIXED_ADDRESS_CONFIGURATION_TABLE; #endif diff --git a/MdeModulePkg/Include/Library/IpIoLib.h b/MdeModulePkg/Include/Library/IpIoLib.h index 09ff2c122a..b1cbacb593 100644 --- a/MdeModulePkg/Include/Library/IpIoLib.h +++ b/MdeModulePkg/Include/Library/IpIoLib.h @@ -529,10 +529,9 @@ IpIoFindSender ( @param[in] IcmpError IcmpError Type. @param[in] IpVersion The version of the IP protocol to use, - either IPv4 or IPv6. - - @param[out] IsHard Whether it is a hard error. - @param[out] Notify Whether it need to notify SockError. + either IPv4 or IPv6. + @param[out] IsHard If TRUE, indicates that it is a hard error. + @param[out] Notify If TRUE, SockError needs to be notified. @return The ICMP Error Status, such as EFI_NETWORK_UNREACHABLE. diff --git a/MdeModulePkg/Include/Library/NetLib.h b/MdeModulePkg/Include/Library/NetLib.h index a011bf7acb..71680a42b2 100644 --- a/MdeModulePkg/Include/Library/NetLib.h +++ b/MdeModulePkg/Include/Library/NetLib.h @@ -507,7 +507,7 @@ NetGetUint32 ( byte stream. @param[in, out] Buf The buffer in which to put the UINT32. - @param[in] Data The data to put. + @param[in] Data The data to be converted and put into the byte stream. **/ VOID @@ -1097,17 +1097,18 @@ NetLibGetMacString ( The underlying UNDI driver may or may not support reporting media status from GET_STATUS command (PXE_STATFLAGS_GET_STATUS_NO_MEDIA_SUPPORTED). This routine - will try to invoke Snp->GetStatus() to get the media status. Iif media is already - present, it returns directly. If media isnot present, it will stop SNP and then - restart SNP to get the latest media status. This provides an opportunity to get + will try to invoke Snp->GetStatus() to get the media status. If media is already + present, it returns directly. If media is not present, it will stop SNP and then + restart SNP to get the latest media status. This provides an opportunity to get the correct media status for old UNDI driver, which doesn't support reporting media status from GET_STATUS command. Note: there are two limitations for the current algorithm: 1) For UNDI with this capability, when the cable is not attached, there will be an redundant Stop/Start() process. - 2) For UNDI without this capability, when the cable is attached, the UNDI - initializes while unattached. Later, NetLibDetectMedia() will report - MediaPresent as TRUE, causing upper layer apps to wait for timeout time. + 2) for UNDI without this capability, in case that network cable is attached when + Snp->Initialize() is invoked while network cable is unattached later, + NetLibDetectMedia() will report MediaPresent as TRUE, causing upper layer + apps to wait for timeout time. @param[in] ServiceHandle The handle where network service binding protocols are installed. @@ -1868,8 +1869,8 @@ NetbufQueCopy ( ); /** - Trim Len bytes of data from the queue header and release any net buffer - that is trimmed wholely. + Trim Len bytes of data from the buffer queue and free any net buffer + that is completely trimmed. The trimming operation is the same as NetbufTrim but applies to the net buffer queue instead of the net buffer. diff --git a/MdeModulePkg/Library/DxeIpIoLib/DxeIpIoLib.c b/MdeModulePkg/Library/DxeIpIoLib/DxeIpIoLib.c index 9ed7b8ddfb..d5fddb678f 100644 --- a/MdeModulePkg/Library/DxeIpIoLib/DxeIpIoLib.c +++ b/MdeModulePkg/Library/DxeIpIoLib/DxeIpIoLib.c @@ -2012,10 +2012,9 @@ IpIoFindSender ( @param[in] IcmpError IcmpError Type. @param[in] IpVersion The version of the IP protocol to use, - either IPv4 or IPv6. - - @param[out] IsHard Whether it is a hard error. - @param[out] Notify Whether it need to notify SockError. + either IPv4 or IPv6. + @param[out] IsHard If TRUE, indicates that it is a hard error. + @param[out] Notify If TRUE, SockError needs to be notified. @return ICMP Error Status, such as EFI_NETWORK_UNREACHABLE. diff --git a/MdeModulePkg/Library/DxeNetLib/DxeNetLib.c b/MdeModulePkg/Library/DxeNetLib/DxeNetLib.c index 5037243b37..034031d09f 100644 --- a/MdeModulePkg/Library/DxeNetLib/DxeNetLib.c +++ b/MdeModulePkg/Library/DxeNetLib/DxeNetLib.c @@ -901,7 +901,7 @@ NetGetUint32 ( byte stream. @param[in, out] Buf The buffer to put the UINT32. - @param[in] Data The data to put. + @param[in] Data The data to be converted and put into the byte stream. **/ VOID @@ -2158,9 +2158,10 @@ NetLibGetMacString ( Note: there will be two limitations for current algorithm: 1) for UNDI with this capability, in case of cable is not attached, there will be an redundant Stop/Start() process; - 2) for UNDI without this capability, in case cable is attached in UNDI - initialize while unattached latter, NetLibDetectMedia() will report - MediaPresent as TRUE, this cause upper layer apps wait for timeout time. + 2) for UNDI without this capability, in case that network cable is attached when + Snp->Initialize() is invoked while network cable is unattached later, + NetLibDetectMedia() will report MediaPresent as TRUE, causing upper layer + apps to wait for timeout time. @param[in] ServiceHandle The handle where network service binding protocols are installed on. diff --git a/MdeModulePkg/Library/DxeNetLib/NetBuffer.c b/MdeModulePkg/Library/DxeNetLib/NetBuffer.c index 76b6510659..139735e2cb 100644 --- a/MdeModulePkg/Library/DxeNetLib/NetBuffer.c +++ b/MdeModulePkg/Library/DxeNetLib/NetBuffer.c @@ -1556,8 +1556,8 @@ NetbufQueCopy ( /** - Trim Len bytes of data from the queue header, release any of the net buffer - whom is trimmed wholely. + Trim Len bytes of data from the buffer queue and free any net buffer + that is completely trimmed. The trimming operation is the same as NetbufTrim but applies to the net buffer queue instead of the net buffer. -- 2.39.2