From df77614e543e324f5d726234238eb4ff6f782d8f Mon Sep 17 00:00:00 2001 From: Samer El-Haj-Mahmoud Date: Sun, 20 Dec 2020 21:53:55 +0800 Subject: [PATCH] MdeModulePkg/ConSplitter: Change StdErr color to EFI_LIGHTGRAY ConSplitter is using EFI_LIGHTGRAY foreground color for ConOut and EFI_MAGENTA for StdErr consoles. This is impacting the DebugLib output on that same serial console (e.g. DebugLibSerialPort) after gEfiStandardErrorDeviceGuid is installed on that port. The impact also extends to Linux serial console output in OVMF because it inherits the color setting from the firmware. This is inconsistent and annoying, with MAGENTA being barely legible on a black background. Let's change StdErr default color to LIGHTGRAY for consistency and readability. This results in the same color being used for all consoles sharing the same serial port (ConOut, StdErr, DebugLib, OS console). Platforms wishing to distinguish the colors of consoles can do so in their own Platform BDS initialization. Cc: Jian J Wang Cc: Hao A Wu Cc: Zhichao Gao Cc: Ray Ni Cc: Ard Biesheuvel Signed-off-by: Samer El-Haj-Mahmoud Reviewed-by: Zhichao Gao Reviewed-by: Pete Batard Tested-by: Pete Batard (On an RPi 4 platform where this was another annoyance) --- MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c b/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c index b090de2885..e8cd4ce120 100644 --- a/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c +++ b/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c @@ -1476,7 +1476,7 @@ ConSplitterStdErrDriverBindingStart ( // their MaxMode and QueryData should be the intersection of both. // Status = ConSplitterTextOutAddDevice (&mStdErr, TextOut, NULL, NULL); - ConSplitterTextOutSetAttribute (&mStdErr.TextOut, EFI_TEXT_ATTR (EFI_MAGENTA, EFI_BLACK)); + ConSplitterTextOutSetAttribute (&mStdErr.TextOut, EFI_TEXT_ATTR (EFI_LIGHTGRAY, EFI_BLACK)); return Status; } -- 2.39.2