From a2a6f9f61de61622253d7b3cc74567e015cf26fc Mon Sep 17 00:00:00 2001 From: shenglei Date: Wed, 8 Aug 2018 16:18:22 +0800 Subject: [PATCH] MdeModulePkg TerminalDxe: Remove a redundant function The function UnicodeFiFoGetKeyCount that is never called has been removed. https://bugzilla.tianocore.org/show_bug.cgi?id=1062 Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei Reviewed-by: Ruiyu Ni Reviewed-by: Star Zeng Reviewed-by: Laszlo Ersek --- .../Universal/Console/TerminalDxe/Terminal.h | 12 --------- .../Console/TerminalDxe/TerminalConIn.c | 25 ------------------- 2 files changed, 37 deletions(-) diff --git a/MdeModulePkg/Universal/Console/TerminalDxe/Terminal.h b/MdeModulePkg/Universal/Console/TerminalDxe/Terminal.h index a4543fc8de..84808d55a0 100644 --- a/MdeModulePkg/Universal/Console/TerminalDxe/Terminal.h +++ b/MdeModulePkg/Universal/Console/TerminalDxe/Terminal.h @@ -1131,18 +1131,6 @@ IsUnicodeFiFoFull ( TERMINAL_DEV *TerminalDevice ); -/** - Count Unicode FIFO buffer. - - @param TerminalDevice Terminal driver private structure - - @return The count in bytes of Unicode FIFO. - -**/ -UINT8 -UnicodeFiFoGetKeyCount ( - TERMINAL_DEV *TerminalDevice - ); /** Translate raw data into Unicode (according to different encode), and diff --git a/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c b/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c index 80c4f6b483..33f9b6e585 100644 --- a/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c +++ b/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c @@ -1200,31 +1200,6 @@ IsUnicodeFiFoFull ( return FALSE; } -/** - Count Unicode FIFO buffer. - - @param TerminalDevice Terminal driver private structure - - @return The count in bytes of Unicode FIFO. - -**/ -UINT8 -UnicodeFiFoGetKeyCount ( - TERMINAL_DEV *TerminalDevice - ) -{ - UINT8 Tail; - UINT8 Head; - - Tail = TerminalDevice->UnicodeFiFo->Tail; - Head = TerminalDevice->UnicodeFiFo->Head; - - if (Tail >= Head) { - return (UINT8) (Tail - Head); - } else { - return (UINT8) (Tail + FIFO_MAX_NUMBER + 1 - Head); - } -} /** Update the Unicode characters from a terminal input device into EFI Keys FIFO. -- 2.39.2