From bd07919cc8dc602c51a83601f91151bf0a4f479e Mon Sep 17 00:00:00 2001 From: li-elvin Date: Fri, 17 Aug 2012 04:01:48 +0000 Subject: [PATCH] Add missing break and add comment to non-necessary break. Signed-off-by: Li Elvin Reviewed-by: Ni Ruiyu Reviewed-by: Dong Eric git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13642 6f19259b-4bc3-4df7-8a09-765794883524 --- MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c | 2 ++ MdeModulePkg/Universal/DevicePathDxe/DevicePathFromText.c | 3 ++- MdeModulePkg/Universal/SetupBrowserDxe/Ui.c | 4 +++- 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c b/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c index d80c3d5c6f..1a88a746cb 100644 --- a/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c +++ b/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c @@ -1457,6 +1457,7 @@ UnicodeToEfiKey ( if (TerminalDevice->TerminalType == PCANSITYPE) { Key.ScanCode = SCAN_F10; } + break; case '?': if (TerminalDevice->TerminalType == VT100TYPE) { Key.ScanCode = SCAN_PAGE_UP; @@ -1471,6 +1472,7 @@ UnicodeToEfiKey ( if (TerminalDevice->TerminalType == PCANSITYPE) { Key.ScanCode = SCAN_F9; } + break; case '/': if (TerminalDevice->TerminalType == VT100TYPE) { Key.ScanCode = SCAN_PAGE_DOWN; diff --git a/MdeModulePkg/Universal/DevicePathDxe/DevicePathFromText.c b/MdeModulePkg/Universal/DevicePathDxe/DevicePathFromText.c index 11f5c159df..d94e149e58 100644 --- a/MdeModulePkg/Universal/DevicePathDxe/DevicePathFromText.c +++ b/MdeModulePkg/Universal/DevicePathDxe/DevicePathFromText.c @@ -1,7 +1,7 @@ /** @file DevicePathFromText protocol as defined in the UEFI 2.0 specification. -Copyright (c) 2006 - 2011, Intel Corporation. All rights reserved.
+Copyright (c) 2006 - 2012, Intel Corporation. All rights reserved.
This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License which accompanies this distribution. The full text of the license may be found at @@ -2006,6 +2006,7 @@ DevPathFromTextUart ( case L'S': Uart->Parity = 5; + break; default: Uart->Parity = 0xff; diff --git a/MdeModulePkg/Universal/SetupBrowserDxe/Ui.c b/MdeModulePkg/Universal/SetupBrowserDxe/Ui.c index e16b2e424a..f48afbf66c 100644 --- a/MdeModulePkg/Universal/SetupBrowserDxe/Ui.c +++ b/MdeModulePkg/Universal/SetupBrowserDxe/Ui.c @@ -767,7 +767,9 @@ UiAddMenuOption ( // MenuOption->GrayOut = TRUE; } - + // + // break skipped on purpose + // default: MenuOption->IsQuestion = FALSE; break; -- 2.39.2