From 5f0871e3d86da7ef6e7327da7400af3a977c5c36 Mon Sep 17 00:00:00 2001 From: Star Zeng Date: Tue, 15 Jan 2019 15:01:58 +0800 Subject: [PATCH] MdeModulePkg Variable: Move "extern XXX" to Variable.h REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1323 Merge EmuVariable and Real variable driver. Move "extern XXX" to Variable.h from VariableDxe.c/VariableSmm.c. This patch prepares for adding emulated variable NV mode support in VariableRuntimeDxe. Cc: Jian J Wang Cc: Hao Wu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng Reviewed-by: Jian J Wang Reviewed-by: Hao Wu Tested-by: Julien Grall Acked-by: Julien Grall --- MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.h | 11 ++++++++--- .../Universal/Variable/RuntimeDxe/VariableDxe.c | 4 ---- .../Universal/Variable/RuntimeDxe/VariableSmm.c | 3 --- 3 files changed, 8 insertions(+), 10 deletions(-) diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.h b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.h index 938eb5de61..90507a8e64 100644 --- a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.h +++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.h @@ -792,9 +792,14 @@ InitializeVariableQuota ( VOID ); -extern VARIABLE_MODULE_GLOBAL *mVariableModuleGlobal; - -extern AUTH_VAR_LIB_CONTEXT_OUT mAuthContextOut; +extern VARIABLE_MODULE_GLOBAL *mVariableModuleGlobal; +extern EFI_FIRMWARE_VOLUME_HEADER *mNvFvHeaderCache; +extern VARIABLE_STORE_HEADER *mNvVariableCache; +extern VARIABLE_INFO_ENTRY *gVariableInfo; +extern BOOLEAN mEndOfDxe; +extern VAR_CHECK_REQUEST_SOURCE mRequestSource; + +extern AUTH_VAR_LIB_CONTEXT_OUT mAuthContextOut; /** Finds variable in storage blocks of volatile and non-volatile storage areas. diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableDxe.c b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableDxe.c index f7185df3a7..f1304c9dbc 100644 --- a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableDxe.c +++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableDxe.c @@ -17,13 +17,9 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. #include "Variable.h" -extern VARIABLE_STORE_HEADER *mNvVariableCache; -extern EFI_FIRMWARE_VOLUME_HEADER *mNvFvHeaderCache; -extern VARIABLE_INFO_ENTRY *gVariableInfo; EFI_HANDLE mHandle = NULL; EFI_EVENT mVirtualAddressChangeEvent = NULL; EFI_EVENT mFtwRegistration = NULL; -extern BOOLEAN mEndOfDxe; VOID ***mVarCheckAddressPointer = NULL; UINTN mVarCheckAddressPointerCount = 0; EDKII_VARIABLE_LOCK_PROTOCOL mVariableLock = { VariableLockRequestToLock }; diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.c b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.c index 5aa70d7416..0d00c92872 100644 --- a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.c +++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.c @@ -37,12 +37,9 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. #include #include "Variable.h" -extern VARIABLE_INFO_ENTRY *gVariableInfo; BOOLEAN mAtRuntime = FALSE; UINT8 *mVariableBufferPayload = NULL; UINTN mVariableBufferPayloadSize; -extern BOOLEAN mEndOfDxe; -extern VAR_CHECK_REQUEST_SOURCE mRequestSource; /** SecureBoot Hook for SetVariable. -- 2.39.2