From 7b1bf9f61b743d137b529a97c3107aa392b635a8 Mon Sep 17 00:00:00 2001 From: vanjeff Date: Thu, 4 Sep 2008 06:16:14 +0000 Subject: [PATCH] added additional comments and fixed some typo. git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5810 6f19259b-4bc3-4df7-8a09-765794883524 --- MdePkg/Include/Pi/PiDependency.h | 11 +++++--- MdePkg/Include/Pi/PiDxeCis.h | 2 +- MdePkg/Include/Pi/PiFirmwareFile.h | 6 ++++- MdePkg/Include/Pi/PiHob.h | 42 ++++++++++++++++-------------- MdePkg/Include/Pi/PiPeiCis.h | 6 ++--- 5 files changed, 39 insertions(+), 28 deletions(-) diff --git a/MdePkg/Include/Pi/PiDependency.h b/MdePkg/Include/Pi/PiDependency.h index 4dbf42ffad..fe552e8064 100644 --- a/MdePkg/Include/Pi/PiDependency.h +++ b/MdePkg/Include/Pi/PiDependency.h @@ -1,7 +1,7 @@ /** @file Present the dependency expression values in PI. - Copyright (c) 2006 - 2007, Intel Corporation + Copyright (c) 2006 - 2008, Intel Corporation All rights reserved. This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License which accompanies this distribution. The full text of the license may be found at @@ -18,12 +18,14 @@ #define __PI_DEPENDENCY_H__ /// -/// If present, this must be the first and only opcode +/// If present, this must be the first and only opcode, +/// EFI_DEP_BEFORE is only used by DXE driver. /// #define EFI_DEP_BEFORE 0x00 /// -/// If present, this must be the first and only opcode +/// If present, this must be the first and only opcode, +/// EFI_DEP_AFTER is only used by DXE driver. /// #define EFI_DEP_AFTER 0x01 @@ -37,7 +39,8 @@ /// -/// If present, this must be the first opcode. +/// If present, this must be the first opcode, +/// EFI_DEP_SOR is only used by DXE driver. /// #define EFI_DEP_SOR 0x09 diff --git a/MdePkg/Include/Pi/PiDxeCis.h b/MdePkg/Include/Pi/PiDxeCis.h index 574ee464f9..81c973917a 100644 --- a/MdePkg/Include/Pi/PiDxeCis.h +++ b/MdePkg/Include/Pi/PiDxeCis.h @@ -1,7 +1,7 @@ /** @file Include file matches things in PI. - Copyright (c) 2006 - 2007, Intel Corporation + Copyright (c) 2006 - 2008, Intel Corporation All rights reserved. This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License which accompanies this distribution. The full text of the license may be found at diff --git a/MdePkg/Include/Pi/PiFirmwareFile.h b/MdePkg/Include/Pi/PiFirmwareFile.h index 1fd9da37fa..febebe7314 100644 --- a/MdePkg/Include/Pi/PiFirmwareFile.h +++ b/MdePkg/Include/Pi/PiFirmwareFile.h @@ -1,7 +1,7 @@ /** @file The firmware file related definitions in PI. - Copyright (c) 2006 - 2007, Intel Corporation + Copyright (c) 2006 - 2008, Intel Corporation All rights reserved. This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License which accompanies this distribution. The full text of the license may be found at @@ -225,6 +225,10 @@ typedef struct { typedef struct { EFI_COMMON_SECTION_HEADER CommonHeader; UINT16 BuildNumber; + + /// + /// Array of unicode string. + /// CHAR16 VersionString[1]; } EFI_VERSION_SECTION; diff --git a/MdePkg/Include/Pi/PiHob.h b/MdePkg/Include/Pi/PiHob.h index 4dd9761fc6..ffaaea1e0f 100644 --- a/MdePkg/Include/Pi/PiHob.h +++ b/MdePkg/Include/Pi/PiHob.h @@ -1,7 +1,7 @@ /** @file HOB related definitions in PI. - Copyright (c) 2006 - 2007, Intel Corporation + Copyright (c) 2006 - 2008, Intel Corporation All rights reserved. This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License which accompanies this distribution. The full text of the license may be found at @@ -69,9 +69,11 @@ typedef struct { EFI_PHYSICAL_ADDRESS EfiEndOfHobList; } EFI_HOB_HANDOFF_INFO_TABLE; +/// /// EFI_HOB_MEMORY_ALLOCATION_HEADER describes the /// various attributes of the logical memory allocation. The type field will be used for /// subsequent inclusion in the UEFI memory map. +/// typedef struct { /// /// A GUID that defines the memory allocation region¡¯s type and purpose, as well as @@ -87,7 +89,9 @@ typedef struct { /// specification. EFI_PHYSICAL_ADDRESS MemoryBaseAddress; + /// /// The length in bytes of memory allocated by this HOB. + /// UINT64 MemoryLength; /// @@ -146,8 +150,8 @@ typedef struct { typedef struct { EFI_HOB_GENERIC_HEADER Header; EFI_HOB_MEMORY_ALLOCATION_HEADER MemoryAllocationHeader; - EFI_GUID ModuleName; - EFI_PHYSICAL_ADDRESS EntryPoint; + EFI_GUID ModuleName; + EFI_PHYSICAL_ADDRESS EntryPoint; } EFI_HOB_MEMORY_ALLOCATION_MODULE; /// @@ -183,21 +187,21 @@ typedef UINT32 EFI_RESOURCE_ATTRIBUTE_TYPE; // // The rest of the settings describe capabilities // -#define EFI_RESOURCE_ATTRIBUTE_SINGLE_BIT_ECC 0x00000008 -#define EFI_RESOURCE_ATTRIBUTE_MULTIPLE_BIT_ECC 0x00000010 -#define EFI_RESOURCE_ATTRIBUTE_ECC_RESERVED_1 0x00000020 -#define EFI_RESOURCE_ATTRIBUTE_ECC_RESERVED_2 0x00000040 -#define EFI_RESOURCE_ATTRIBUTE_READ_PROTECTED 0x00000080 -#define EFI_RESOURCE_ATTRIBUTE_WRITE_PROTECTED 0x00000100 -#define EFI_RESOURCE_ATTRIBUTE_EXECUTION_PROTECTED 0x00000200 -#define EFI_RESOURCE_ATTRIBUTE_UNCACHEABLE 0x00000400 -#define EFI_RESOURCE_ATTRIBUTE_WRITE_COMBINEABLE 0x00000800 +#define EFI_RESOURCE_ATTRIBUTE_SINGLE_BIT_ECC 0x00000008 +#define EFI_RESOURCE_ATTRIBUTE_MULTIPLE_BIT_ECC 0x00000010 +#define EFI_RESOURCE_ATTRIBUTE_ECC_RESERVED_1 0x00000020 +#define EFI_RESOURCE_ATTRIBUTE_ECC_RESERVED_2 0x00000040 +#define EFI_RESOURCE_ATTRIBUTE_READ_PROTECTED 0x00000080 +#define EFI_RESOURCE_ATTRIBUTE_WRITE_PROTECTED 0x00000100 +#define EFI_RESOURCE_ATTRIBUTE_EXECUTION_PROTECTED 0x00000200 +#define EFI_RESOURCE_ATTRIBUTE_UNCACHEABLE 0x00000400 +#define EFI_RESOURCE_ATTRIBUTE_WRITE_COMBINEABLE 0x00000800 #define EFI_RESOURCE_ATTRIBUTE_WRITE_THROUGH_CACHEABLE 0x00001000 -#define EFI_RESOURCE_ATTRIBUTE_WRITE_BACK_CACHEABLE 0x00002000 -#define EFI_RESOURCE_ATTRIBUTE_16_BIT_IO 0x00004000 -#define EFI_RESOURCE_ATTRIBUTE_32_BIT_IO 0x00008000 -#define EFI_RESOURCE_ATTRIBUTE_64_BIT_IO 0x00010000 -#define EFI_RESOURCE_ATTRIBUTE_UNCACHED_EXPORTED 0x00020000 +#define EFI_RESOURCE_ATTRIBUTE_WRITE_BACK_CACHEABLE 0x00002000 +#define EFI_RESOURCE_ATTRIBUTE_16_BIT_IO 0x00004000 +#define EFI_RESOURCE_ATTRIBUTE_32_BIT_IO 0x00008000 +#define EFI_RESOURCE_ATTRIBUTE_64_BIT_IO 0x00010000 +#define EFI_RESOURCE_ATTRIBUTE_UNCACHED_EXPORTED 0x00020000 /// /// Describes the resource properties of all fixed, @@ -231,8 +235,8 @@ typedef struct { /// typedef struct { EFI_HOB_GENERIC_HEADER Header; - EFI_PHYSICAL_ADDRESS BaseAddress; - UINT64 Length; + EFI_PHYSICAL_ADDRESS BaseAddress; + UINT64 Length; } EFI_HOB_FIRMWARE_VOLUME; /// diff --git a/MdePkg/Include/Pi/PiPeiCis.h b/MdePkg/Include/Pi/PiPeiCis.h index e866a16da5..34691a0851 100644 --- a/MdePkg/Include/Pi/PiPeiCis.h +++ b/MdePkg/Include/Pi/PiPeiCis.h @@ -1,7 +1,7 @@ /** @file PI PEI master include file. This file should match the PI spec. - Copyright (c) 2006 - 2007, Intel Corporation + Copyright (c) 2006 - 2008, Intel Corporation All rights reserved. This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License which accompanies this distribution. The full text of the license may be found at @@ -282,7 +282,7 @@ EFI_STATUS IN CONST EFI_PEI_SERVICES **PeiServices, IN UINT16 Type, IN UINT16 Length, - OUT VOID **Hob + IN OUT VOID **Hob ); /** @@ -297,7 +297,7 @@ EFI_STATUS @retval EFI_SUCCESS The volume was found. @retval EFI_NOT_FOUND The volume was not found. - @retval EFI_INVALID_PARAMETER VolHandle is NULL + @retval EFI_INVALID_PARAMETER VolumeHandle is NULL. **/ typedef -- 2.39.2